Re: [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 12 April 2018 at 02:55, Laszlo Ersek <lersek@redhat.com> wrote:
> PlatformHasAcpiDtDxe consumes the DynamicHii PCD called
> "gArmVirtTokenSpaceGuid.PcdForceNoAcpi". The PcdGetBool() library call
> terminates in gRT->GetVariable(), in the MdeModulePkg/Universal/PCD/Dxe
> driver. Put "gEfiVariableArchProtocolGuid" on PlatformHasAcpiDtDxe's DEPEX
> so that we not attempt the call before the PCD driver can successfully
> read non-volatile variables.
>

OK, so does this mean that UefiRuntimeServicesTableLib deliberately
does not depex on gEfiVariableArchProtocolGuid, and it will return
EFI_NOT_AVAILABLE_YET when called too early? If that is the case, I
would assume it is the responsibility of the PcdLib implementation to
deal with that, not the PcdLib clients.


> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Steve Capper <steve.capper@linaro.org>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
> index 5351e741aa41..8346f7f24b32 100644
> --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
> @@ -44,7 +44,7 @@ [Guids]
>    gEdkiiPlatformHasDeviceTreeGuid ## SOMETIMES_PRODUCES ## PROTOCOL
>
>  [Pcd]
>    gArmVirtTokenSpaceGuid.PcdForceNoAcpi
>
>  [Depex]
> -  TRUE
> +  gEfiVariableArchProtocolGuid
> --
> 2.14.1.3.gb7cf6e02401b
>
>