From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0174A226EAC68 for ; Wed, 11 Apr 2018 23:28:22 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id e79so5084676ioi.7 for ; Wed, 11 Apr 2018 23:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Q5Ce2Of5R1HwkUtsO+AtVQAY+IYVUSxZ9zM6VsjBZPM=; b=Y0dt1ZkOsfTCFMZSirMlSUniJYDy51IpvVLRssM+pj2odAWKFn0FHERGAzDd/d4tJj LQktnq3LUlLPidq0N7mdf6Ancc0XyRnWRgll4d4PkCr5V+GomC1hR3/CtEc1xiIa9wJA YujzKOFr4NzfEndvfIbcYdOFseXLkSSWmLSQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Q5Ce2Of5R1HwkUtsO+AtVQAY+IYVUSxZ9zM6VsjBZPM=; b=otAR4rL+4HpeL5upDe7MSKnzO/Z4CPSbDmozQDT1YDiFzbAu6G5QQaxNcR0mmFuB0C GCgBTKADXbXg/ryqFGZGK0Jz0kbCkYJCuBnGnRvRlKZLSWrmeXTXmRsNsDtsDEvuwWzy G+SNZ8EGgWon6+Q0gnjbWjvg/J8+X92eQ8DAM5PqTT4X/DsR0APGQUq+ECp6auDfeTGO lcjqZnuFA5hRT3mZ9X04PCjXcsvORsWejiUoElgouKNBqW/1IOVRo9kO6PZhkQM0QvfB P2gsXxT7hhMjfDIXvynGNeou0tfcPIXXcizmiLlfomon5m/lYl7WfQJXw/+mFB1O0RsB vhjA== X-Gm-Message-State: ALQs6tD8Y8RkY9LAqEDy/sFQ+9v+pI/ptVA/NzlZi5t51BnhJOkDBwU7 aOwFzRgkwiWjBxpzGX3iQlFKZm8BJWAPYfM+sAZq0dHGWmI= X-Google-Smtp-Source: AIpwx49cOgaQ7dsfC3NEvA3GAWJIOztHcOltOq18G20SEFw5WyrrUULsF/OlyOdty1A2ihDFcZu9BeHdz4m+zow5ZEU= X-Received: by 10.107.14.136 with SMTP id 130mr7537752ioo.170.1523514501961; Wed, 11 Apr 2018 23:28:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Wed, 11 Apr 2018 23:28:21 -0700 (PDT) In-Reply-To: <20180412005540.26651-10-lersek@redhat.com> References: <20180412005540.26651-1-lersek@redhat.com> <20180412005540.26651-10-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 12 Apr 2018 08:28:21 +0200 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Steve Capper , Supreeth Venkatesh Subject: Re: [PATCH 09/10] ArmVirtPkg/PlatformHasAcpiDtDxe: depend on gEfiVariableArchProtocolGuid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 06:28:23 -0000 Content-Type: text/plain; charset="UTF-8" On 12 April 2018 at 02:55, Laszlo Ersek wrote: > PlatformHasAcpiDtDxe consumes the DynamicHii PCD called > "gArmVirtTokenSpaceGuid.PcdForceNoAcpi". The PcdGetBool() library call > terminates in gRT->GetVariable(), in the MdeModulePkg/Universal/PCD/Dxe > driver. Put "gEfiVariableArchProtocolGuid" on PlatformHasAcpiDtDxe's DEPEX > so that we not attempt the call before the PCD driver can successfully > read non-volatile variables. > OK, so does this mean that UefiRuntimeServicesTableLib deliberately does not depex on gEfiVariableArchProtocolGuid, and it will return EFI_NOT_AVAILABLE_YET when called too early? If that is the case, I would assume it is the responsibility of the PcdLib implementation to deal with that, not the PcdLib clients. > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Steve Capper > Cc: Supreeth Venkatesh > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > index 5351e741aa41..8346f7f24b32 100644 > --- a/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > +++ b/ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > @@ -44,7 +44,7 @@ [Guids] > gEdkiiPlatformHasDeviceTreeGuid ## SOMETIMES_PRODUCES ## PROTOCOL > > [Pcd] > gArmVirtTokenSpaceGuid.PcdForceNoAcpi > > [Depex] > - TRUE > + gEfiVariableArchProtocolGuid > -- > 2.14.1.3.gb7cf6e02401b > >