From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C0AB52034BBF7 for ; Thu, 9 Nov 2017 01:17:22 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id 97so9083988iok.7 for ; Thu, 09 Nov 2017 01:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=j44BT0MOldWAR5MbpLG8D1DpRIE4zxcuVNcdIQ8UO8I=; b=ZXeM6YNOaBSx7w3/BB2jxbslxGDc4V35FjWMvMaoNB+VM7R0kCS1y7w8X7mSGkh/V1 LBVqwmgydllAwT/TVuforPqlZBmPf+xhIN7F0BU6wtqr7qpUFUInClkVXilKgqPsfe4p zvnSm3fDLwHrO59PKba7hJkWFnNNXtTf4MPAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=j44BT0MOldWAR5MbpLG8D1DpRIE4zxcuVNcdIQ8UO8I=; b=FD7XsoRH6PjcSnb50IGiBcDThC9q6GiD9Gi3qXTpZD0qvuEBWOu+AmqDHWidIBuj5Z JeP7M1b1Iix7miQN7q/zAbOeIPNhWBkJgakXe3ddZpvwYisX/IryTkZKbUjWkp42l+VX OCIYJBph9q5qiz4yIt7vLUx7eBZ+V+RSNx375MAkZFnVBxfzfaz4V1Aegjub/eKqnER4 j8EMcq9/rQLyrjJkTa1aiYDWnwSswDvjjsU8DgQJcKmoOOs/AIVKZqDYuiSvEO3zlvLd XvUDAvSfO8otnNide/lOJwJm7di/vyhBzGyNBemouq+Kvs5eIu3HezCe+Bn0XqVlccVm TN/w== X-Gm-Message-State: AJaThX4yklATU6QCcRxAoEFY0IO/RvU5nSzQ89EMx/KPOWud8sOiqHJh vefNrVTOFFC5Gd5qdkcxEziKRMEuKxtYg5QfweL7LA== X-Google-Smtp-Source: AGs4zMYKXggYywu4Qk4DooVdAqEUP23BdZgre6LisHEFOd4DJK1FXGv+IOnF9YUOCmrKdaI6C6LW0Gzuhx5yfibMFO4= X-Received: by 10.107.133.91 with SMTP id h88mr4238929iod.52.1510219283602; Thu, 09 Nov 2017 01:21:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Thu, 9 Nov 2017 01:21:23 -0800 (PST) In-Reply-To: <1510198234-50072-2-git-send-email-huangming23@huawei.com> References: <1510198234-50072-1-git-send-email-huangming23@huawei.com> <1510198234-50072-2-git-send-email-huangming23@huawei.com> From: Ard Biesheuvel Date: Thu, 9 Nov 2017 09:21:23 +0000 Message-ID: To: Ming Huang Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , "guoheyi@huawei.com" , wanghuiqiang , huangming , Jason Zhang , Mengfanrong , waip23@126.com, Liu Yi Subject: Re: [PATCH edk2-non-osi v1] Hisilicon D0x: Remove uncacheable attribute from memory resource HOB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 09:17:23 -0000 Content-Type: text/plain; charset="UTF-8" On 9 November 2017 at 03:30, Ming Huang wrote: > If uncacheable attribute is included in memory resource HOB, > GCD spaces will also have EFI_MEMORY_UC capability, > then NonCoherentPciIoAllocateBuffer of NonDiscoverablePciDeviceDxe > module will allocate DMA buffer of EFI_MEMORY_UC type, which will > cause alignment fault exception with BaseMemoryLibOptDxe. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liu Yi > Signed-off-by: Heyi Guo Acked-by: Ard Biesheuvel As for the commit log, this not only affects NonDiscoverablePciDeviceDxe, it removes the UC attribute from all DRAM regions in the UEFI memory map, which makes much more sense on ARM. > --- > Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi | Bin 90272 -> 90336 bytes > Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi | Bin 152576 -> 152480 bytes > 2 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi > index 354abcc..31e2903 100644 > Binary files a/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D03/MemoryInitPei/MemoryInit.efi differ > diff --git a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi > index b94e0cb..eb71c44 100644 > Binary files a/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi and b/Platform/Hisilicon/D05/MemoryInitPei/MemoryInit.efi differ > -- > 1.9.1 >