* [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib
@ 2018-12-18 18:38 Leif Lindholm
2018-12-19 10:08 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-12-18 18:38 UTC (permalink / raw)
To: edk2-devel
ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still
referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -
so drop them.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --
1 file changed, 2 deletions(-)
diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
index 23c5e563bb..3fbc0548aa 100644
--- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
+++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
@@ -52,8 +52,6 @@ [Pcd]
[FixedPcd]
gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable
gArmPlatformTokenSpaceGuid.PcdCoreCount
- gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
- gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
gAmdStyxTokenSpaceGuid.PcdEnableKcs
gAmdStyxTokenSpaceGuid.PcdSata1PortCount
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib
2018-12-18 18:38 [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib Leif Lindholm
@ 2018-12-19 10:08 ` Ard Biesheuvel
2018-12-19 11:53 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-19 10:08 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still
> referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -
> so drop them.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> index 23c5e563bb..3fbc0548aa 100644
> --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> @@ -52,8 +52,6 @@ [Pcd]
> [FixedPcd]
> gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable
> gArmPlatformTokenSpaceGuid.PcdCoreCount
> - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
> - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
> gAmdStyxTokenSpaceGuid.PcdEnableKcs
> gAmdStyxTokenSpaceGuid.PcdSata1PortCount
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib
2018-12-19 10:08 ` Ard Biesheuvel
@ 2018-12-19 11:53 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2018-12-19 11:53 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Wed, Dec 19, 2018 at 11:08:32AM +0100, Ard Biesheuvel wrote:
> On Tue, 18 Dec 2018 at 19:38, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > ArmPkg PcdArmLinuxFdtMaxOffset and PcdArmLinuxFdtAlignment are still
> > referenced in StyxDtbLoaderLib.inf, but not actually used anywhere -
> > so drop them.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Pushed as c718cc0378.
> > ---
> > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> > index 23c5e563bb..3fbc0548aa 100644
> > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> > @@ -52,8 +52,6 @@ [Pcd]
> > [FixedPcd]
> > gAmdModulePkgTokenSpaceGuid.PcdXgbeEnable
> > gArmPlatformTokenSpaceGuid.PcdCoreCount
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtMaxOffset
> > - gArmTokenSpaceGuid.PcdArmLinuxFdtAlignment
> > gAmdStyxTokenSpaceGuid.PcdEnableKcs
> > gAmdStyxTokenSpaceGuid.PcdSata1PortCount
> >
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-19 11:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-18 18:38 [PATCH edk2-platforms] Silicon/AMD: drop ArmBds remnant Pcd imports from StyxDtbLoaderLib Leif Lindholm
2018-12-19 10:08 ` Ard Biesheuvel
2018-12-19 11:53 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox