Re: [platforms PATCH v3 5/5] Marvell/Armada7k8k: Wire up capsule support

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 4 June 2018 at 18:58, Marcin Wojtas <mw@semihalf.com> wrote:
> Ard,
>
> 2018-06-04 18:47 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>> On 4 June 2018 at 18:41, Marcin Wojtas <mw@semihalf.com> wrote:
>>> All required components are in place, so we can now
>>> add all necessary dependencies to build and use capsule support
>>> for Armada7k8k platforms. It is conditionally enabled
>>> with '-D CAPSULE_ENABLE' flag added during build time.
>>>
>>> Because the capsule generation must be sequential,
>>> due to boot requirements and glueing all binaries
>>> (BLE, ARM-TF, BL33) externally, introduce additional
>>> .dsc and .fdf file solely for creating the capsule.
>>>
>>> In order to build the capsule following parameters
>>> must be passed to the build command of the common file
>>> Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc:
>>>
>>> -D PLATFORM_NAME=<previously built platform name with capsule support>
>>> -D ARM_TRUSTED_FIRMWARE_IMAGE_PREFIX=<path/to/flash-image.bin>
>>>
>>
>> I think there was some miscommunication here:
>>
>> - PREFIX is not a full path, it is a prefix. So in this case, the
>> 'flash-image.bin' part should still be hardcoded, but the DEFINE
>> allows you to specify its location in the directory tree.
>> - apologies for bikeshedding/disagreeing with what Leif said
>> previously, but ARM_TRUSTED_FIRMWARE_IMAGE_PREFIX is not appropriate
>> here, given that flash-image.bin is the entire firmware image, so
>> ARM-TF, UEFI, and other bits and pieces that make up the full image. I
>> understand that Leif wants a generic prefix, but using it in
>> completely different ways (ARM-TF fip vs the entire firmware image)
>> defeats the purpose of that.
>>
>
> So is passing a full path a valid way for you?
>
> If yes, how a about following parameter name: 'FIRMWARE_IMAGE_PATH' ?
>

That works for me