From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64642222F4E0B for ; Sat, 23 Dec 2017 06:08:37 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id m11so20041948iti.1 for ; Sat, 23 Dec 2017 06:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pKcAjcevYcrFjEDa+vViDHsDRtkkxt0vqPkY9BAa/ms=; b=FRBjAY/EBsxJQuyGxC57v3nWqqL68+apKxLFeYsDNPLf9r18q1ZnNZaK8ihBzLaR+9 4nZpZx+da167X3oYZFiQ2BXLVKDhhQA5TKUuRDb/AipBmsXstXpnghSfpZlDRYEkbBov RDwZnicuzTQo4hxesk8HKEEfOGk7bK9u2amAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pKcAjcevYcrFjEDa+vViDHsDRtkkxt0vqPkY9BAa/ms=; b=rDshI4e3XUshWTWSBqXdjKnuMK2+mSpWTdseVPm5xSs9XgpuTe/h5NI2ReeWhxI1CJ BKDQJxDn+sTtUcVjHmotco9jzPggDaqJ5kt7YvQiWTb/5IZvFOgLbTB3NyXp1wZcN4iB Mrkg6XXgS5D5XOkqSOEWKMgL/U0Tiqg/aM6H7o/Nhfxk3B7xiLLwRSBDroPKQi7078+0 GuPvAiMEb/8izOkopbQ0Qu3fnGqnDkiGbXqXLUKjzD1aK4Cd5z/fbFQio5LPzRqNrXal ysAobJ7HVktJDI6PN5Tb6QMplXvzB4kfy6i8Cd86GCvjCy0zYmQW6Ntu1YiR2qbNG7l2 5QJg== X-Gm-Message-State: AKGB3mIcGNe2US9zeMXv89LajWsnxXD6DRwIH6yoVH2EtvULeWHMRIzj Mx/k/0jhFT1ZSzrc9zEOv6pHuiQVRMSUsNup0BNthFM4RD4= X-Google-Smtp-Source: ACJfBotCFLGBOEA7/2am9aP/edRona/WAU0ZPtUfpk3MWpksABpEXa2H+E2K8H/2bHR4DEsLUyNwKJU9Sc0IifS+iRw= X-Received: by 10.36.78.212 with SMTP id r203mr21779328ita.58.1514038407884; Sat, 23 Dec 2017 06:13:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 06:13:27 -0800 (PST) In-Reply-To: <20171222190821.12440-8-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> <20171222190821.12440-8-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 14:13:27 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , <"Matteo.Carlini@arm.com"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"nd@arm.com"@arm.com>, Arvind Chauhan , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com> Subject: Re: [PATCH edk2-platforms v2 07/18] ARM/VExpressPkg: PL111LcdArmVExpressLib: Minor code cleanup X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 14:08:37 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: Girish Pathak > > This minor change removes some unecessary initializations and variables > in PL111LcdArmVExpress.c > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index fd4eea8f8e2397bc7d4ddf4cfe3dcc97a5109edb..11335bb2cef9d7ca2606d4a8671382bf3dc2d254 100644 > --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -203,8 +203,6 @@ LcdPlatformGetVram ( > { > EFI_STATUS Status; > > - Status = EFI_SUCCESS; > - > ASSERT (VramBaseAddress != NULL); > ASSERT (VramSize != NULL); > > @@ -214,6 +212,7 @@ LcdPlatformGetVram ( > case ARM_VE_MOTHERBOARD_SITE: > *VramBaseAddress = (EFI_PHYSICAL_ADDRESS)PL111_CLCD_VRAM_MOTHERBOARD_BASE; > *VramSize = LCD_VRAM_SIZE; > + Status = EFI_SUCCESS; > break; > > case ARM_VE_DAUGHTERBOARD_1_SITE: > @@ -242,7 +241,6 @@ LcdPlatformGetVram ( > if (EFI_ERROR (Status)) { > ASSERT (FALSE); > gBS->FreePages (*VramBaseAddress, EFI_SIZE_TO_PAGES (*VramSize)); > - return Status; > } > break; > > @@ -292,7 +290,6 @@ LcdPlatformSetMode ( > ) > { > EFI_STATUS Status; > - UINT32 LcdSite; > UINT32 OscillatorId; > SYS_CONFIG_FUNCTION Function; > UINT32 SysId; > @@ -302,9 +299,7 @@ LcdPlatformSetMode ( > return EFI_INVALID_PARAMETER; > } > > - LcdSite = PL111_CLCD_SITE; > - > - switch (LcdSite) { > + switch (PL111_CLCD_SITE) { > case ARM_VE_MOTHERBOARD_SITE: > Function = SYS_CFG_OSC; > OscillatorId = PL111_CLCD_MOTHERBOARD_VIDEO_MODE_OSC_ID; > @@ -349,11 +344,8 @@ LcdPlatformSetMode ( > } > > // Set the multiplexer > - Status = ArmPlatformSysConfigSet (SYS_CFG_MUXFPGA, LcdSite); > - if (EFI_ERROR (Status)) { > - ASSERT_EFI_ERROR (Status); > - return Status; > - } > + Status = ArmPlatformSysConfigSet (SYS_CFG_MUXFPGA, PL111_CLCD_SITE); > + ASSERT_EFI_ERROR (Status); > > return Status; > } > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel