From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7CF7B2237A4C3 for ; Mon, 5 Feb 2018 05:52:54 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id 196so15930027iti.5 for ; Mon, 05 Feb 2018 05:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sNb+BgnsL7KbHGrnr7jaHa7I/RMyH2y43hw9QvuVcyE=; b=jUNGpTk1DAaBQB0hjWp9No5obR4982Dbmr2o5dRc7mJY+3Tl+uzjAJO3UTg33Dq9Re yYh4xbc/Xz02rQ71pI5RuLdsrMIo3QvB+dIpGENHTW+nrtBv/IoMpP2Y7qd8/IHSprW1 6o608N8c7AssFa4g6axvIE27otTyE8xxMpfm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sNb+BgnsL7KbHGrnr7jaHa7I/RMyH2y43hw9QvuVcyE=; b=bcGKpvEswXg8rrIUgpDzaT7UNB60QdJjqCi3fuDFUNNcREmWr0I4phNfETWx/c7eVA 4ds27lZqdED9t4D8uguabqBRUKzU2ciE+kbDRmqhz/sCrFpqUkw+IwTXNp3joTbfOkqB U00leQVZMIucC6eEbRqPC3mSEekjoCnp67zpfZQ7A7mO+Qx44+n85yxLdkwhUVYWYB2P p3K5TwuxU8wjgRWBRe255MvlYxOIyGCpT7/EHXz27VZ1TCqxxHFzWLa8/OiD9OQ18gH5 PuSAGIOQRgMj6yAUZRimdpi6p4ZQkmGDE026LgDWrOWPcbEPSFc9VO74+CedlEAHPpxL ScUA== X-Gm-Message-State: AKwxyteneeMv02Knd6oFBjRYQ2kkk3W8UYNdYFrIxCraCSDWIDR429+e npRgFY4mFNMwKHwtVeLTlZMHdQY60S60Zo5l1UxZzQ== X-Google-Smtp-Source: AH8x225pZM31lVreHPyJThcWrIwSp6rGjh9UOuYKgChh5e3Y9EsBvz7Iuyv19EBykvdkZlG0BmfpUCPkWilgGvBd3tw= X-Received: by 10.36.108.208 with SMTP id w199mr28885655itb.102.1517839114817; Mon, 05 Feb 2018 05:58:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Mon, 5 Feb 2018 05:58:34 -0800 (PST) In-Reply-To: References: <20180201111513.13572-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Mon, 5 Feb 2018 14:58:34 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Subject: Re: [PATCH v2] BaseTools/Conf: disable DTC legacy phandle format X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 13:52:55 -0000 Content-Type: text/plain; charset="UTF-8" On 1 February 2018 at 16:53, Laszlo Ersek wrote: > On 02/01/18 12:15, Ard Biesheuvel wrote: >> By default, the device tree compiler emits phandle properties twice: >> one called 'phandle' and another called 'linux,phandle'. Given that >> Linux was updated in early 2010 [0] to accept the former (which is >> what is specified in the ePAPR and device tree specifications), there >> is no point in emitting both when compiling device trees for UEFI >> platforms. >> >> [0] 04b954a673dd02f585a2769c4945a43880faa989 >> "of/flattree: Make the kernel accept ePAPR style phandle information" >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> BaseTools/Conf/build_rule.template | 2 +- >> BaseTools/Conf/tools_def.template | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template >> index 3e6aa8ff0f34..a5e471eb3c10 100755 >> --- a/BaseTools/Conf/build_rule.template >> +++ b/BaseTools/Conf/build_rule.template >> @@ -250,7 +250,7 @@ >> >> >> "$(PP)" $(DTCPP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i >> - "$(DTC)" -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >> + "$(DTC)" $(DTC_FLAGS) -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >> >> [Visual-Form-Representation-File] >> >> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template >> index 482ef263c274..99ad271471d9 100755 >> --- a/BaseTools/Conf/tools_def.template >> +++ b/BaseTools/Conf/tools_def.template >> @@ -4467,6 +4467,7 @@ NOOPT_DDK3790xASL_IPF_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /LTCG /DLL /OPT:REF >> DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug >> RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG = >> NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug >> +*_*_*_DTC_FLAGS = -H epapr >> >> DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common >> DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe >> > > Reviewed-by: Laszlo Ersek Thank you. Liming, any comments?