Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Wed, 24 Apr 2019 at 06:59, Gao, Zhichao <zhichao.gao@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
>
> Add a 'static' descriptor to the global variables that only
> used in a single file to minimize the name collisions.
> This is only for the varable named 'mExitBootServicesEvent'.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c b/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
> index d4fdfbab55..bb7b144569 100644
> --- a/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
> +++ b/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
> @@ -15,9 +15,9 @@
>  //
>  // BOOLEAN value to indicate if it is at the post ExitBootServices pahse
>  //
> -BOOLEAN     mPostEBS = FALSE;
> +BOOLEAN               mPostEBS = FALSE;
>
> -EFI_EVENT   mExitBootServicesEvent;
> +static EFI_EVENT      mExitBootServicesEvent;
>

Please use STATIC not static.


>  //
>  // Pointer to SystemTable
> --
> 2.21.0.windows.1
>
>
> 
>