From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=vwdSdxR4;
 spf=pass (domain: linaro.org, ip: 209.85.166.65, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65])
 by groups.io with SMTP; Wed, 24 Apr 2019 01:07:38 -0700
Received: by mail-io1-f65.google.com with SMTP id u12so4471520iop.0
        for <devel@edk2.groups.io>; Wed, 24 Apr 2019 01:07:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=HLxOpEdUWoXHebHMWT/b+L+mICuaEsdGAWwIZd0nk0Q=;
        b=vwdSdxR4Qy9OCPUU0HOOMpvxR5K4DKYiFXznD6bbVkN9SXliTE3YYJiHF77Wt9m5Cw
         GtHQB+ZmOAbl34ORIDmAeZVKvxe9xxHGmDZJbplv+bl8hixmx32y01j+OC5U+Qy51EOn
         NDrKwa6c5YNGnn3errA6P0QYg3Oj9CHZIF2Dkpk7Vos3j/lI8DtxbAro3hDk0A538PaZ
         9rAA8N8hWxfQN6toUK/ljMRr+Ae4jyGhbc17drMl1q4326vTod6HuzEl7rvybxaS7ewS
         ZIUAV/vc/+Cvkjw2yDkQbioSHc0wYYwLhmotKlsnc2oQW3IZDKEkLlx/Unp+7qR+gtx8
         2a4Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=HLxOpEdUWoXHebHMWT/b+L+mICuaEsdGAWwIZd0nk0Q=;
        b=JiPTJ9moZD+0I2qYHJaVBbMVgY6Ox9y8CRPTwY5ZJKotzNYCPK6jAP8TdPl9ORUFBV
         mF5ehejWzGqV4O3x3JigIqQXZE+sXPzfJTlUMCCvzGrqf29u+FZreuGB9z0tvAyDDJmU
         9pCczTtNs6ZBsx1qJrrcx4lIdTultqTja4RwbFiCSgtx6whXA47OwEP4Q4bZV4QTaxIt
         Ps1e4HUJAU7dni2NM9abaQPc1BLcyLE8KPD17rm1xvu5/5Tv0eLOsFE7RCjuP6WrPUIf
         eI2ZjeFzJZ1lWxTcftPJgXOcxKhg++kE7Zthy4HIIQNPwzqhuf+nuAxU4wIkFmsq/vBR
         Xepg==
X-Gm-Message-State: APjAAAXqyW54tetoJesSKfklBmxXa+c5CauVfnspgmi51YTMiLHtHQAu
	lXuMqZcgk08WxrTor6GloGrZHKe6F7Fi2lmijSkncd6bdQg=
X-Google-Smtp-Source: APXvYqyInjMpitIxAlwGmlexatLcManmF1ae8slraQ+y6NEjSznMRNQiDFt51JntKhVrtBzZyc6cOHotG/doIDn1LQk=
X-Received: by 2002:a5e:9b17:: with SMTP id j23mr21138226iok.60.1556093257030;
 Wed, 24 Apr 2019 01:07:37 -0700 (PDT)
MIME-Version: 1.0
References: <20190424045827.19348-1-zhichao.gao@intel.com> <20190424045827.19348-4-zhichao.gao@intel.com>
In-Reply-To: <20190424045827.19348-4-zhichao.gao@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 24 Apr 2019 10:07:24 +0200
Message-ID: <CAKv+Gu8oZ9ot4CfRBpK=Aqv9RKmP_x-uPy=t9YT2sU8qYpC6xg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions
To: edk2-devel-groups-io <devel@edk2.groups.io>, Zhichao Gao <zhichao.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>, Michael D Kinney <michael.d.kinney@intel.com>, 
	Liming Gao <liming.gao@intel.com>, Dandan Bi <dandan.bi@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 24 Apr 2019 at 06:59, Gao, Zhichao <zhichao.gao@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
>
> Add a 'static' descriptor to the global variables that only
> used in a single file to minimize the name collisions.
> This is only for the varable named 'mExitBootServicesEvent'.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c b/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
> index d4fdfbab55..bb7b144569 100644
> --- a/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
> +++ b/MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
> @@ -15,9 +15,9 @@
>  //
>  // BOOLEAN value to indicate if it is at the post ExitBootServices pahse
>  //
> -BOOLEAN     mPostEBS = FALSE;
> +BOOLEAN               mPostEBS = FALSE;
>
> -EFI_EVENT   mExitBootServicesEvent;
> +static EFI_EVENT      mExitBootServicesEvent;
>

Please use STATIC not static.


>  //
>  // Pointer to SystemTable
> --
> 2.21.0.windows.1
>
>
> 
>