From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=m/O2D2n8; spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193]) by groups.io with SMTP; Sat, 27 Apr 2019 01:14:15 -0700 Received: by mail-it1-f193.google.com with SMTP id y134so9431034itc.5 for ; Sat, 27 Apr 2019 01:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MR3Cr0NX3eNqga3liZpV4hpynL2ac2pN4u/5PutGM8s=; b=m/O2D2n8dvaI+TtNllA9Qj3lJgZ3Cw4ditO225YqBW6h7FRVyLSvlgTyt0y1lOKsO1 xFDGumaI3XcMa7/Oqi02+91sjrFmnoE6igCXu67NDTYe5MxikoW7sH3O7ArulI7y22MI 4m/5TOP7T9dZGXk5iXEaHMo9chZe76Wj5I1We47TWlizLZapEnBF0thfTHrj9q4+SIU6 J6ECjriZ5a/guUyPuUK/A+FUsYOl63A7UyWdOH9Y/bZ2MfIUEHkLFuOHZrHutJykQCeO LeFYRb9GmnectviVIRgSRc65CoUD4LKhBwv2uEJ+P7ZINxglf7VSDn9DSJoQUBZZH09U 1eOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MR3Cr0NX3eNqga3liZpV4hpynL2ac2pN4u/5PutGM8s=; b=hsf1sL2iSoeRHwWl19tUuFbfRN2WlP7h69Xldz6lMPrLY8ATC192fY3sUysb1VsmC/ HZMXztSMSmnKNZn6af3P0TERjDoyeXt1IWS63DaAHWgffqjhHMINgEEGrqsT4cV45k7e u2wo7cJPhk2U64kljIHTulHQ8Ev0914DdmKOBujJZ7zI1sI9Sp7F/3NjlJd6xaPBPWeM 7A9lrdP4tSKAhr9LpwRjRliMOYniNTUQYblSdcMzoTEVWl6qm3iNxpRujE9n+eJfxF8p 7VOvPcX0P+o0I4L89i+0evyWWpincMmLdhwtXnmlrcOuxQqpIE55EvvMqCYX8Zit+V85 Gbwg== X-Gm-Message-State: APjAAAXb8xr+bxFjv5SXauUeQOEB5wSnXGy3y+t9FAgldQZqLWoE1Ixf 8DDTbHZaNaCgj8iw+qkOQs9vSp5Q9lcm2zdsRCLDjg== X-Google-Smtp-Source: APXvYqwIwfjrXtS4EUjQpQcyW9HYfikKCBEIBRIiMdLgZIqfN/dLQqbrawS/QGhDPPb6b9dgxt7cWihVLPfh2uMN8to= X-Received: by 2002:a24:59c1:: with SMTP id p184mr12739333itb.158.1556352854758; Sat, 27 Apr 2019 01:14:14 -0700 (PDT) MIME-Version: 1.0 References: <20190427005328.27005-1-lersek@redhat.com> In-Reply-To: <20190427005328.27005-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Sat, 27 Apr 2019 10:14:02 +0200 Message-ID: Subject: Re: [PATCH 00/16] OvmfPkg, ArmVirtPkg: upstream the EnrollDefaultKeys app To: Laszlo Ersek Cc: edk2-devel-groups-io , Anthony Perard , Jordan Justen , Julien Grall Content-Type: text/plain; charset="UTF-8" On Sat, 27 Apr 2019 at 02:53, Laszlo Ersek wrote: > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Repo: https://github.com/lersek/edk2.git > Branch: enroll_bz_1747 > > Please see the goal / use case in the BZ. > > Anatomy of the series: > > - Patch 01 adds the application as-is from RHEL, as the starting point > for upstreaming (preserves continuity). > > - Patches 02 through 13 clean up various coding style warts, and add > documentation, without functional changes. > > - Patches 14 through 16 replace the hard-coded Red Hat certificate > (enrolled as PK and 1st KEK) with a certificate read dynamically from > SMBIOS (enrolled the same way), originating from the VMM. > > I've successfully re-run the Secure Boot Logo Test in Windows HCK, after > enabling SB in the VM-under-test with this application. I'll attach the > test log in a separate email (sent in response to this one). > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > > Thanks, > Laszlo > > Laszlo Ersek (16): > OvmfPkg: introduce EnrollDefaultKeys application > OvmfPkg/EnrollDefaultKeys: update @file comment blocks > OvmfPkg/EnrollDefaultKeys: refresh INF file > ArmVirtPkg: build EnrollDefaultKeys.efi > OvmfPkg/EnrollDefaultKeys: clean up minor whitespace wart > OvmfPkg/EnrollDefaultKeys: clean up global variable name prefixes > OvmfPkg/EnrollDefaultKeys: clean up acronym capitalization in > identifiers > OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. > specifiers > OvmfPkg/EnrollDefaultKeys: extract typedefs to a header file > OvmfPkg/EnrollDefaultKeys: split out certificate and signature > constants > OvmfPkg/EnrollDefaultKeys: extract MICROSOFT_VENDOR_GUID > OvmfPkg/EnrollDefaultKeys: describe functions with leading comment > blocks > OvmfPkg/EnrollDefaultKeys: document the steps of the entry point > function > OvmfPkg: introduce OVMF_PK_KEK1_APP_PREFIX_GUID > OvmfPkg/EnrollDefaultKeys: enroll PK/KEK1 from the Type 11 SMBIOS > table > OvmfPkg/EnrollDefaultKeys: remove Red Hat's hard-coded PK/KEK1 > I'm still quite unhappy about the way we are buying into using the MS certs for everything even on ARM systems (where vendors care about other certifications beyond the Windows Logo tests) but nonetheless, I see that this has value for ARM as well as x86, so Acked-by: Ard Biesheuvel