From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Michael Kubacki <michael.kubacki@outlook.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH v1 1/1] ArmPlatformPkg/ArmPlatformPkg.dsc: Add missing components
Date: Wed, 25 Mar 2020 10:57:12 +0100 [thread overview]
Message-ID: <CAKv+Gu8p64p2Pbz-90CFgnPso_wgZXUCFszRzDo7cprfAcSjAw@mail.gmail.com> (raw)
In-Reply-To: <MWHPR07MB3440109C6A276D16852668D0E9F10@MWHPR07MB3440.namprd07.prod.outlook.com>
On Tue, 24 Mar 2020 at 20:30, Michael Kubacki
<michael.kubacki@outlook.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2575
>
> The following components are currently missing from the [Components]
> section of ArmPlatformPkg.dsc:
> * ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> * ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
>
> This commit includes the components in the package DSC build.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks Michael
> ---
> ArmPlatformPkg/ArmPlatformPkg.dsc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
> index 11b1672501ce..b19fa98be0ba 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dsc
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
> @@ -4,6 +4,7 @@
> # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
> # Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.<BR>
> # Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -95,6 +96,7 @@
>
> ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
> ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
> + ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.inf
> ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> @@ -102,6 +104,7 @@
> ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
> ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
> ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> + ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
>
> ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
> --
> 2.16.3.windows.1
>
prev parent reply other threads:[~2020-03-25 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 19:30 [PATCH v1 1/1] ArmPlatformPkg/ArmPlatformPkg.dsc: Add missing components Michael Kubacki
2020-03-25 9:57 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8p64p2Pbz-90CFgnPso_wgZXUCFszRzDo7cprfAcSjAw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox