From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by mx.groups.io with SMTP id smtpd.web11.8007.1585130244253735681
 for <devel@edk2.groups.io>;
 Wed, 25 Mar 2020 02:57:24 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=yZbpRai5;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f68.google.com with SMTP id d198so1659804wmd.0
        for <devel@edk2.groups.io>; Wed, 25 Mar 2020 02:57:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Q05FmutfM0szG+P44CQhNJm+OH7TunvuPtSOAkMRcp8=;
        b=yZbpRai5SfCWFSipsQKnI8mU/Ri1Dd2TNygLOkNH0RTc4sIxUyx28ufuRQS8i9EYMh
         fW93Xxrm779U6KXMevkFP6mO05GSwTX4KpeIHTXoWX+aYa3NDEYJ7Ti7FueEZbAJPjgK
         HpmYaVLlMt4vFtPRMKWsPQX3QV7p6tByntUGg+yOAjxUNBLin6QQDBe5n2TOv9Sm9Xo+
         f15stR+iblt5AXNWN2R9ry3WcwmuhD1Atj9zryZ4bMv7CUzi5fW0A2mj0DiU6s/ffH2+
         HJWnutX3gm2tcTV1eDCwoza7M0BmLEgp2cr4Zr7c5LEXv9R1FLbiApHFHt9GmNbRgFu/
         WYNg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Q05FmutfM0szG+P44CQhNJm+OH7TunvuPtSOAkMRcp8=;
        b=lT8V6p+geIGW3wFmh/mnqqQqhR/A6mHqopibPlVVmEnwqKyjcUHqjE7O6w8KH/ZgTT
         ENcbiuTpd+4bckarGB14bSUPH3VDjEATyS/jyLQhRZIK46e9EA5frUDryz8paqUDyr35
         6l9TE2F2MTvf5rkRZjRUfNy2WIU3cSlocIRyfBY3o5ELAjlWzUUjU4+8vKRVgV8KAjUl
         fxKJ9qU7Z9tQWz0wEFypH7ibVJuwkiQjT1WX60hUWLGXLCk473KizhyttnA9QuDoL0eX
         PPvDBRw/IaR7Ce2+Ez7CTwzPwarnlV9gAeDS9LePi4MS5UPWofsLo8Itq9wAU/yDpoHn
         0Tyg==
X-Gm-Message-State: ANhLgQ0w+b6QNNmKV7F8tLArZ3Ctm1AU/PFnFtPE6MJHrLP04H1K2npk
	LaQvwBVJ4BeY+UcWH4zPiiOPMUV2qm1yfNJJwgRNww==
X-Google-Smtp-Source: ADFU+vub4pTcB9WgBxGuwHXUEz7RUJuC7zPThdLBSpcVjS3Oo8xNmUr1jgoe7XEYD/ygaUFMw9uhENp42VT0sG6BvDk=
X-Received: by 2002:a1c:ac8a:: with SMTP id v132mr2553710wme.62.1585130242803;
 Wed, 25 Mar 2020 02:57:22 -0700 (PDT)
MIME-Version: 1.0
References: <MWHPR07MB3440109C6A276D16852668D0E9F10@MWHPR07MB3440.namprd07.prod.outlook.com>
In-Reply-To: <MWHPR07MB3440109C6A276D16852668D0E9F10@MWHPR07MB3440.namprd07.prod.outlook.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 25 Mar 2020 10:57:12 +0100
Message-ID: <CAKv+Gu8p64p2Pbz-90CFgnPso_wgZXUCFszRzDo7cprfAcSjAw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] ArmPlatformPkg/ArmPlatformPkg.dsc: Add missing components
To: Michael Kubacki <michael.kubacki@outlook.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 24 Mar 2020 at 20:30, Michael Kubacki
<michael.kubacki@outlook.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2575
>
> The following components are currently missing from the [Components]
> section of ArmPlatformPkg.dsc:
>   * ArmPlatformPkg/Library/HdLcd/HdLcd.inf
>   * ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
>
> This commit includes the components in the package DSC build.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Michael

> ---
>  ArmPlatformPkg/ArmPlatformPkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
> index 11b1672501ce..b19fa98be0ba 100644
> --- a/ArmPlatformPkg/ArmPlatformPkg.dsc
> +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
> @@ -4,6 +4,7 @@
>  # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
>  # Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.<BR>
>  # Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.<BR>
>  #
>  #    SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -95,6 +96,7 @@
>
>    ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
>    ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
> +  ArmPlatformPkg/Library/HdLcd/HdLcd.inf
>    ArmPlatformPkg/Library/LcdHwNullLib/LcdHwNullLib.inf
>    ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
>    ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
> @@ -102,6 +104,7 @@
>    ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
>    ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>    ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
> +  ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
>    ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
>
>    ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
> --
> 2.16.3.windows.1
>