From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9DF9F21ED1C75 for ; Fri, 16 Mar 2018 07:02:03 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id d71so12796554iog.4 for ; Fri, 16 Mar 2018 07:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IK9gmulVmEqpmumZIaI6H0dwLsNen9P+s0v/4NKPG5g=; b=GIcE9SyCWECfFoZlGNjNtP7/Ry/fO513RzXNC3JM1caKMO93nJKHUo1HI9M9rI5jvh 8dj3YQ3ZQ6916aBKknffi7FEiw5CuiTA5pSfH40KOACrpS5xIkh1LVkmHuQpQxeBYpef 2HvlDFHkLjWpwaZDhRLfpAYiS4rLel2CXkBqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IK9gmulVmEqpmumZIaI6H0dwLsNen9P+s0v/4NKPG5g=; b=JQ7j9UivF3vlMwDJSVTqekNBhOi6O/OehP2TqfyfkARjfeckHLeVvNGeHOyLXYm1PL i/+jLQksFeBTRmjBBqgXL+GGoQe41b1jTGH4lXXPsx02OVWnelU+YOvu9e8vBiwFA/8P RF1UbDS8PnX7KaXRG0RSk6fccjqmFv4egiUCGDdYLibhnulVgDY353wC0jQ62dTtdPZD SeNKGQ75kXPKexVTRIFwmECLTQRuaQyfEmhs5D7nyHAdK/bQ75ZctSELJil1VQoPVugL LhsYI53CRftKGS71PERjZ7nnb0oAnGpXoIjIxM7IbtBRIxDC0pVxo68C/QS+43WNVrKh 0qHg== X-Gm-Message-State: AElRT7HwqcR1lmLaoUyDBjDkwd8+U9jEcKKV6iiJkbKSjBa9x3N9MV4P xMAbzqdxMJ1ZjFAkoGth4aarZF+nmpB3UyPMJ7q4Jg== X-Google-Smtp-Source: AG47ELsZFauEAHMD3Xm2fCdMF1ph4vbpbwwuOhROPQySKDuFuKOhJLjEM/VdchOfFNQKxnW8OLABcuPaNVyLUckTIOY= X-Received: by 10.107.151.74 with SMTP id z71mr1874711iod.277.1521209307921; Fri, 16 Mar 2018 07:08:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 16 Mar 2018 07:08:27 -0700 (PDT) In-Reply-To: <20180315190258.6580-1-lersek@redhat.com> References: <20180315190258.6580-1-lersek@redhat.com> From: Ard Biesheuvel Date: Fri, 16 Mar 2018 14:08:27 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , "Gabriel L. Somlo" , "Richard W.M. Jones" , Jordan Justen , Xiang Zheng Subject: Re: [PATCH 0/5] ArmVirtPkg, OvmfPkg: improve firmware duration of direct kernel boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 14:02:04 -0000 Content-Type: text/plain; charset="UTF-8" On 15 March 2018 at 19:02, Laszlo Ersek wrote: > (Copying Rich, Xiang and Gabriel for testing requests below.) > > Repo: https://github.com/lersek/edk2.git > Branch: kernel_before_bootdevs > > After the recent series "OvmfPkg, ArmVirtQemu: leaner platform BDS > policy for connecting devices", I'm picking up another earlier idea -- a > direct kernel boot does not need devices such as disks and NICs to be > bound by UEFI. > > I tested this series extensively on QEMU, in OVMF (IA32X64) and > ArmVirtQemu (AARCH64), both with and without direct kernel boot. I > compared the logs in all sensible relations within a given architecture. > > Rich, can you please test this on ARM64, with guestfish/libguestfs? > Please attach a good number of disks at once on the command line, and > compare the appliance's boot time between (e.g.) RHEL7's > "/usr/share/AAVMF/AAVMF_CODE.fd" and the following binary (after > decompression): > > https://people.redhat.com/lersek/kernel_before_bootdevs-991e2f2f-64cf-4566-b933-919928e2aa6b/QEMU_EFI.fd.padded.xz > > (That binary corresponds to the branch linked above, cross-built from > x86_64 with "aarch64-linux-gnu-gcc (GCC) 6.1.1 20160621 (Red Hat Cross > 6.1.1-2)", using the following options: > > export GCC5_AARCH64_PREFIX=aarch64-linux-gnu- > build --cmd-len=65536 --hash -t GCC5 -b DEBUG -a AARCH64 \ > -p ArmVirtPkg/ArmVirtQemu.dsc -D DEBUG_PRINT_ERROR_LEVEL=0x80000000 > > and then it was padded with zeroes to 64MB.) > > If you have good results, please respond with your Tested-by (which I'll > apply to patch 1/5, since that's the one that matters for the ARM64 > target). > > Xiang, if you use guestfish (or else direct kernel boot) occasionally, > then similar testing would be very welcome from your side too. > > Gabriel, I'm CC'ing you on patch 4/5, because it affects code that you > had originally written. Can you please regression-test this series with > your usual OVMF environment / guest(s)? > > Cc: "Gabriel L. Somlo" > Cc: "Richard W.M. Jones" > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Xiang Zheng > > Thanks everyone! > Laszlo > > Laszlo Ersek (5): > ArmVirtPkg/PlatformBootManagerLib: return to "-kernel before boot > devices" > OvmfPkg/PlatformBootManagerLib: wrap overlong lines in "BdsPlatform.c" > OvmfPkg/PlatformBootManagerLib: rejuvenate old-style function comments > OvmfPkg/PlatformBootManagerLib: hoist PciAcpiInitialization() > OvmfPkg/PlatformBootManagerLib: process "-kernel" before boot devices > > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 16 +- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 262 ++++++++++---------- > 2 files changed, 136 insertions(+), 142 deletions(-) > For the series Reviewed-by: Ard Biesheuvel