* EmbeddedPkg : Corrected flow for setting Buswidth for eMMC
@ 2018-12-04 10:28 Meenakshi Aggarwal
2018-12-04 14:47 ` Ard Biesheuvel
2018-12-21 19:23 ` Leif Lindholm
0 siblings, 2 replies; 3+ messages in thread
From: Meenakshi Aggarwal @ 2018-12-04 10:28 UTC (permalink / raw)
To: ard.biesheuvel, leif.lindholm, michael.d.kinney, edk2-devel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
---
EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
index f661a0c..9118eb2 100755
--- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
+++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
@@ -309,11 +309,14 @@ InitializeEmmcDevice (
}
Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, BusMode);
if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status));
+ continue;
+ } else {
+ DEBUG ((DEBUG_INFO, "InitializeEmmcDevice(): Set EXTCSD bus width %d successfully\n", BusMode));
+ break;
}
- return Status;
}
}
+
return Status;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: EmbeddedPkg : Corrected flow for setting Buswidth for eMMC
2018-12-04 10:28 EmbeddedPkg : Corrected flow for setting Buswidth for eMMC Meenakshi Aggarwal
@ 2018-12-04 14:47 ` Ard Biesheuvel
2018-12-21 19:23 ` Leif Lindholm
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-04 14:47 UTC (permalink / raw)
To: Meenakshi Aggarwal
Cc: Leif Lindholm, Kinney, Michael D, edk2-devel@lists.01.org
Please explain
- what was wrong and why
- how this change fixes it
and put it in the commit log.
Thanks,
On Tue, 4 Dec 2018 at 05:42, Meenakshi Aggarwal
<meenakshi.aggarwal@nxp.com> wrote:
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
> EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> index f661a0c..9118eb2 100755
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> @@ -309,11 +309,14 @@ InitializeEmmcDevice (
> }
> Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, BusMode);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status));
> + continue;
> + } else {
> + DEBUG ((DEBUG_INFO, "InitializeEmmcDevice(): Set EXTCSD bus width %d successfully\n", BusMode));
> + break;
> }
> - return Status;
> }
> }
> +
> return Status;
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: EmbeddedPkg : Corrected flow for setting Buswidth for eMMC
2018-12-04 10:28 EmbeddedPkg : Corrected flow for setting Buswidth for eMMC Meenakshi Aggarwal
2018-12-04 14:47 ` Ard Biesheuvel
@ 2018-12-21 19:23 ` Leif Lindholm
1 sibling, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2018-12-21 19:23 UTC (permalink / raw)
To: Meenakshi Aggarwal; +Cc: ard.biesheuvel, michael.d.kinney, edk2-devel
What is the incorrectness that is being resolved, and how is it being
resolved?
(Add a commit message, please.)
On Tue, Dec 04, 2018 at 03:58:50PM +0530, Meenakshi Aggarwal wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
> EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> index f661a0c..9118eb2 100755
> --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c
> @@ -309,11 +309,14 @@ InitializeEmmcDevice (
> }
> Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, BusMode);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status));
> + continue;
> + } else {
> + DEBUG ((DEBUG_INFO, "InitializeEmmcDevice(): Set EXTCSD bus width %d successfully\n", BusMode));
> + break;
> }
> - return Status;
> }
> }
> +
> return Status;
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-21 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-04 10:28 EmbeddedPkg : Corrected flow for setting Buswidth for eMMC Meenakshi Aggarwal
2018-12-04 14:47 ` Ard Biesheuvel
2018-12-21 19:23 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox