From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E15621198CCA for ; Tue, 4 Dec 2018 06:47:44 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id n9so5753429ioo.2 for ; Tue, 04 Dec 2018 06:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=55/ZblEDAt6fteEqRBZL+xY0ILkZIflpT8gm9yUAPUQ=; b=BmJ38OEpiR1oqyhpJlyJyn33g2gklxkL0LXp3QvxuiII+25bToWWRoMAm+0DRwHCD4 0zhb5eKiUy/HTMkCr1XilGT4vLyYAesbpQtHSiOeApWiDGCq8sBzrhWNCoWo4K4jqfLG bjH2wPzywddUNyT/8nl8qn0kuR1qUSxpPS2xI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=55/ZblEDAt6fteEqRBZL+xY0ILkZIflpT8gm9yUAPUQ=; b=A1TlO9udF6LQ0YSaYTye2AWYcqdf2HOthCkh+hWGMzqtQzBNdvKsYxqOkW7JV99URO B7czyVAhyUDO3JWYXL3JZqarzi04gwxEbADBmSOX7aMfhpvGNSfywwP+fOJhd2REKp3l 7n4+RtK1UDprIh+r8sc+9hC+IzLZoDJoftyJ9VhsyEtZU/PcGUSo13OipiRMctMKDXeW agQ4AZvH1UUh250zucpc+GDvZ0LozOBxRdc0nu7SvEtokNXCkPYddyth4dT0r8sVh3ih aPilvvQDDzjt/++6053j+nyhlxQgoxSKQwcR1x1q0RWmW1qxeKFSXE2KewQ6Fbqpq9xM stNw== X-Gm-Message-State: AA+aEWaBE3uggx+4HC5kxQ498atb+Kb0Kpj5f4UwGiUgoFsQ3sQmR/2P RQJktne0KQnfqkYZG7vkMWhnm18XAUkYXuzpIYvOtQ== X-Google-Smtp-Source: AFSGD/WHPGOWoFOVtFEUWsdakfZ0PMcUr+zgkSh/QfK724LYAeXn6ldZnEDXPN+v1upuVFXxqg7Q1xbjPBl86S2bpag= X-Received: by 2002:a5e:cb42:: with SMTP id h2mr11897907iok.60.1543934862910; Tue, 04 Dec 2018 06:47:42 -0800 (PST) MIME-Version: 1.0 References: <1543919330-32761-1-git-send-email-meenakshi.aggarwal@nxp.com> In-Reply-To: <1543919330-32761-1-git-send-email-meenakshi.aggarwal@nxp.com> From: Ard Biesheuvel Date: Tue, 4 Dec 2018 15:47:30 +0100 Message-ID: To: Meenakshi Aggarwal Cc: Leif Lindholm , "Kinney, Michael D" , "edk2-devel@lists.01.org" Subject: Re: EmbeddedPkg : Corrected flow for setting Buswidth for eMMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 14:47:44 -0000 Content-Type: text/plain; charset="UTF-8" Please explain - what was wrong and why - how this change fixes it and put it in the commit log. Thanks, On Tue, 4 Dec 2018 at 05:42, Meenakshi Aggarwal wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Meenakshi Aggarwal > --- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > index f661a0c..9118eb2 100755 > --- a/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > +++ b/EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c > @@ -309,11 +309,14 @@ InitializeEmmcDevice ( > } > Status = EmmcSetEXTCSD (MmcHostInstance, EXTCSD_BUS_WIDTH, BusMode); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "InitializeEmmcDevice(): Failed to set EXTCSD bus width, Status:%r\n", Status)); > + continue; > + } else { > + DEBUG ((DEBUG_INFO, "InitializeEmmcDevice(): Set EXTCSD bus width %d successfully\n", BusMode)); > + break; > } > - return Status; > } > } > + > return Status; > } > > -- > 1.9.1 >