Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Tue, 28 Jan 2020 at 17:08, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 1/28/20 4:05 PM, Krzysztof Koch wrote:
> > Fix 'mAcpiRegistration defined but not used' compiler error for
> > Dynamic Tables Framework builds.
> >
> > Do not declare the mAcpiRegistration variable in the Dynamic Tables
> > Framework context.
> >
> > Commit 484a683ab9f made mAcpiRegistration variable STATIC. Reducing
> > scope made scope resolution simpler, thus, the 'defined but not used'
> > error got raised.
> >
> > Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
> > ---
> >
> > Changes can be seen at: https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_variable_juno_dxe_v2
> >
> > Notes:
> >      v2:
> >      - Specify which previous commit inroduced the error [Philippe]
>
> Thanks for the update.
> Since the change is minor, you could have kept my R-b tag.
> Anyway:
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>

Thanks guys

Pushed as b40c36980ac9..53f658aa61f8

> >
> >      v1:
> >      - Fix 'defined but not used' Dynamic Tables build error [Krzysztof]
> >
> >   Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
> > index e3b64992e02c003f7e3a6636340a6afa573f477a..cd7a205f90f131560419cfd744dd5c22df726c99 100644
> > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
> > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
> > @@ -1,6 +1,6 @@
> >   /** @file
> >   *
> > -*  Copyright (c) 2013-2019, ARM Limited. All rights reserved.
> > +*  Copyright (c) 2013-2020, ARM Limited. All rights reserved.
> >   *
> >   *  SPDX-License-Identifier: BSD-2-Clause-Patent
> >   *
> > @@ -30,9 +30,9 @@
> >   #ifndef DYNAMIC_TABLES_FRAMEWORK
> >   // This GUID must match the FILE_GUID in ArmPlatformPkg/ArmJunoPkg/AcpiTables/AcpiTables.inf
> >   STATIC CONST EFI_GUID mJunoAcpiTableFile = { 0xa1dd808e, 0x1e95, 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } };
> > -#endif
> > -
> >   STATIC VOID *mAcpiRegistration = NULL;
> > +#endif
> > +
> >   STATIC VOID *mPciIoNotificationRegistration = NULL;
> >
> >   /**
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> >
> >
> >
> >
>
>
> 
>