From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.11809.1580227957142769071 for ; Tue, 28 Jan 2020 08:12:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=JWgZUqjw; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id b2so3213844wma.0 for ; Tue, 28 Jan 2020 08:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iQ+9J6f6XcDzQlv+LO/vvVn5hlxK09YYotgKu0OEjog=; b=JWgZUqjw/LQu5Nd+QpH0De3fpOlAc02h9j4MOZ6k/8fhOtSMn+M5PfqRLN82bZJLpU BCoLRPJDZuRiinLKCPgO5pvLGImzOobtmCHVBUbFMi9gSBaALxJPBJVXODQ1Ozcr2ZWS 0p0fktMQl5zw8+HWRA1IgzLysZRLZV1SWca+MrXkTkIuhwYgpMEb54A9POudC5XBhaFl WTXfHLaYXl1mKDo4B7JEpA3eHcA65ixOHh7dDVKKkLsMJvqkh05/f2mOirz3712IgZNh L7Y7ShUUzUso11MC9VDZI1Sb+EgYOTJ6Qjt24gSa89iU4O6bEFdvxXaxkYnpoMwXWzgE JDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iQ+9J6f6XcDzQlv+LO/vvVn5hlxK09YYotgKu0OEjog=; b=SlPsAc65DBoYuPUZDNHJRtfu+Ec6LSSvL+XFjn5WOzoSGOzm0bMhwot8Bpuwmcd5UA iTp6qK1nwmvgFUIAP+nIHeAR58vtNSUbV1TdAOHgCVm+1J4kIzWx7QEfOXJFKEvkB08T 7/i5rlu7vvui/RMSZNeyArCnHDSutSafm8e1HHYCDPpl1DMzXXNanX0o69MaDHrg9KLw gi7iEjt6AyA2RDPtFOtRqR/Rkhf4BJnIg8IPCclVrZm17st6bBCYgREqQuRooAnDNnTF kdixba3mkpg3i3uYJOYPuu5wNSs+i5niRqZYKFFfMpO25y4Xwqh1H9Hb6wdNyrW4ThXt raaA== X-Gm-Message-State: APjAAAU6Hq5S2EhnLZzLr8VDSsCfnBYG9cXbVCpu6UFjxl7eXOTJffAJ MX1l9TA/N24L2uYKdrduLA0qI7fQdqwSYkkmUmPMK3eWgG378Yg6 X-Google-Smtp-Source: APXvYqw/QltyMLR0nGy9ECtiSAYMp0fqfjZkJOUzk7sShwqbFFz2gQ6yMNrqkkFqzt/Wn6CtHeHJsFmemZ08nOMVfTE= X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr6342462wmk.68.1580227955289; Tue, 28 Jan 2020 08:12:35 -0800 (PST) MIME-Version: 1.0 References: <20200128150505.45700-1-krzysztof.koch@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 28 Jan 2020 17:12:24 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables To: edk2-devel-groups-io , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Krzysztof Koch , Leif Lindholm , Michael D Kinney , Leif Lindholm , Sami Mujawar , Matteo Carlini , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 28 Jan 2020 at 17:08, Philippe Mathieu-Daud=C3=A9 wrote: > > On 1/28/20 4:05 PM, Krzysztof Koch wrote: > > Fix 'mAcpiRegistration defined but not used' compiler error for > > Dynamic Tables Framework builds. > > > > Do not declare the mAcpiRegistration variable in the Dynamic Tables > > Framework context. > > > > Commit 484a683ab9f made mAcpiRegistration variable STATIC. Reducing > > scope made scope resolution simpler, thus, the 'defined but not used' > > error got raised. > > > > Signed-off-by: Krzysztof Koch > > --- > > > > Changes can be seen at: https://github.com/KrzysztofKoch1/edk2-platfor= ms/tree/723_fix_unused_variable_juno_dxe_v2 > > > > Notes: > > v2: > > - Specify which previous commit inroduced the error [Philippe] > > Thanks for the update. > Since the change is minor, you could have kept my R-b tag. > Anyway: > Reviewed-by: Philippe Mathieu-Daude > Thanks guys Pushed as b40c36980ac9..53f658aa61f8 > > > > v1: > > - Fix 'defined but not used' Dynamic Tables build error [Krzyszto= f] > > > > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Pl= atform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > > index e3b64992e02c003f7e3a6636340a6afa573f477a..cd7a205f90f131560419cf= d744dd5c22df726c99 100644 > > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > > @@ -1,6 +1,6 @@ > > /** @file > > * > > -* Copyright (c) 2013-2019, ARM Limited. All rights reserved. > > +* Copyright (c) 2013-2020, ARM Limited. All rights reserved. > > * > > * SPDX-License-Identifier: BSD-2-Clause-Patent > > * > > @@ -30,9 +30,9 @@ > > #ifndef DYNAMIC_TABLES_FRAMEWORK > > // This GUID must match the FILE_GUID in ArmPlatformPkg/ArmJunoPkg/A= cpiTables/AcpiTables.inf > > STATIC CONST EFI_GUID mJunoAcpiTableFile =3D { 0xa1dd808e, 0x1e95, 0= x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } }; > > -#endif > > - > > STATIC VOID *mAcpiRegistration =3D NULL; > > +#endif > > + > > STATIC VOID *mPciIoNotificationRegistration =3D NULL; > > > > /** > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > > > > > > > > >=20 >