Re: [PATCH 2/2] BaseTools/tools_def AARCH64: avoid SIMD register in XIP code

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 13 July 2017 at 17:56, Alexei Fedorov <Alexei.Fedorov@arm.com> wrote:
> I'm getting
>
>
> UEFI firmware (version  built at 16:34:57 on Jul 13 2017)
> Synchronous Exception at 0x00000000F5451338
> :
>
> EL2:0x00000000F5451338 : LDR      q0,[x9,x0]
> EL2:0x00000000F545133C : ADD      x1,x1,#1
> EL2:0x00000000F5451340 : CMP      x7,x1
> EL2:0x00000000F5451344 : STR      q0,[x2,x0]
> EL2:0x00000000F5451348 : ADD      x0,x0,#0x10
> EL2:0x00000000F545134C : B.HI     {pc}-0x14 ; 0xf5451338
> ...
>
> with X0=0 & X9 = 0x000000000BFD0008 (Flash memory) in AlignedCopyMem()
> function
>
> (edk2\ArmPlatformPkg\Drivers\NorFlashDxe\NorFlashDxe.c):
>
>
> // r:\edk2\ArmPlatformPkg\Drivers\NorFlashDxe\NorFlashDxe.c:784:
> *Destination64++ = *Source64++;
>     .loc 10 784 0
>     ldr    q0, [x9, x0]    // MEM[base: vectp.229_593, index:
> ivtmp.349_1117, offset: 0B], MEM[base: vectp.229_593, index: ivtmp.349_1117,
> offset: 0B]
>     add    x1, x1, 1    // ivtmp_603, ivtmp_603,
>     cmp    x7, x1    // bnd.223, ivtmp_603
>     str    q0, [x2, x0]    // MEM[base: vectp.229_593, index:
> ivtmp.349_1117, offset: 0B], MEM[base: vectp_Buffer.232_598, index:
> ivtmp.349_1117, offset: 0B]
>     add    x0, x0, 16    // ivtmp.349, ivtmp.349,
>     bhi    .L200    //,
>
>
> Despite compiler option -mgeneral-regs-only:
>
> // -mfix-cortex-a53-835769 -mfix-cortex-a53-843419 -mgeneral-regs-only
> // -mlittle-endian -mpc-relative-literal-loads -mstrict-align
> (see attached assembly generated file)
>

That is the same compiler bug at work, I think. So we need to add
-mgeneral-regs-only for this module as well.

Perhaps we should simply set it globally? Leif?