From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif@nuviainc.com>
Cc: "Jiang, Guomin" <guomin.jiang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"pankaj.bansal@nxp.com" <pankaj.bansal@nxp.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support
Date: Mon, 30 Mar 2020 09:44:56 +0200 [thread overview]
Message-ID: <CAKv+Gu8qOxjAZQD4Dv_kX+aixhU4PmUM3tu2ptQNWDzT7C8F2Q@mail.gmail.com> (raw)
In-Reply-To: <20200330073518.GU22097@bivouac.eciton.net>
On Mon, 30 Mar 2020 at 09:35, Leif Lindholm <leif@nuviainc.com> wrote:
>
> Hi Jiang,
>
> It is not a question of effort of copying a driver, it is a question
> that copying drivers is something that should be avoided wherever
> practically possible. I did not think this topic was still under
> debate.
>
> If the existing 16550 SerialPortLib is overspecialised to the point
> where it only works on a subset of 16550 implementations, then it
> should change. There are going to be more non-PC systems turning up
> with 16550 UARTs - should they each copy/modify their drivers?
>
> If there are better ways of solving that problem, please suggest.
> But more duplicated drivers is not the answer.
>
Could we use a GUIDed HOB? If it exists, we use its contents, and if
it doesn't, we use the default set by the FixedPCD.
next prev parent reply other threads:[~2020-03-30 7:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 13:31 [PATCH 0/1] UART Dynamic clock freq Support Pankaj Bansal
2020-02-19 13:31 ` [PATCH 1/1] MdeModulePkg: " Pankaj Bansal
2020-03-19 13:40 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-03-19 15:09 ` Ni, Ray
2020-03-19 15:30 ` Leif Lindholm
2020-03-23 5:31 ` Pankaj Bansal
2020-03-26 14:13 ` [edk2-devel] " Guomin Jiang
2020-03-28 12:36 ` Pankaj Bansal
2020-03-30 1:20 ` Guomin Jiang
2020-03-30 7:35 ` Leif Lindholm
2020-03-30 7:44 ` Ard Biesheuvel [this message]
2020-03-31 1:53 ` Ni, Ray
2020-03-31 9:22 ` [edk2-devel] API breakages and their implications. Was: " Leif Lindholm
2020-03-31 12:11 ` Ni, Ray
2020-03-31 12:59 ` Leif Lindholm
2020-03-31 13:23 ` Laszlo Ersek
2020-04-01 12:55 ` Leif Lindholm
2020-04-11 11:54 ` [edk2-devel] " Pankaj Bansal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8qOxjAZQD4Dv_kX+aixhU4PmUM3tu2ptQNWDzT7C8F2Q@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox