From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.45358.1585554309409999864 for ; Mon, 30 Mar 2020 00:45:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=K11kUxro; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id w10so20379239wrm.4 for ; Mon, 30 Mar 2020 00:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7jWn+MkVaG3hqnJlnW9wnNeQlsdek72tHkGVr3uGZtM=; b=K11kUxrojX3EMk68RUYa55TKzB/fDk+oBb+JOVS9kbGd7Rlo4loAbhSXiXbRgbhEAH nzbx01ios3m0s9RrCasbopGYYtlQl/A2mdsOef2Em0z245Gl4QBbbVVNFaYlLRIGSFyD 06GdrQHilBnz9V8K+PUpyspAmEF7kQMtvwFz7Y9E63HAwoqZsvEsfrCg9Ww6UrAFJuYY hKaG8nZRNRTW9Kw4BJZqGNCYxSuP9Bic0AHK+HWKFjzAT3osbTwIsTqmHC/m8oFoGXAj 9nm6emHil6W5Ix/WYM71GgJqxxu+if4m4iiuA+lggKUhCFdkii1iBwvDOIYyr0X+D2IR yEpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7jWn+MkVaG3hqnJlnW9wnNeQlsdek72tHkGVr3uGZtM=; b=kSUecbJrt5DWAb+7H2zVU8jrZZ9ww2R2PzXIehL1kSYwFV4kM7n7QgxTJUSJ5mXcWC SiSzCdeIelVEgJEZcxNnDWgx9KsRsE6eYQVH8rsm+o0VpTTDNAlGnqN3q0Le03Q9fEh7 9NGO9rVAoA6ktJKT+JMlGgz4muU4rrImP2hfBkDNvLCxNi2PBV5lUaAN8ZOOKo4TFrv2 lkh7wIGNOXBkqciv/92nYG9YlSNS72lvz5uC9Ey9CoEwVJlOj/mkaWgm9sdK1Rtr9wZc k5RE6+epDw+GJch1lyrX6DYq6luQbgiioibK3H4lLnwTcn50rOdrWJvagiVDbvN0Ke7R OBqg== X-Gm-Message-State: ANhLgQ14MNFU0COOh94um0uJQ09b8pI8/nJv1NWmOYWclXCU61TxKPhg VaRN3cctOoK12hbb81Uk0scrtsRMilrVMbieove7YQ== X-Google-Smtp-Source: ADFU+vuUbiEKLBpzQWL1UU8mvF9WAd+Y3DyT12uODWhq9I3GfUcGODaWO22G8R7m3FGPMFO4vQn6cwLEmzvisvqn43E= X-Received: by 2002:adf:afdb:: with SMTP id y27mr13621090wrd.208.1585554307968; Mon, 30 Mar 2020 00:45:07 -0700 (PDT) MIME-Version: 1.0 References: <20200219133135.10407-1-pankaj.bansal@oss.nxp.com> <20200219133135.10407-2-pankaj.bansal@oss.nxp.com> <734D49CCEBEEF84792F5B80ED585239D5C4A0C2C@SHSMSX104.ccr.corp.intel.com> <20200319153057.GV23627@bivouac.eciton.net> <20200330073518.GU22097@bivouac.eciton.net> In-Reply-To: <20200330073518.GU22097@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Mon, 30 Mar 2020 09:44:56 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support To: Leif Lindholm Cc: "Jiang, Guomin" , "devel@edk2.groups.io" , "pankaj.bansal@nxp.com" , "Ni, Ray" , "Wang, Jian J" , "Wu, Hao A" , "Ma, Maurice" , "Dong, Guo" , "You, Benjamin" , Meenakshi Aggarwal , Varun Sethi , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" On Mon, 30 Mar 2020 at 09:35, Leif Lindholm wrote: > > Hi Jiang, > > It is not a question of effort of copying a driver, it is a question > that copying drivers is something that should be avoided wherever > practically possible. I did not think this topic was still under > debate. > > If the existing 16550 SerialPortLib is overspecialised to the point > where it only works on a subset of 16550 implementations, then it > should change. There are going to be more non-PC systems turning up > with 16550 UARTs - should they each copy/modify their drivers? > > If there are better ways of solving that problem, please suggest. > But more duplicated drivers is not the answer. > Could we use a GUIDed HOB? If it exists, we use its contents, and if it doesn't, we use the default set by the FixedPCD.