From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1ED42119EF32 for ; Tue, 18 Dec 2018 05:05:34 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id b5so4134159iti.2 for ; Tue, 18 Dec 2018 05:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z25BaCKsTopi/GYnDCH+pLw6huE9vDpS27WT/S3+hs0=; b=jKUwScMPkGz6OXCQAK1BQNlUpnMUgp8I1BbTfbhFM4qWYeeyy+l9XQRdHKqLl90aaL Mr8ynskknsFyRbsDBjuIsKTtCXMXGy/qaBqZVe2hISekwc1ITtfaGGcPpnr2zlPPSq7i grVkFlypVIa9q4POvZYh/wizqsTBAfAvcjSK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z25BaCKsTopi/GYnDCH+pLw6huE9vDpS27WT/S3+hs0=; b=qi1d/qkTfdo0tRWstkwbn4PHzBazwPxiy2Tl4Tb5T+XXxrYD0kmLrnwtfYeigLgkeo 2S7yhNfy1HzfhJKCk32jwRmPxbaRsZhvCKWcQ4wCJf1F1t6fg8R27n+TA+zXZfeyI9QU Lk+mguaXRaEMGqGU81MSzvT/pXTJpj8zusWRHnvaiBRuc9xOP8sA8jybhv44aM6xBzNm HL8jB+Zn3qfk7O6EoX1QoczWP5jjRFNaV94GpA3BFZTD6Cta8sM5NnWf/erONNfyWNNz vFVRJTccuWb/jeLwmIbpJiyK+LOR3nEeluSDno6e2zLEk0oX5WjLCKJY0dg58+PE6xnQ RWRg== X-Gm-Message-State: AA+aEWbKjQE5NfhN9GlFTzYGRvGeWIEYZ5+pp6H8OTPht4VsuzRW/TAK CI13DtBnulyPFBIKSN4dDmQZ5p43tiWaHV0QELppPA== X-Google-Smtp-Source: AFSGD/WvSntAnV4c0HCaaqmnAsUQFS8zjvcfQ2CPCtQ0znsgZdy7/6uUtw6gX7j2dqoRKwDyxi+M02/XNK7vtHG4J6k= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr2848369itk.71.1545138333308; Tue, 18 Dec 2018 05:05:33 -0800 (PST) MIME-Version: 1.0 References: <1545134943-16346-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 18 Dec 2018 14:05:21 +0100 Message-ID: To: Sumit Garg Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Leif Lindholm Subject: Re: [PATCH edk2-non-osi 1/1] Platform/Socionext: update ARM-TF binary to include OP-TEE X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 13:05:34 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 18 Dec 2018 at 14:04, Sumit Garg wrote: > > On Tue, 18 Dec 2018 at 18:30, Ard Biesheuvel wrote: > > > > On Tue, 18 Dec 2018 at 13:58, Sumit Garg wrote: > > > > > > On Tue, 18 Dec 2018 at 18:16, Ard Biesheuvel wrote: > > > > > > > > On Tue, 18 Dec 2018 at 13:09, Sumit Garg wrote: > > > > > > > > > > Include a prebuilt binary of OP-TEE OS built from commit > > > > > a5d528c7e54fd7726230483bd4cd5c4786d7703f. > > > > > (https://github.com/OP-TEE/optee_os.git master) > > > > > > > > > > Also update ARM-TF RELEASE build to commit 47577cbaaf4b. > > > > > > > > > > Cc: Ard Biesheuvel > > > > > Cc: Leif Lindholm > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Sumit Garg > > > > > --- > > > > > Platform/Socionext/DeveloperBox/fip_all_arm_tf.bin | Bin 46824 -> 415251 bytes > > > > > > > > Thanks Sumit! > > > > > > > > In the future, please use --no-binary when sending patches like this one. > > > > > > > > > > Sure will take care of this in future. > > > > > > > However, do you have any explanation why the size increases 10x? This > > > > patch adds the pseudo-TA, but OP-TEE was already included in the > > > > previous build, so this is a bit unexpected. > > > > > > > > > > Actually I think ARM-TF was not updated earlier to include OP-TEE in > > > upstream (tee.bin size: 316392 bytes). > > > > > > > Ah, right. So we added the OP-TEE aware ATF build but not OP-TEE > > itself? That would indeed explain it. > > We didn't updated ATF build at all in upstream. I think you have > updated ATF build in local repo [1] only. > > [1] git://git.linaro.org/leg/noupstream/edk2-non-osi.git > Indeed.