From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0C031211D6161 for ; Thu, 7 Mar 2019 02:09:46 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id w18so14348502itj.4 for ; Thu, 07 Mar 2019 02:09:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z0X4rwzOQOyXjkdv2taPYr3qM2mVVvH/LoFdPbEOBk0=; b=nkOoeOdFbM2SKUd1hnAiW1p/kM0m9wNQ/ijvDtXBpA0wQAuBqaje8FpleYa3IAgDxU 0J8FIBqnik95j4JP3mHitu0xMW7oIzu/MxOVM5QlmgEsAgHLGsYS1zKxethcOWCOy18M 3wa0Gh+fwecIDw184/TAEKcfObf5C21RKUAtfGjboYWukdWK58lRosp2pbfm+qdpyEqA /fuQYmCzI7yEsSsY3f5ffpbD0cE1KLOzMupCWQxYz1T4PvNJnRSaEYczAhlhK+LnzxyY 9eri9QUP6vj72D120SG3GIppjzOViHNaExzDs8iTqTOBMUW7Uklpw3TxDvE4iSngK2Oh lSFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z0X4rwzOQOyXjkdv2taPYr3qM2mVVvH/LoFdPbEOBk0=; b=nxei6nizmMgBsHIG3SREvT7ydiadzNaX4Hxp9jAwqksXjkq4uX7UJgpC8FJ5/tqz2B Zo0N5d/AE+X/sLD7CF2moKrRqo7d7OyTPUO5N+QdgIa9EqgJa6ut0TP3i9JtPUMdgbzH zFu7TabAya/9z68XlBfIFjuZRNEbZSZT4oHJCEibHVCJAz2cN2RS/XzC60H0eauzFmns tWL548vfuHuI+eB/7WPGqR3rI8G/wNBJ1yPs1zrjDImLYynpS8QesqLAkBlG1cSCYFQb bUzVX0/cdp+F4NLZr/wqKTS8OmNf+w7GIZD4aAiyZtgmP3AbltuNuKeNBqpaRB8cqbFs ifvw== X-Gm-Message-State: APjAAAWwqfnug4C+ACHEdkr59GGGASN78TBb28NrbMc4HtAu3NduuV5c Po4zNjsjGHB4bSM6uaXxF4OLcBQaMbIVF8hGaBlA5Q== X-Google-Smtp-Source: APXvYqxW0xflNyzMa3IC/NnXAF6SeesHHnbTLQR5Ofd1MHtSSOorUexrRXqGAkM7rnvo4dFPRdup5HVLwWE7uMmkglA= X-Received: by 2002:a24:1947:: with SMTP id b68mr4205602itb.121.1551953386034; Thu, 07 Mar 2019 02:09:46 -0800 (PST) MIME-Version: 1.0 References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-3-ard.biesheuvel@linaro.org> <20190306151639.GN21602@mac-ubuntu-vm> <20190306153700.GO21602@mac-ubuntu-vm> In-Reply-To: <20190306153700.GO21602@mac-ubuntu-vm> From: Ard Biesheuvel Date: Thu, 7 Mar 2019 11:09:35 +0100 Message-ID: To: Achin Gupta Cc: "edk2-devel@lists.01.org" , Supreeth Venkatesh , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja , nd Subject: Re: [PATCH 02/10] StandaloneMmPkg: drop unused PCD PcdStandaloneMmEnable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 10:09:47 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 6 Mar 2019 at 16:37, Achin Gupta wrote: > > On Wed, Mar 06, 2019 at 04:17:51PM +0100, Ard Biesheuvel wrote: > > On Wed, 6 Mar 2019 at 16:16, Achin Gupta wrote: > > > > > > Hi Ard, > > > > > > On Tue, Mar 05, 2019 at 02:32:40PM +0100, Ard Biesheuvel wrote: > > > > The PCD PcdStandaloneMmEnable is unused, and shouldn't exist in the > > > > first place since the value is implied by the context (it is never > > > > valid to set it to FALSE for standalone MM or TRUE for traditional > > > > MM). So drop it. > > > > > > This is being used to determine if the ArmVExpressPkg should include support for > > > StMM comm. buffer or not [1] but it does look redundant now. > > > > > > > If that is the case, the PCD should be defined in that package. > > The Arm FVP port for StMM needs a rewrite on the lines of other platforms. This > change is fine. > Yes, you are right. SynQuacer also needs some tweaks to align with these changes, but I will post those separately. So with those changes merged, the only thing preventing us from building the SynQuacer + MM platform from upstream sources is the MmCommunicate VA vs PA issue. Is there any progress on that front? Thanks, Ard.