From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9716A21DF806C for ; Tue, 29 Aug 2017 08:44:52 -0700 (PDT) Received: by mail-io0-x22a.google.com with SMTP id n71so22054081iod.1 for ; Tue, 29 Aug 2017 08:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=182BLHrEeZNXIUh5i15hl3BHduRR3vUuLsJYmxY4Png=; b=eRzYOLmhJQ3IQxxujrha8VVbIj7OSXMSiDR9uicvY9X+iYnk3aKSp8GJEQEjSkkPHO 6izTIo5OSn/+DOichDQiH6gdK3+7D0r966kVxcPdCgZ3cO0HRuMAyv8kypLG6Pw08rtk 1KCU5kBFpK53IDvHkDhKRhAf5uSUqFW02SQSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=182BLHrEeZNXIUh5i15hl3BHduRR3vUuLsJYmxY4Png=; b=rWMV5YTT13oo44JHUFuZBE/knqDxgsa4DIpHMupruK9wbYFf0AS/XEP0oKb3GnPhgs M6Lh1+OifMFUqz7ov9ZWEq5h39yZDPRXsfY4dHT2PTM0PJl7+l8nV8ssn6IDgOQVuiZp 6vTdIXBOU1/DPqvxeL1KcqcG9ayzuAEzn5+ITD/Qbm7XaTMe4SecMW1VzS71fx+nsNkW S0Gpsg6Tfrwq5dedRstp7efJCJMzDb4q1K4vOpXzzlolY5eqcGIOQ0Y3NTUYmuFNgcG6 4P20c2eHLPfDRy0/q5JeKXaYNnGto8eVx4ikqWHCmx5wMy5YdZVTrIt9r2es/8A2RFJu Rzhg== X-Gm-Message-State: AHYfb5g2PSVug0nOnKh7XB7bFpIBrlt0zoCsSNLaxu3yOqzozF3k2gCC iRW6v0zoi1FPTSVrzu32MX6Zrn9DqqwgkCA= X-Received: by 10.107.157.78 with SMTP id g75mr4405773ioe.190.1504021652542; Tue, 29 Aug 2017 08:47:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 08:47:32 -0700 (PDT) In-Reply-To: <20170829154446.d32yijnzbzlhw6b5@bivouac.eciton.net> References: <20170825121014.15739-1-ard.biesheuvel@linaro.org> <20170829154446.d32yijnzbzlhw6b5@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 29 Aug 2017 16:47:32 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 0/5] ArmPkg et al: remove UncachedMemoryallocationLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 15:44:52 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 16:44, Leif Lindholm wrote: > On Fri, Aug 25, 2017 at 01:10:09PM +0100, Ard Biesheuvel wrote: >> This series is a followup to 'ArmPkg/ArmDmaLib: remove dependency on >> UncachedMemoryAllocationLib' sent out yesterday, and removes library >> entirely. >> >> There are two reasons for this: >> - UncachedMemoryAllocationLib is often abused by drivers that should >> be using DMA abstractions instead. It is up to the platform to decide >> whether DMA is cache coherent or not, and the fact that non-cache >> coherent DMA may be implemented using uncached allocations should remain >> an implementation detail of the DmaLib instance. >> >> - The code is poorly maintained, only frees its allocations in the destructor, >> and misleads by exposing pool allocate/free entry points that are actually >> backed by page based allocations. >> >> Patches #1 and #2 add a DmaAllocateAlignedBuffer() to DmaLib and both >> its implementations. This is required for current users of >> UncachedMemoryAllocationLib that rely on minimum alignment to be able >> to switch the DmaLib. >> >> Patches #3 and #4 remove a couple of stale references. >> >> Patch #5 actually removes the library and its single remaining implementation. > > For the series: > Reviewed-by: Leif Lindholm > > However, this breaks a bunch of (edk2-)platforms: juno, fvp, tc2, > hikey and armada70x0. Is there a follow-on patch coming for those, > and could you hold off on pushing this series until that is ready? > > Armada has the only non-bogus UncachedMemoryAllocationLib dependency, > the others are just trivial deletions. > Yes. There are interdependencies between repos, so I will just merge #1 and #2 and hold off with the rest until after all dependencies have been removed.