Re: [PATCH 13/19] ArmVirtPkg/ArmVirtPlatformLib: eliminate unchecked PcdSetXX() calls

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 21 October 2016 at 22:27, Laszlo Ersek <lersek@redhat.com> wrote:
> These are deprecated / disabled under the
> DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.
>
> Introduce a variable called PcdStatus, and use it to assert the success of
> these operations (there is no reason for them to fail here).
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c b/ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c
> index 7a0fc0e75e37..fcaf3c681a97 100644
> --- a/ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c
> +++ b/ArmVirtPkg/Library/ArmVirtPlatformLib/Virt.c
> @@ -70,13 +70,14 @@ ArmPlatformInitializeSystemMemory (
>    VOID
>    )
>  {
> -  VOID         *DeviceTreeBase;
> -  INT32        Node, Prev;
> -  UINT64       NewBase, CurBase;
> -  UINT64       NewSize, CurSize;
> -  CONST CHAR8  *Type;
> -  INT32        Len;
> -  CONST UINT64 *RegProp;
> +  VOID          *DeviceTreeBase;
> +  INT32         Node, Prev;
> +  UINT64        NewBase, CurBase;
> +  UINT64        NewSize, CurSize;
> +  CONST CHAR8   *Type;
> +  INT32         Len;
> +  CONST UINT64  *RegProp;
> +  RETURN_STATUS PcdStatus;
>
>    NewBase = 0;
>    NewSize = 0;
> @@ -131,7 +132,8 @@ ArmPlatformInitializeSystemMemory (
>    // Make sure the start of DRAM matches our expectation
>    //
>    ASSERT (FixedPcdGet64 (PcdSystemMemoryBase) == NewBase);
> -  PcdSet64 (PcdSystemMemorySize, NewSize);
> +  PcdStatus = PcdSet64S (PcdSystemMemorySize, NewSize);
> +  ASSERT_RETURN_ERROR (PcdStatus);
>
>    //
>    // We need to make sure that the machine we are running on has at least
> --
> 2.9.2
>
>