From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9D6C222152384 for ; Mon, 4 Dec 2017 06:50:53 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id z6so13347691iti.4 for ; Mon, 04 Dec 2017 06:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=503SH91n6M9p1POcO/B9UH9uJlybt9viZS/DHbKfve8=; b=AQxWswM96xjbC/dS16hIvBw9zDwfDV4q4ePOVzTcswfCy+bTxHSUjDgFPxX5N7TJH/ liK6eTZgWCDicyWiYlJsoETgI/LldsN88Q8nhIFsyIq+6T3x4ET7mzCm0xuIYvAKjlEm U486KiG5dTsqT1fz9EhC2mXXjJhOpkd+nkvdE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=503SH91n6M9p1POcO/B9UH9uJlybt9viZS/DHbKfve8=; b=JvoJd1qyI9/SMnklzCBDRFHar/I218P3okQfbdGofeC6fSrgR60ywHE+2HRBHlg2QR By+OxBkSeMSyjPyLnN6BZI51HjdctlhEwI47+DP/zI6LuilcVefZXrKHawJ1LMpTUsRt 6r07pBxhdwLZUiiR/WiGrP2wwWWandc6MyT/OR/Ch+dB7pKWLVHwVu1x1cLvd3fIhiml 4IoLD730xi/l38+w7EbSDQ3xk0IOshdRRX7aIy2BaKTiV+ghiUxTN4wIECJIpq1B2PMP sKXj8PK27fkzsc6Nd6I6VIhkYvCjGsZa1qaCmK8k0IbJ9RD1QyfrahuM1e/DN5TgJRnC 4WDw== X-Gm-Message-State: AKGB3mKFaixp2knSzCF89CA+C++6RactgiUyldjC8rrsZVNP6RqX7Il4 sOlJqJhiXbjCohHsFMVuTybCu85klzSYzdG1++CpDg== X-Google-Smtp-Source: AGs4zMbHf0U/YxG25pzU5Ta3U2d1sEcKAkjlJ7xubB3Ju6RiySDs3QNkfvz4n0IxwRWyqbMEWnsZEp3jNRHWHgWiXg0= X-Received: by 10.36.55.138 with SMTP id r132mr4847543itr.34.1512399322670; Mon, 04 Dec 2017 06:55:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 4 Dec 2017 06:55:22 -0800 (PST) In-Reply-To: <20171204144834.sefvh4afhblzxw5s@bivouac.eciton.net> References: <20171204133308.32012-1-ard.biesheuvel@linaro.org> <20171204144834.sefvh4afhblzxw5s@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 4 Dec 2017 14:55:22 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Masami Hiramatsu , Masahisa Kojima , Daniel Thompson Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacerI2CDxe: add missing __FUNCTION__ argument to %a specifier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 14:50:53 -0000 Content-Type: text/plain; charset="UTF-8" On 4 December 2017 at 14:48, Leif Lindholm wrote: > On Mon, Dec 04, 2017 at 01:33:08PM +0000, Ard Biesheuvel wrote: >> The I2C driver prints a warning under DEBUG when a I2C transaction times >> out. This will occur on the rev 0.1 DeveloperBox boards due to a board >> level error in the I2C routing (unless the MCU has been lifted off the >> bus). >> >> Currently, this will trigger a crash due to a missing __FUNCTION__ >> argument to a %a specifier in a DEBUG string, because instead, the code >> will attempt to dereference a EFI_STATUS variable as a char pointer. >> >> So add the missing __FUNCTION__ argument. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks. Pushed as 7511d626b318ae068d7773159eedf3c9fc4c7a5a >> --- >> Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c >> index fb404b17f93c..c3703dfb6c33 100644 >> --- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c >> +++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c >> @@ -330,7 +330,7 @@ SynQuacerI2cStartRequest ( >> Status = WaitForInterrupt (I2c); >> if (EFI_ERROR (Status)) { >> BOOTTIME_DEBUG ((DEBUG_WARN, "%a: Timeout waiting for interrupt - %r\n", >> - Status)); >> + __FUNCTION__, Status)); >> break; >> } >> >> -- >> 2.11.0 >>