* [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc
@ 2017-11-30 10:21 Leif Lindholm
2017-11-30 10:22 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-11-30 10:21 UTC (permalink / raw)
To: edk2-devel; +Cc: ard.biesheuvel
For whatever reason, EmbeddedPkg.dsc included a FLASH_DEFINITION entry
pointing to a nonexistent EmbeddedPkg.fdf.
This used to be silently ignored, but recent BaseTools changes
5e9256cd7f54 ("BaseTools: Guid.xref contain information from FILE statements in FDF")
now caused builds against EmbeddedPkg.dsc to fail.
So delete the redundant entry.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
EmbeddedPkg/EmbeddedPkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
index 9ec24f7fa8..073a156884 100644
--- a/EmbeddedPkg/EmbeddedPkg.dsc
+++ b/EmbeddedPkg/EmbeddedPkg.dsc
@@ -30,7 +30,6 @@ [Defines]
SUPPORTED_ARCHITECTURES = IA32|X64|IPF|ARM|AARCH64
BUILD_TARGETS = DEBUG|RELEASE
SKUID_IDENTIFIER = DEFAULT
- FLASH_DEFINITION = EmbeddedPkg/EmbeddedPkg.fdf
################################################################################
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc
2017-11-30 10:21 [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc Leif Lindholm
@ 2017-11-30 10:22 ` Ard Biesheuvel
2017-11-30 10:28 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-30 10:22 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 30 November 2017 at 10:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> For whatever reason, EmbeddedPkg.dsc included a FLASH_DEFINITION entry
> pointing to a nonexistent EmbeddedPkg.fdf.
>
> This used to be silently ignored, but recent BaseTools changes
> 5e9256cd7f54 ("BaseTools: Guid.xref contain information from FILE statements in FDF")
> now caused builds against EmbeddedPkg.dsc to fail.
> So delete the redundant entry.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> EmbeddedPkg/EmbeddedPkg.dsc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index 9ec24f7fa8..073a156884 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -30,7 +30,6 @@ [Defines]
> SUPPORTED_ARCHITECTURES = IA32|X64|IPF|ARM|AARCH64
> BUILD_TARGETS = DEBUG|RELEASE
> SKUID_IDENTIFIER = DEFAULT
> - FLASH_DEFINITION = EmbeddedPkg/EmbeddedPkg.fdf
>
>
> ################################################################################
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc
2017-11-30 10:22 ` Ard Biesheuvel
@ 2017-11-30 10:28 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2017-11-30 10:28 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Thu, Nov 30, 2017 at 10:22:42AM +0000, Ard Biesheuvel wrote:
> On 30 November 2017 at 10:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > For whatever reason, EmbeddedPkg.dsc included a FLASH_DEFINITION entry
> > pointing to a nonexistent EmbeddedPkg.fdf.
> >
> > This used to be silently ignored, but recent BaseTools changes
> > 5e9256cd7f54 ("BaseTools: Guid.xref contain information from FILE statements in FDF")
> > now caused builds against EmbeddedPkg.dsc to fail.
> > So delete the redundant entry.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Pushed as 97eaeaa199.
> > ---
> > EmbeddedPkg/EmbeddedPkg.dsc | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> > index 9ec24f7fa8..073a156884 100644
> > --- a/EmbeddedPkg/EmbeddedPkg.dsc
> > +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> > @@ -30,7 +30,6 @@ [Defines]
> > SUPPORTED_ARCHITECTURES = IA32|X64|IPF|ARM|AARCH64
> > BUILD_TARGETS = DEBUG|RELEASE
> > SKUID_IDENTIFIER = DEFAULT
> > - FLASH_DEFINITION = EmbeddedPkg/EmbeddedPkg.fdf
> >
> >
> > ################################################################################
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-30 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 10:21 [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc Leif Lindholm
2017-11-30 10:22 ` Ard Biesheuvel
2017-11-30 10:28 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox