From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1FF8921A1099A for ; Thu, 30 Nov 2017 02:18:19 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id h12so6992169iof.6 for ; Thu, 30 Nov 2017 02:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=D7CuHq/XUyE7Pm28wY4uOf33HTlEzsh1PagANMsNJkU=; b=Az348kwFnhhtQRkcGxY+5i0izHz6wa7adGqBafv+Q95vhHBt3PQC8pf3HZDM5kn5iU dYPoYHq26ZC+MYs8g2q9I5zZ6XTDMgHwQXCbWePsPixCzAN4hP+HeVQ6PUp2MXe39i8K TIivMbLwnUhOKQdQ0GuhfRKkdm568cX2GZT6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=D7CuHq/XUyE7Pm28wY4uOf33HTlEzsh1PagANMsNJkU=; b=uE/CKsp/Ghf5imYBOeVhrR3cmYryDHAE14ETG2IgNo+hL6EU5hE/BaZ1rZo1qQ+4b4 jTuQVhaRdNEQbsX63IrXtZAHcjzKPMcxpykC5uPCRoGmFaiubSr5bEX0DfjqBEgWttsr 8jQqAA3Lq+aYrB3uT8881ryRwx9ktAEC6TElbXr1wllUSfq22sgiBdS4HylcBrKCrRK3 P8LO4GEgbsufZMI8BWVXPa+t+eFK+vBjCcL0aToEN3a1O+xzOclwQFO5j6k8T+QMalv9 pgiYa8hIK+KALrN4pPHdjmIA1mMjJf8EMG1qgvEzokJ3vQ1jna7c4d7FMoKOEk9MJxok e8sQ== X-Gm-Message-State: AJaThX6vTR6v1NeuvpQatFIWtSf5XBMBRQTOcrgTRZ1yqMIerUJdL/ln viB8jf6nYWvmG6yJ86q0+5wKu422bhW1h2wkTxC8AQ== X-Google-Smtp-Source: AGs4zMZTg/Ye/YNz5hFxtgiJTSf1x9SneymEDaBEdVNikrvy/pIZFD3tc8onx6Kf0uy9awYGYurc474A/RXF6377Ea4= X-Received: by 10.107.151.142 with SMTP id z136mr7307648iod.248.1512037363410; Thu, 30 Nov 2017 02:22:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Thu, 30 Nov 2017 02:22:42 -0800 (PST) In-Reply-To: <20171130102135.2343-1-leif.lindholm@linaro.org> References: <20171130102135.2343-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 30 Nov 2017 10:22:42 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] EmbeddedPkg: remove nonexistent FLASH_DEFINITION from package .dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 10:18:19 -0000 Content-Type: text/plain; charset="UTF-8" On 30 November 2017 at 10:21, Leif Lindholm wrote: > For whatever reason, EmbeddedPkg.dsc included a FLASH_DEFINITION entry > pointing to a nonexistent EmbeddedPkg.fdf. > > This used to be silently ignored, but recent BaseTools changes > 5e9256cd7f54 ("BaseTools: Guid.xref contain information from FILE statements in FDF") > now caused builds against EmbeddedPkg.dsc to fail. > So delete the redundant entry. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > EmbeddedPkg/EmbeddedPkg.dsc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc > index 9ec24f7fa8..073a156884 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dsc > +++ b/EmbeddedPkg/EmbeddedPkg.dsc > @@ -30,7 +30,6 @@ [Defines] > SUPPORTED_ARCHITECTURES = IA32|X64|IPF|ARM|AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > - FLASH_DEFINITION = EmbeddedPkg/EmbeddedPkg.fdf > > > ################################################################################ > -- > 2.11.0 >