From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B57C081E88 for ; Wed, 23 Nov 2016 02:09:19 -0800 (PST) Received: by mail-io0-x22d.google.com with SMTP id c21so15324924ioj.1 for ; Wed, 23 Nov 2016 02:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Bz7Qhqm4cP9ETxMis3R0AKg4d6yg1byEuSX/LeobrFo=; b=iNDcONiQ6iDy/y7aUCN2zpoHwgsK4v2eQPb0ppBe7U8XOpLXTRWCDAZfTHQYkGhXho jGdjHgtOWrLnxhNSW66kJVjdn9H0StlzMLT+XDmX9UStL4H21HkVzy+mZZXMJK27lQ5i PkJzIjhtwVfTJMtxj8rjDKYqYt8Cqm6gPgMqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Bz7Qhqm4cP9ETxMis3R0AKg4d6yg1byEuSX/LeobrFo=; b=YQUXoGwSFH5BU9om8M1St9p2W7c9K/adJW/kniIkraEGLst3cCKqaO6nEHjMgUSa8i pCwID2AtmdncpTUpPk4BLte+J1TrV2kqyRAFxvksS3WRm+ptZtg9w5cciI1/moAyVN9/ WiffELapKvtKr5xxh5gWzokaux19+zwH03ihhYSzCqAbx7zhdMsE5e+wixjr/5kyCZs0 NU0h1Rqn6liN+QvzboWQWY7vuu4LfZ5KUu2LhsMfQYT5RF20bfM4sSV5sabaHMG/aJT+ PaWLQHJcITrboAzGgYWdC6fdEU5yas1MFDQ9UpTKkHaUlwFVCgbEFmpMz8dAMRKgoLml IVXA== X-Gm-Message-State: AKaTC03y8aAv3MB8xoOBY48zOMUq7HEGO+AGeMJ7b69u/u1iH/wowtuz4d5A2B/A95FNBQElRAUTdHdK1tjzSMCm X-Received: by 10.107.25.204 with SMTP id 195mr2223543ioz.138.1479895758692; Wed, 23 Nov 2016 02:09:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Wed, 23 Nov 2016 02:09:18 -0800 (PST) In-Reply-To: <1479105446-23480-2-git-send-email-liming.gao@intel.com> References: <1479105446-23480-1-git-send-email-liming.gao@intel.com> <1479105446-23480-2-git-send-email-liming.gao@intel.com> From: Ard Biesheuvel Date: Wed, 23 Nov 2016 10:09:18 +0000 Message-ID: To: Liming Gao Cc: edk2-devel-01 Subject: Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 10:09:19 -0000 Content-Type: text/plain; charset=UTF-8 On 14 November 2016 at 06:37, Liming Gao wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=227 > > After -P option is removed, the generated preprocessed ASL file will have > line markers. The extra information can be removed by Trim script. ASL code > can refer to the definition in C source file. This has been supported in > VS and XCODE tool chains. > > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > BaseTools/Conf/tools_def.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > This patch is breaking the build on some AArch64 platforms: Intel ACPI Component Architecture Error 6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting PARSEOP_DEFINITION_BLOCK and premature End-Of-File ASL+ Optimizing Compiler version 20160831-64 and the DSDT.iiii source file has these lines at the beginning """ extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) / (sizeof(BOOLEAN) == (1))]; extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) == (1))]; extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) / (sizeof(UINT8) == (1))]; extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) / (sizeof(INT16) == (2))]; extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) / (sizeof(UINT16) == (2))]; extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) / (sizeof(INT32) == (4))]; extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) / (sizeof(UINT32) == (4))]; extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) / (sizeof(INT64) == (8))]; extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) / (sizeof(UINT64) == (8))]; extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) / (sizeof(CHAR8) == (1))]; extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) / (sizeof(CHAR16) == (2))]; extern UINT8 _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))]; extern UINT8 _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))]; extern UINT8 _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))]; struct _LIST_ENTRY { LIST_ENTRY *ForwardLink; LIST_ENTRY *BackLink; }; void * __builtin_return_address (unsigned int level); extern GUID gEfiCallerIdGuid; extern CHAR8 *gEfiCallerBaseName; """ > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 39fda78..fd56ff3 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS = --redefine-sym memcpy=CopyMem > DEFINE GCC_ASM_FLAGS = -c -x assembler -imacros $(DEST_DIR_DEBUG)/AutoGen.h > DEFINE GCC_PP_FLAGS = -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h > DEFINE GCC_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h > -DEFINE GCC_ASLPP_FLAGS = -x c -E -P > +DEFINE GCC_ASLPP_FLAGS = -x c -E > DEFINE GCC_ASLCC_FLAGS = -x c > DEFINE GCC_WINDRES_FLAGS = -J rc -O coff > DEFINE GCC_IA32_RC_FLAGS = -I binary -O elf32-i386 -B i386 --rename-section .data=.hii > @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS = DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__ > *_ELFGCC_*_ASL_PATH = DEF(UNIX_IASL_BIN) > *_ELFGCC_*_ASL_FLAGS = DEF(IASL_FLAGS) > *_ELFGCC_*_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) > -*_ELFGCC_*_ASLPP_FLAGS = -x c -E -P > +*_ELFGCC_*_ASLPP_FLAGS = -x c -E > *_ELFGCC_*_ASLCC_FLAGS = -x c > *_ELFGCC_*_ASLDLINK_FLAGS = DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable > > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel