From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F3E1A81F81 for ; Thu, 9 Feb 2017 01:22:26 -0800 (PST) Received: by mail-io0-x22d.google.com with SMTP id v96so12270662ioi.0 for ; Thu, 09 Feb 2017 01:22:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JYOv52NE4E2UPaaa7xBFGXBS+D9r2YH4UZv3djtlVYQ=; b=QMsPL4iZjC6P9FLI/UJ/aDIbvHx/OBhUOGfpMhPbtINty34xKdm4HyS2f7coQ7Z9kz vtqkfX04/EcVjMDhH/yKJN+R85YLBQuokPyvIHR+u9+taYQNgybUPv5nNGBZhj8OVIf1 4aWPWHRwjbalrzRwlkmQOTWOkDiNE58ZzyETY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JYOv52NE4E2UPaaa7xBFGXBS+D9r2YH4UZv3djtlVYQ=; b=MroNagk+Lt6XUsswVUEub+qtGbzYKzu527xSO2wnIlM5O0R6Ge09lmF7Oi2KB3mhzs pRXEeVovsa4XyYQS41bRv5mZKtF1Ag5Fe0nInEe0KHxrKgnMoTQsrXwlq6hTyofjiXEn Vhk90dO1yBNLiVEh4wYlTyOlGoORuJHGcEDK8LnFdWegTlTOlvEpUusCDYKS7SF/0hDp 4YV2Tbfo2TjLaLnyHfR8wQuSDdX08SM12bj7fztJP0Exh9n8ZEeiEYrixB96xCLRTpxQ WcQw9a708zFZHsq57IA3Dbv+cy57Fa23jWoAz1xoRph4896sLFNkO3umVzw/tp/5WRp+ iiBg== X-Gm-Message-State: AMke39nb2HeLVsNmobczjVG2svH5yvYFuloMBRfh/tIm8gGyo3j9pdI+FMgCVVywgfNSUBHakYPrQ8TekBr2KSWv X-Received: by 10.107.53.17 with SMTP id c17mr2137209ioa.45.1486632146345; Thu, 09 Feb 2017 01:22:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.144.139 with HTTP; Thu, 9 Feb 2017 01:22:25 -0800 (PST) In-Reply-To: References: <1486624832-15736-1-git-send-email-jiewen.yao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A8EBD52@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Thu, 9 Feb 2017 09:22:25 +0000 Message-ID: To: "Yao, Jiewen" Cc: "edk2-devel@lists.01.org" , "Tian, Feng" , Leif Lindholm , "Kinney, Michael D" , "Fan, Jeff" , "Zeng, Star" X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH V3 0/4] DXE Memory Protection X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 09:22:27 -0000 Content-Type: text/plain; charset=UTF-8 On 9 February 2017 at 09:09, Ard Biesheuvel wrote: > On 9 February 2017 at 08:49, Ard Biesheuvel wrote: >> On 9 February 2017 at 07:43, Yao, Jiewen wrote: >>> Hi Lindholm/Ard >>> This version 3 contains both of your feedback before. >>> >>> If you can do me a favor to evaluated the impact to ARM, that will be great. >>> >> >> I will take a look right away. >> > > I am hitting the following assert as soon as ArmCpuDxe is loaded: > > Loading driver at 0x0005BE15000 EntryPoint=0x0005BE16048 ArmCpuDxe.efi > InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 5B142398 > ProtectUefiImageCommon - 0x5B142140 > - 0x000000005BE15000 - 0x0000000000010000 > InstallProtocolInterface: 26BACCB1-6F42-11D4-BCE7-0080C73C8881 5BE23008 > InstallProtocolInterface: AD651C7D-3C22-4DBF-92E8-38A7CDAE87B2 5BE230B0 > MemoryProtectionCpuArchProtocolNotify: > ProtectUefiImageCommon - 0x5EF02400 > - 0x000000005EEC4000 - 0x0000000000042000 > SetUefiImageMemoryAttributes - 0x000000005EEC4000 - 0x0000000000001000 > (0x0000000000004000) > EfiAttributeToArmAttribute: 0x4000 attributes is not supported. > ASSERT [ArmCpuDxe] > /home/ard/build/uefi-next/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c(220): 0 > > The reason appears to be that the GCD memory descriptor retrieved in > SetUefiImageMemoryAttributes() for this region has Attributes == 0 > > I am digging further ... Attached is the output of DEBUG_GCD