From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 07FEC211944CC for ; Thu, 22 Nov 2018 05:08:32 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id g85so14034737ita.3 for ; Thu, 22 Nov 2018 05:08:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q9tksXTKD/2vIZHQPS/2Zp61HQnm+RFsxU0K8Pzz2Q8=; b=gbzJgkRUjNdBp5WZM3eHweYFxC3zmDxIrsNb80Yk2tOQqWQLHRs+8ahxIh73HeZuV9 NJ9PS4Wm2KUCmHQTMTNOZFxK6tYXzqfXdvcnc/ZiZbBPusvXt+CHNJNPZpG0Gq7a/ppW Yx4H+lLm2c4hyJM6JazzH2xFlPQn4nii+U1Qo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q9tksXTKD/2vIZHQPS/2Zp61HQnm+RFsxU0K8Pzz2Q8=; b=kbfyeGg/ka/P9Sn+3yj5w4fZT8qwNtNq7OVjdDfX+ZgJqerCKvucF0l9Kn9EVM+pom R1EaFwVNnzs9i7va/EezWRGHRAannd8w0iNvGW/9ke6BC9xXUU0cNJQllVr/HWGtDLY+ 44aoPPzWJneZpw5gQEHGHeEyNULgKjO0w5Ck9I8DmLlLUis7GYrgZrFKlHib6UmmAiLY Qr0YipHphFcGki+s44nFRQEeXL6LwTLXLsnqUQ2smTjmEhHeZ0d7XqrgdnbszglhogA4 bjOb2ixWAjJ/HG/bqHrMIwPUufFpl6Vgi3d7XbocgELBg2OgK32yDoMb+z0IDezN0Kjk XBIw== X-Gm-Message-State: AGRZ1gLaW4JwjSzBzw9TleO2GxrOPNS1cEpiyYcGc2KDokPgTv+dvAgZ NAUgTpdq5rEwxFzIhRy3usnwbqJmYEXMZY8ttuCXfQ== X-Google-Smtp-Source: AFSGD/WKMf5z3IiETZ5rMfXaKlQiEryL6tXBc/jDSF2HNEuR34NDeNVtH8chhgMQyFKNLykW2Pnmh4fm92lr2b0dsIo= X-Received: by 2002:a24:710:: with SMTP id f16mr8504655itf.121.1542892111486; Thu, 22 Nov 2018 05:08:31 -0800 (PST) MIME-Version: 1.0 References: <20181121120145.3148-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Thu, 22 Nov 2018 14:08:20 +0100 Message-ID: To: Chandni Cherukuri Cc: Thomas Panakamattam Abraham , "edk2-devel@lists.01.org" , Nariman Poushin Subject: Re: [PATCH edk2-platforms 0/3] drop GUIDs from NOR flash bank descriptors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 13:08:33 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 22 Nov 2018 at 12:37, Ard Biesheuvel wrote: > > On Thu, 22 Nov 2018 at 12:19, chandni cherukuri > wrote: > > > > On Thu, Nov 22, 2018 at 1:20 PM Ard Biesheuvel > > wrote: > > > > > > On Thu, 22 Nov 2018 at 05:01, Thomas Abraham wrote: > > > > > > > > Hi Ard, > > > > > > > > On Thu, Nov 22, 2018 at 3:46 AM Ard Biesheuvel > > > > wrote: > > > > > > > > > > On Wed, 21 Nov 2018 at 14:48, Thomas Abraham wrote: > > > > > > > > > > > > Hi Ard, > > > > > > > > > > > > On Wed, Nov 21, 2018 at 5:31 PM Ard Biesheuvel > > > > > > wrote: > > > > > > > > > > > > > > Align edk2-platform with upcoming changes to EDK2 to get rid of per-bank > > > > > > > NOR flash GUIDs. > > > > > > > > > > > > > > Ard Biesheuvel (3): > > > > > > > Platform/ARM: replace hardcoded VenHW() device paths referring to NOR > > > > > > > flash > > > > > > > Silicon/SynQuacer: drop per-bank NOR flash GUIDs > > > > > > > Platform/ARM: drop per-bank NOR flash GUIDs > > > > > > > > > > > > > > Platform/ARM/JunoPkg/ArmJuno.dec | 2 +- > > > > > > > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- > > > > > > > .../JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c | 2 -- > > > > > > > .../ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c | 2 -- > > > > > > > Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +- > > > > > > > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 +- > > > > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 +- > > > > > > > .../NorFlashArmVExpressLib/NorFlashArmVExpress.c | 4 ---- > > > > > > > .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c | 14 +++++++------- > > > > > > > .../SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h | 3 +++ > > > > > > > .../NorFlashSynQuacerLib/NorFlashSynQuacer.c | 6 ------ > > > > > > > 11 files changed, 15 insertions(+), 26 deletions(-) > > > > > > > > > > > > Tested this patch series and "[PATCH v2 0/5] ArmPlatformPkg, > > > > > > ArmVirtPkg: discover NOR flash banks from DTB" patch series on the > > > > > > Juno board. With these patches applied, the boot fails on Juno board > > > > > > with the following messages. I have not yet tried to debug the issue > > > > > > but wanted to let you know this. > > > > > > > > > > > > [...] > > > > > > Loading driver at 0x000F830C000 EntryPoint=0x000F831B2AC IScsiDxe.efi > > > > > > add-symbol-file > > > > > > /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe/DEBUG/Udp4Dxe.dll > > > > > > 0xF8300000 > > > > > > Loading driver at 0x000F82FF000 EntryPoint=0x000F8306DF0 Udp4Dxe.efi > > > > > > add-symbol-file > > > > > > /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe/DEBUG/FdtPlatformDxe.dll > > > > > > 0xF82EE000 > > > > > > Loading driver at 0x000F82ED000 EntryPoint=0x000F82F76EC FdtPlatformDxe.efi > > > > > > Found image: fip in block 5. > > > > > > Found image: norkern in block 20. > > > > > > Found image: ramdisk.img in block 116. > > > > > > Found image: hdlcdclk in block 151. > > > > > > Found image: selftest in block 152. > > > > > > Found image: board.dtb in block 156. > > > > > > Found image: scp_bl1 in block 249. > > > > > > Found image: bl1 in block 251. > > > > > > Found image: startup.nsh in block 252. > > > > > > ASSERT [BootMonFs] > > > > > > /home/thopan01/devel/juno/uefi/uefi/edk2/MdePkg/Library/BaseLib/String.c(173): > > > > > > ((UINTN) String & 0x00000001) == 0 > > > > > > ... > Could you please share the backtrace and the results of > > nm -n Build/ArmJuno/DEBUG_GCC5/AARCH64/Platform/ARM/Drivers/BootMonFs/BootMonFs/DEBUG/BootMonFs.dll > > for the failing case? > It seems like BootMonFsOpenFile() is being called from FdtClientDxe with a misaligned CHAR16* argument for Filename. Could you share the nm -n output of /home/thopan01/devel/juno/uefi/uefi/edk2/Build/ArmJuno/DEBUG_GCC5/AARCH64/Platform/ARM/Drivers/FdtPlatformDxe/FdtPlatformDxe/DEBUG/FdtPlatformDxe.dll as well please? Thanks.