Re: [PATCH 00/19] ArmPlatformPkg: remove unused or migrated modules

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 25 November 2017 at 11:47, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Nov 15, 2017 at 04:56:18PM +0000, Ard Biesheuvel wrote:
>> Remove everything from ArmPlatformPkg that is either unused, or so highly
>> specific to development platforms manufactured by ARM Ltd. that they really
>> don't belong in the main branch.
>>
>> Note that the migration involves patches against edk2-platforms that add
>> some of this code back under Platform/ARM. Most of it (but not all of it)
>> has been posted as a separate series already.
>>
>> Ard Biesheuvel (19):
>>   ArmPkg: remove unused ArmGicSecLib library implementation
>>   ArmPlatformPkg: remove ArmPlatformSecLib definition and
>>     implementations
>>   ArmPlatformPkg: remove unused DebugSecExtraActionLib library
>>   ArmPlatformPkg: remove ArmTrustedMonitorLib definition and
>>     implementation
>>   ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib
>>   ArmPlatformPkg: remove NorFlashArmVExpressLib
>>   ArmPlatformPkg: remove ArmJunoPkg
>>   ArmPlatformPkg/PL031RealTimeClockLib: drop ArmPlatformSysConfigLib
>>     reference
>>   ArmPlatformPkg: remove ArmVExpressPkg
>
> Please hold off on this one (remove ArmVExpressPkg) until we hear back
> from Evan.
>

Sure. Note that this affects a couple of other patches as well, please
see below for what I was able to merge.

>>   ArmPlatformPkg: remove ArmPlatformSysConfigLib library class
>
> No separate comment on this one, just to break it away from the below.
>
>>   ArmPlatformPkg: remove unused PL301Axi driver
>>   ArmPlatformPkg: remove unused PL35x driver
>>   ArmPlatformPkg: remove PL34xDmc driver
>>   ArmPlatformPkg: remove unused PL310 driver
>>   ArmPlatformPkg: remove unused ArmTrustZone driver
>>   ArmPlatformPkg: remove unused SP804 driver and TimerLib
>>   implementation
>
> Please separate the "delete used drivers" from the rest of this set.
> Let's give potential out-of-tree users a few weeks to respond.
>
> My last working day before sabbatical is 15 Dec, so how about
> Reviewed-by-if-no-comments-by-15-Dec: Leif Lindholm <leif.lindholm@linaro.org>
> ?
>
>>   ArmPlatformPkg: remove unused L2X0CacheLibNull library
>>   ArmPlatformPkg: remove EblCmdLib implementation
>>   ArmPlatformPkg: remove BootMonFs and ArmShellCmdRunAxf
>
> For the remainder:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed the following

142fa386eb90 ArmPkg: remove unused ArmGicSecLib library implementation
37fcab3e106f ArmPlatformPkg: remove ArmPlatformSecLib definition and
implementations
7c0e497d6ea9 ArmPlatformPkg: remove unused DebugSecExtraActionLib library
0abce0329edf ArmPlatformPkg: remove ArmTrustedMonitorLib definition
and implementation
4cebe0453fea ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from
ArmPlatformLib
4d472fb8ae15 ArmPlatformPkg: remove ArmJunoPkg
0d36a219c7bd ArmPlatformPkg/PL031RealTimeClockLib: drop
ArmPlatformSysConfigLib reference
05129444f67e ArmPlatformPkg: remove unused L2X0CacheLibNull library
d780544d3d1c ArmPlatformPkg: remove EblCmdLib implementation

Once we've decided how to proceed, I will rebase and send out the
remaining patches.