From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::236; helo=mail-it0-x236.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE5C322152384 for ; Mon, 4 Dec 2017 06:48:44 -0800 (PST) Received: by mail-it0-x236.google.com with SMTP id d137so7198493itc.2 for ; Mon, 04 Dec 2017 06:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2GybdaZFHpt2erZzw8gjLdBbFRk6fRXtRN8neEpTmdY=; b=kcdfdB/tGe8YCvA4btymeFBgos8qR+/+NpbaCFx1tG1l/2kBOlzQDkNr3qXox8xcHA iDAGQGunBU3CvZcOJ23JKbg+cgNkyOba5KhAQACx8zNmEZiG6poeMlLDHFjCNMq6+aXN puzGmdOIUmJaZZhH1p1ixqQ8IH6h5Bodu9F/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2GybdaZFHpt2erZzw8gjLdBbFRk6fRXtRN8neEpTmdY=; b=itE7OegOtyyCTtjA/BcMoluMXhAAjqpHDRM7WziQYEJUOvfuHjvuOhwSm+2L+vzAI7 BLPE+Xnz1IMMlaGQTiPhAgH6bPeRzoFivisYX81o0snoF67soSZWqsa/S6ICKz2bVRHZ ge4r7KLQdkZDzXfEyyUj4KnnrKO2fdIEyJ9NOsqMMWesv5zmyxRhCy0W9p+3yxg6sVux l6RqDvCYEwTt4eq6IVEqwtYhr5+bGu3bKnsX0RGGTiBXjf62iUsGx2B/UGxwsd9rXXFY EvRyQkairruoMSi9UQQF1BE1ooX4siWjuBUJvcD9EluCNzw3sdMV3sfWOc+lX5EB5GSN hMfQ== X-Gm-Message-State: AJaThX75F5mVTvE9Z/rL7dSpZfq0xGv99vwIicDvA+oJXa7LZ07QpXFL 5xdHVuuVu3yz5LMLXk8AvgKkj670nhxRJna6rCV0R0bz X-Google-Smtp-Source: AGs4zMYcG2Wn3CU6VA6BFmkdQpYM0IDKR1TIpqUP7lRXedf0jAvCNVR5LqjzyGCz5B0a89jFlPwntlFXq7IKLFNu8CQ= X-Received: by 10.107.59.85 with SMTP id i82mr23658823ioa.253.1512399193497; Mon, 04 Dec 2017 06:53:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 4 Dec 2017 06:53:12 -0800 (PST) In-Reply-To: <20171130101132.18317-1-ard.biesheuvel@linaro.org> References: <20171130101132.18317-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Mon, 4 Dec 2017 14:53:12 +0000 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , "Zeng, Star" , "Wu, Hao A" , "Tian, Feng" , Ard Biesheuvel Subject: Re: [PATCH v2 0/2] quirks handling for SDHCI controllers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 14:48:44 -0000 Content-Type: text/plain; charset="UTF-8" On 30 November 2017 at 10:11, Ard Biesheuvel wrote: > Many SDHCI implementations exist that are almost spec complicant, and > could be driven by the generic SD/MMC host controller driver except > for some minimal necessary init time tweaks. > > Adding such tweaks to the generic driver is undesirable. On the other > hand, forking the driver for every platform that has such a SDHCI > controller is problematic when it comes to upstreaming and ongoing > maintenance (which is arguably the point of upstreaming in the first > place). > > So these patches propose a workaround that is minimally invasive on the > EDK2 side, but gives platforms a lot of leeway when it comes to applying > SDHCI quirks. > > Changes since RFC/v1: > - add EFI_SD_MMC_PASS_THRU_PROTOCOL* member to override methods > - use UINT64* not VOID* to pass capability structure (which is alwys 64 bits > in size) > > Ard Biesheuvel (2): > MdeModulePkg: introduce SD/MMC override protocol > MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden > Hao, Star, Any comments? Thanks, Ard.