From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D3A532257C2C1 for ; Mon, 19 Mar 2018 01:12:22 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id 19-v6so4947359itw.3 for ; Mon, 19 Mar 2018 01:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eV0H2lRBoIjj9fpLR/fEHe6LrODyHIfmuBa18yLpNTk=; b=Pxs6xG3C4amEVfTpHUsB5na4m/fa8NTJcF5VK3tCiTA0u6XgbS1zAp1MtMWnoWEzEx gpmo+bKYTD2g3EdP+6ELHZgmyb9/FslFEUIiRIJ7p2wAGm4AeFdCfBnOJ0UkE0oxAVfX wCw42pWRqe2QmyCdJTb5UqhHnt0b16G/cjPww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eV0H2lRBoIjj9fpLR/fEHe6LrODyHIfmuBa18yLpNTk=; b=oRKhgpo0qA6ytrA4gxKUk7XwhvPvb0H4KlOkSAjlnN0alI1oHFIf2XUrhTu8nMU0Ky /zxJ7QcfG5vn4XJASLbCehbv2ESJwCJHAEYv+e5AvhG0yXfO+j1biXS0OF6biygjIJoc ZGlix7lCRMORPHdPQnR6KcaiT751BFw8KtE5A/kTtRYZhCrjBjo9/w6AZvzz923vnvIV VdvpzgHvAc9z00HmVha6onl5PZNxLOR+b5fi9iG2V4bKX7XQ1tBACDv+xVwYCOVPPZHi zQScxbPEI/VsqF8b5isXi59v1rKqvAMw9ZjNvbUathb7CJ9K+VGvxzrT3UyMvSXXd23z pNeg== X-Gm-Message-State: AElRT7HzzrDmg+2+Usff+Puchjc2iwTUSYMnbFNQiRrHgWsG/SEJU7Ki l+f/yiHQ2zQhSmKyaFdAYZBC5IT0Yj2Abc0jswsUdw== X-Google-Smtp-Source: AG47ELuc3nBBW64wpFQeaFddjq2d/gnQfqAZY3+PGVupEdNyfi66dcgDgGW6+uHzleg11gEKSwgkTbfphW1tEIrKDmY= X-Received: by 2002:a24:3cd8:: with SMTP id m207-v6mr11054619ita.68.1521447529160; Mon, 19 Mar 2018 01:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Mon, 19 Mar 2018 01:18:48 -0700 (PDT) In-Reply-To: <20180319081240.6ueqdnizbcyutut5@bivouac.eciton.net> References: <20180316161322.6756-1-ard.biesheuvel@linaro.org> <20180316161322.6756-5-ard.biesheuvel@linaro.org> <20180319081240.6ueqdnizbcyutut5@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 19 Mar 2018 16:18:48 +0800 Message-ID: To: Leif Lindholm , "Zeng, Star" , Ruiyu Ni , Eric Dong Cc: "edk2-devel@lists.01.org" Subject: Re: [RFC PATCH edk2-platforms 4/6] Silicon/SynQuacer: make lowest supported f/w version PCD configurable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2018 08:12:23 -0000 Content-Type: text/plain; charset="UTF-8" On 19 March 2018 at 16:12, Leif Lindholm wrote: > On Fri, Mar 16, 2018 at 04:13:20PM +0000, Ard Biesheuvel wrote: >> Allow the lowest supported firmware version to be configured by PCD >> so that each platform can set it individually. > > Is there a case for adding this PCD to MdeModulePkg? > Given that generic Capsule support is implemented there, I agree this should probably be added to MdeModulePkg instead. >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 2 ++ >> Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc | 2 +- >> Silicon/Socionext/SynQuacer/SynQuacer.dec | 3 +++ >> 3 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf >> index 95a5e482a713..db0c9c43b2e5 100644 >> --- a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf >> +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf >> @@ -29,6 +29,7 @@ [Packages] >> MdeModulePkg/MdeModulePkg.dec >> MdePkg/MdePkg.dec >> SignedCapsulePkg/SignedCapsulePkg.dec >> + Silicon/Socionext/SynQuacer/SynQuacer.dec >> >> [LibraryClasses] >> DebugLib >> @@ -39,6 +40,7 @@ [LibraryClasses] >> [FixedPcd] >> gArmTokenSpaceGuid.PcdFdSize >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision >> + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion >> >> [Pcd] >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor >> diff --git a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc >> index fb69de078313..12a56315a5ab 100644 >> --- a/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc >> +++ b/Platform/Socionext/DeveloperBox/SystemFirmwareDescriptor/SystemFirmwareDescriptorTable.aslc >> @@ -25,7 +25,7 @@ >> #define BUILD_STRING(x) L"build #" __BUILD_STRING(x) >> #define CURRENT_FIRMWARE_VERSION FixedPcdGet32 (PcdFirmwareRevision) >> #define CURRENT_FIRMWARE_VERSION_STRING BUILD_STRING (FixedPcdGet32 (PcdFirmwareRevision)) >> -#define LOWEST_SUPPORTED_FIRMWARE_VERSION 0x00000001 >> +#define LOWEST_SUPPORTED_FIRMWARE_VERSION FixedPcdGet32 (PcdLowestSupportedFirmwareVersion) >> >> #define IMAGE_ID SIGNATURE_64('S', 'N', 'D', 'E', 'V', 'B', 'O', 'X') >> #define IMAGE_ID_STRING L"Socionext Developer Box" >> diff --git a/Silicon/Socionext/SynQuacer/SynQuacer.dec b/Silicon/Socionext/SynQuacer/SynQuacer.dec >> index eb4fc4ace2f7..ccaf80def06b 100644 >> --- a/Silicon/Socionext/SynQuacer/SynQuacer.dec >> +++ b/Silicon/Socionext/SynQuacer/SynQuacer.dec >> @@ -44,6 +44,9 @@ [PcdsFixedAtBuild] >> >> gSynQuacerTokenSpaceGuid.PcdI2cReferenceClock|62500000|UINT32|0x00000005 >> >> + # for capsule update >> + gSynQuacerTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|1|UINT32|0x00000009 >> + >> [PcdsPatchableInModule, PcdsDynamic] >> # Enable both RC #0 and RC #1 by default >> gSynQuacerTokenSpaceGuid.PcdPcieEnableMask|0x3|UINT8|0x00000007 >> -- >> 2.15.1 >>