From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4065922637DCA for ; Thu, 19 Apr 2018 03:34:00 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id t192-v6so20166966itc.1 for ; Thu, 19 Apr 2018 03:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zXHHnzMZNYmVVHyGsMx0SAJgB67bTGZemU6hR186hdQ=; b=bdVSHP5GsvAlH0s1xFwzOwP1VxzThRa7mhnFxv0qD3TnjM3rnaHIO6i9IVP8EvjUwS G+vTsnMpzQRfR/OEwa/eY1OP58R14pzPgCWDvhOvtFD/kNtX0s0KSVSgNGorGRtp0tvc I2Hm64neEj5Id22E4zEaW45dZbpAbaAEw76zM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zXHHnzMZNYmVVHyGsMx0SAJgB67bTGZemU6hR186hdQ=; b=Yx6vbKyOvlEX8f6L2KcT8uQePKinXFuhkpiJQf1QRg1JM1w0GnL584y4ZYbVvyWnCg LNZyWzXxyDoJCw8RqmWzLAvTV+PViKLUP45IG4kYTqDREviume7VrbM5Q0Y8UJtXDsOv YB48S053K3IH3dH5qQsXh5Cve1jvD77gXgwVlMnvbxV84GDewlOKYkysAoAjyU6gESSe 2VQb5FbFV53BeQGUVyrsEc9zsG7QKRrM6sucHg+ga1QoUM+naRE/+552fm/oFIjZ62Bh WAc1At0Ic5Sg3Kk471ObJvj7a+nbDIyr98nh0UukDHCkXJw3nzOsehL8YudLYpfpmMaY TmKg== X-Gm-Message-State: ALQs6tBH+Qq+PPhPTFPX4Q4E4HMflcXYiFkeKRTeAaoREtOhnhbdmp8N DZSBWtWjCtbUizRpnG2ABIIUvqx5C8jFf6jhxP2ekQ== X-Google-Smtp-Source: AIpwx4+qcweyB6mr7czXjnK4c4oo+KHWf0MtUYvDBLkK2CRkWVeV9MfKLp2SSWo10dTcmrJHRbFnlFkWc/FYkWbBPV0= X-Received: by 2002:a24:b14d:: with SMTP id c13-v6mr5932043itj.106.1524134039240; Thu, 19 Apr 2018 03:33:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Thu, 19 Apr 2018 03:33:58 -0700 (PDT) In-Reply-To: <1524016475-18667-1-git-send-email-mw@semihalf.com> References: <1524016475-18667-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Thu, 19 Apr 2018 12:33:58 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Hua Jing , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk Subject: Re: [platforms PATCH 1/1] Marvell/Drivers: MvFvbDxe: Fix uninstallation of protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 10:34:00 -0000 Content-Type: text/plain; charset="UTF-8" On 18 April 2018 at 03:54, Marcin Wojtas wrote: > Recently added installation of gEdkiiNvVarStoreFormattedGuid > introduced bug in the error path. gBS->UninstallProtocolInterface > takes an actual handle as an argument (not the pointer). Fix this > and on the occasion fix indentation of multiline call. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Pushed as 3454e932107c7524f6a89fcab35d430d0b422b2e Thanks > --- > Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c > index 6e583a3..1a41a4f 100644 > --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c > +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c > @@ -1142,9 +1142,9 @@ ErrorSetMemAttr: > gDS->RemoveMemorySpace (RegionBaseAddress, RuntimeMmioRegionSize); > > ErrorAddSpace: > - gBS->UninstallProtocolInterface (&gImageHandle, > - &gEdkiiNvVarStoreFormattedGuid, > - NULL); > + gBS->UninstallProtocolInterface (gImageHandle, > + &gEdkiiNvVarStoreFormattedGuid, > + NULL); > > ErrorInstallNvVarStoreFormatted: > gBS->UninstallMultipleProtocolInterfaces (&mFvbDevice->Handle, > -- > 2.7.4 >