Re: [EXTERNAL] [PATCH 3/4] MdePkg: remove PropertiesTable GUID

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 27 Mar 2020 at 02:02, Bret Barkelew <Bret.Barkelew@microsoft.com> wrote:
>
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
>

Thanks Bret

Does this apply only to this 3rd patch? Or to the whole series?


>
>
> ________________________________
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Thursday, March 26, 2020 3:24:42 AM
> To: devel@edk2.groups.io <devel@edk2.groups.io>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Ray Ni <ray.ni@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
> Subject: [EXTERNAL] [PATCH 3/4] MdePkg: remove PropertiesTable GUID
>
> Remove the GUID definition that describes the deprecated properties table,
> which is no longer generated by the DXE core.
>
> Link: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2633&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C0c14ed320c7f416c975908d7d16feb9a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208150931667814&amp;sdata=PE0Hy4H60WnykMk4MpFE5mCmD1Ucm6I7Byl1yS33ei0%3D&amp;reserved=0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdePkg/Include/Guid/PropertiesTable.h | 31 --------------------
>  MdePkg/MdePkg.dec                     |  3 --
>  2 files changed, 34 deletions(-)
>
> diff --git a/MdePkg/Include/Guid/PropertiesTable.h b/MdePkg/Include/Guid/PropertiesTable.h
> deleted file mode 100644
> index 56dbc7f96138..000000000000
> --- a/MdePkg/Include/Guid/PropertiesTable.h
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -/** @file
> -  GUIDs used for UEFI Properties Table in the UEFI 2.5 specification.
> -
> -  Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> -
> -**/
> -
> -#ifndef __EFI_PROPERTIES_TABLE_H__
> -#define __EFI_PROPERTIES_TABLE_H__
> -
> -#define EFI_PROPERTIES_TABLE_GUID {\
> -  0x880aaca3, 0x4adc, 0x4a04, {0x90, 0x79, 0xb7, 0x47, 0x34, 0x8, 0x25, 0xe5} \
> -}
> -
> -typedef struct {
> -  UINT32    Version;
> -  UINT32    Length;
> -  UINT64    MemoryProtectionAttribute;
> -} EFI_PROPERTIES_TABLE;
> -
> -#define EFI_PROPERTIES_TABLE_VERSION  0x00010000
> -
> -//
> -// Memory attribute (Not defined bit is reserved)
> -//
> -#define EFI_PROPERTIES_RUNTIME_MEMORY_PROTECTION_NON_EXECUTABLE_PE_DATA        0x1
> -
> -extern EFI_GUID gEfiPropertiesTableGuid;
> -
> -#endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index ac1f5339af06..6c37c2181c62 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -578,9 +578,6 @@ [Guids]
>    # GUIDs defined in UEFI2.5
>    #
>
> -  ## Include/Guid/PropertiesTable.h
> -  gEfiPropertiesTableGuid        = { 0x880aaca3, 0x4adc, 0x4a04, {0x90, 0x79, 0xb7, 0x47, 0x34, 0x8, 0x25, 0xe5 }}
> -
>    ## Include/Guid/SystemResourceTable.h
>    gEfiSystemResourceTableGuid    = { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80 }}
>
> --
> 2.17.1
>