From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH] OvmfPkg/AcpiPlatformDxe: fix spurious uninitialized var warning
Date: Fri, 9 Jun 2017 08:58:25 +0000 [thread overview]
Message-ID: <CAKv+Gu8xK-b9BfjM_dxCxTBH6nip7dSGP=3P2jUUO1Js2CnW6g@mail.gmail.com> (raw)
In-Reply-To: <a2f3a9ff-9155-95da-7f7d-a77825ebd81d@redhat.com>
On 8 June 2017 at 22:18, Laszlo Ersek <lersek@redhat.com> wrote:
> On 06/08/17 21:05, Ard Biesheuvel wrote:
>> Commit 4275f38507a4 ("OvmfPkg/AcpiPlatformDxe: alloc blobs from 64-bit
>> space unless restricted") introduced a variable which is [incorrectly]
>> identified by GCC as being potentially uninitialized. So let's just set
>> it to NULL before use.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
>> index 98be36c64b43..a0b1cfd2be05 100644
>> --- a/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
>> +++ b/OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c
>> @@ -1001,6 +1001,7 @@ InstallQemuFwCfgTables (
>> RestorePciDecoding (OriginalPciAttributes, OriginalPciAttributesCount);
>> LoaderEnd = LoaderStart + FwCfgSize / sizeof *LoaderEntry;
>>
>> + AllocationsRestrictedTo32Bit = NULL;
>> Status = CollectAllocationsRestrictedTo32Bit (
>> &AllocationsRestrictedTo32Bit,
>> LoaderStart,
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
Pushed as 8f98c76f992b
prev parent reply other threads:[~2017-06-09 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 19:05 [PATCH] OvmfPkg/AcpiPlatformDxe: fix spurious uninitialized var warning Ard Biesheuvel
2017-06-08 22:18 ` Laszlo Ersek
2017-06-09 8:58 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8xK-b9BfjM_dxCxTBH6nip7dSGP=3P2jUUO1Js2CnW6g@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox