From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3264021144D08 for ; Wed, 19 Sep 2018 14:47:26 -0700 (PDT) Received: by mail-it0-x241.google.com with SMTP id h20-v6so9766114itf.2 for ; Wed, 19 Sep 2018 14:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=u+/LTAnkpwTAhB29xViRnCNENpRRr1ad4c2OeXsQBEg=; b=T3wIQ4mhp1uOh3ogs5xuVXbR0SDpG2mknQJk5J0ii+vCDAdP4TBXY0xpAvYF9GdUE7 QYYlTCUSIxKNwoFsX3/PIACfV0Ti2cijOtiGBlHGCV1zy3wAhyMyRYCzgyxubpb6f6Py IRt5dgK3FrrdSq6d9c9HFo6CrlevOfcwdtpjY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=u+/LTAnkpwTAhB29xViRnCNENpRRr1ad4c2OeXsQBEg=; b=A7KxkMFgCH5f1/E3v3QGc7zi0HGqKNxq7ke/Z+oApv1LFjlfuCueB4/3luf4kJc+pW B1pfnyshZIFriaEtUja97Q3kfFf+xIsfG64NWVenxvuSjxhK6o0kXiFzPRenbSn1QjgP zZqrUvhqxi+3iVEarvCp0cBbDczIfSDmMviQAPKl3+jKKpd4Cz1mQ8eSuGsOQewp8v38 qdO4YdmpvlhnZHjQ28zeL5kfcHK/Vp+/2rWa0QHRptYU8dhaOxWwJ7bo9CVSB3oEh1Rd Ey9/XcC3UuQKrkMRGSceH67xSSb8B25J3BgyCZpJjSDk009ZQ5eo8pwXk+Ci0KCR0S0G UGFQ== X-Gm-Message-State: APzg51CQdB9WEK28M1P6I/MbIKHPbJ7f9emj9Y6T77fvZNUke6sEnkdL K5hrlqH/0I6jutN5dTt58Jp7i7qWJZMCcDPzMM960w== X-Google-Smtp-Source: ANB0VdbYsT0TMsVLGLbLvtJ/bcHsmlcqgBJ595Q4unoO5nQfyB6zxwi1N8q/LGHAc01EEseyfTVhMsojXroSsVaO9TI= X-Received: by 2002:a24:57cb:: with SMTP id u194-v6mr22709495ita.148.1537393645960; Wed, 19 Sep 2018 14:47:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:2848:0:0:0:0:0 with HTTP; Wed, 19 Sep 2018 14:47:25 -0700 (PDT) In-Reply-To: References: <20180907054202.24798-1-ard.biesheuvel@linaro.org> <20180907054202.24798-4-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Wed, 19 Sep 2018 14:47:25 -0700 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Star Zeng , Jian J Wang , Michael D Kinney , Liming Gao , Chao Zhang , Jiewen Yao , Leif Lindholm Subject: Re: [PATCH v2 3/3] SecurityPkg: remove PE/COFF header workaround for ELILO on IPF X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 21:47:27 -0000 Content-Type: text/plain; charset="UTF-8" On 7 September 2018 at 01:28, Laszlo Ersek wrote: > On 09/07/18 07:42, Ard Biesheuvel wrote: >> Now that Itanium support has been dropped, we can remove the various >> occurrences of the ELILO on Itanium PE/COFF header workaround. >> >> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 47 ++++---------------- >> SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 27 +++-------- >> SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c | 27 +++-------- >> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c | 25 +++-------- >> 4 files changed, 25 insertions(+), 101 deletions(-) > > Reviewed-by: Laszlo Ersek > Chao, Jiewen: any concerns?