From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mHX5iXgx; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Tue, 17 Sep 2019 01:54:05 -0700 Received: by mail-wm1-f67.google.com with SMTP id r195so2113763wme.2 for ; Tue, 17 Sep 2019 01:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kRzzCu5+0/8fffUzyym3zzXdX/BZlgebH/a/Ah0T4nw=; b=mHX5iXgxHATQB90R4EYIQ4aCa9Mxbd9P0WH3o32wKSglJ5t8QOxVQ07agAdt8NDuhF xTf24Ru3FRZ3pyR234Tc/GeEwKojdUnCgC2VfHNWMkz5F6adn6q37AXQ1QxIh/rXj8og Qsoirbf7z1QwxdEj+Vn67Ni8JReHvDaYUwnsnvuCcPalC88MR0PYHxAzEW6a3eiF0ijM Ufo5RVMBA7gTRLuaYWvKg3qzBuiUoWKvniVj42dtFMo32j458UX5oTZZYDxnTyN+/GqZ Ip9iga5RE7oZ0Eo+RrtM7BvQ/F3xVM0AoSrpbKyspJOB6PFgqp85cMPVzGlWJ0r+P4ID 73aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kRzzCu5+0/8fffUzyym3zzXdX/BZlgebH/a/Ah0T4nw=; b=cQRlGtYWqrVTaI7AR+zSpi2pSpHdaEbdhELcqj+vCTBkB7g2nvIARvFHfRgmAoY5dH eET74Xj41wJQP5d3Fyd/snh2W9/YGjlcso1M2pVm5/+2DifoQ8oHer2bHuyKYgW7/GIl Jl3qIlVs8WbSBnlo5lE/3tStpHB2DBzqWw93C3xGtfEoiQdl9kOO7ephddpr1QPMuCyo gvnZc9f+z7znNaPhcQq1wAJ3U4U+uznhJUx0t8+/myU9m41OEvt6CiwJG/jdtY4T82Vg rf7bznF01I9DEOElq63wwx9LWSUmZAYYaXrA1V8L3R2cZzKeAFcOVoIL7GTCWlVFqjUc ECWw== X-Gm-Message-State: APjAAAVJKCYmAszCPp+b1IzAKcKFpprWsUVrzxaaBxP4xKjYLnzsL1Pl BHVOAneqbe3ajn97FDMcAYNNEp9rjhlrifTxfI3nHA== X-Google-Smtp-Source: APXvYqxIEgqClcWDpnd+pvtyGSzvvi6QtVzc4B6TaJWr3ku6VU1H7CFYx/F6tPGm8y7VLKwK9+ZCX+FFnXo3h9pOCRA= X-Received: by 2002:a7b:c451:: with SMTP id l17mr2244381wmi.61.1568710443202; Tue, 17 Sep 2019 01:54:03 -0700 (PDT) MIME-Version: 1.0 References: <20190913190445.9832-1-ard.biesheuvel@linaro.org> <3c8a28f6-d921-cde2-0195-08efce528701@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C503F7B0A2F@shsmsx102.ccr.corp.intel.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 17 Sep 2019 09:53:38 +0100 Message-ID: Subject: Re: [PATCH] StandaloneMmPkg: make package .DSC file build again To: Laszlo Ersek Cc: "Yao, Jiewen" , edk2-devel-groups-io , Achin Gupta Content-Type: text/plain; charset="UTF-8" On Mon, 16 Sep 2019 at 19:26, Laszlo Ersek wrote: > > On 09/16/19 17:06, Yao, Jiewen wrote: > > That is correct. > > > > Current trunk only supports ARM system. > > > > I have branch to support x86 - https://github.com/jyao1/edk2/tree/StandaloneSmmX86Poc > > But that is not merged into trunk yet. > > In that case, for this patch: > > Build-tested-by: Laszlo Ersek > > (apologies, my prior R-b was a typo; I pressed the wrong hotkey for > inserting the tag in the email) > > I still think the IA32/X64 part should be removed from > SUPPORTED_ARCHITECTURES (and their addition should be a part of Jiewen's > topic branch). But, I agree such a cleanup is out of scope for this > patch; the patch does fix the AARCH64 regression. > > Thank you, Ard! > Laszlo > Pushed as 9790f62be1aa..82c1a2120855 Thanks all. > >> -----Original Message----- > >> From: Ard Biesheuvel > >> Sent: Monday, September 16, 2019 1:18 PM > >> To: Laszlo Ersek > >> Cc: edk2-devel-groups-io ; Achin Gupta > >> ; Yao, Jiewen > >> Subject: Re: [PATCH] StandaloneMmPkg: make package .DSC file build again > >> > >> On Mon, 16 Sep 2019 at 12:13, Laszlo Ersek wrote: > >>> > >>> Hi Ard, > >>> > >>> On 09/13/19 21:04, Ard Biesheuvel wrote: > >>>> The StandaloneMmPkg .DSC file went out of sync with the changes > >>>> applied to the package when I enabled this code on the Synquacer > >>>> platform in edk2-platforms. So apply the necessary changes to make > >>>> this package build in isolation. > >>>> > >>>> Signed-off-by: Ard Biesheuvel > >>>> --- > >>>> StandaloneMmPkg/StandaloneMmPkg.dsc | 19 +++++++++++-------- > >>>> 1 file changed, 11 insertions(+), 8 deletions(-) > >>>> > >>>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc > >> b/StandaloneMmPkg/StandaloneMmPkg.dsc > >>>> index 8c5b9b3a3d47..8a68d397469b 100644 > >>>> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > >>>> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > >>>> @@ -39,29 +39,32 @@ > >>>> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > >>>> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > >>>> > >> DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDe > >> bugPrintErrorLevelLib.inf > >>>> + > >> ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/P > >> rePiExtractGuidedSectionLib.inf > >>>> FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf > >>>> - > >> HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmC > >> oreHobLib.inf > >>>> + > >> HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLi > >> b.inf > >>>> IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > >>>> > >> MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMe > >> mLib.inf > >>>> > >> MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAl > >> locationLib/StandaloneMmCoreMemoryAllocationLib.inf > >>>> + > >> MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Standalo > >> neMmServicesTableLib.inf > >>>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > >>>> + > >> PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraAct > >> ionLib/StandaloneMmPeCoffExtraActionLib.inf > >>>> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > >>>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > >>>> > >> ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseRepo > >> rtStatusCodeLibNull.inf > >>>> - > >>>> - # > >>>> - # Entry point > >>>> - # > >>>> - > >> StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriv > >> erEntryPoint/StandaloneMmDriverEntryPoint.inf > >>>> + > >> StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreE > >> ntryPoint/StandaloneMmCoreEntryPoint.inf > >>>> + > >> StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoin > >> t/StandaloneMmDriverEntryPoint.inf > >>>> > >>>> [LibraryClasses.AARCH64] > >>>> ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > >>>> > >> StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStand > >> aloneMmLib.inf > >>>> ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > >>>> > >> CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMa > >> intenanceLib.inf > >>>> - > >> PeCoffExtraActionLib|StandaloneMmPkg/Library/StandaloneMmPeCoffExtraAct > >> ionLib/StandaloneMmPeCoffExtraActionLib.inf > >>>> > >>>> - > >> StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreE > >> ntryPoint/StandaloneMmCoreEntryPoint.inf > >>>> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > >>>> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > >>>> + > >>>> +[LibraryClasses.common.MM_CORE_STANDALONE] > >>>> + > >> HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmC > >> oreHobLib.inf > >>>> > >>>> > >> ################################################################# > >> ############### > >>>> # > >>>> > >>> > >>> With this patch applied on top of 9b5a1c789d39, the DSC builds fine for > >>> AARCH64. > >>> > >>> However, the DSC also advertizes IA32 and X64 in > >>> "SUPPORTED_ARCHITECTURES", and those builds still fail, with: > >>> > >>> StandaloneMmPkg/StandaloneMmPkg.dsc(...): error 4000: Instance of > >>> library class [CacheMaintenanceLib] is not found > >>> in [StandaloneMmPkg/Core/StandaloneMmCore.inf] [IA32] > >>> > >>> Now, I'm not sure if *this* build breakage is related to the Synquacer > >>> work you mention in the blurb. If it is, then fixing it would be nice. > >>> If not, then can we perhaps remove IA32 and X64 from > >>> SUPPORTED_ARCHITECTURES? > >>> > >>> If you end up reposting with IA32/X64 removed from > >>> SUPPORTED_ARCHITECTURES, then, for that version: > >>> > >>> Reviewed-by: Laszlo Ersek > >>> > >> > >> Jiewen should correct me if I am wrong, but as far as I know, > >> StandaloneMmPkg is ARM-only in practice, even if the PI spec is arch > >> agnostic about it. >