From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22e; helo=mail-io0-x22e.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8D282035BB1B for ; Fri, 17 Nov 2017 08:18:54 -0800 (PST) Received: by mail-io0-x22e.google.com with SMTP id w127so9268924iow.11 for ; Fri, 17 Nov 2017 08:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1FvVZ3frR9GjBIZDmXAy81TQcXKXt41EB5p9tbYAC6A=; b=LardEPEG1haRuePWFaz00NpAksxEgOADePUH9AY9QfOdTJhm/hWtCMtmP+z+LVGOGr buaqIPGpGmN7fep6Yncq16Z+2R4PDFzN+NTcy3Yt1rMR9x1U4eUbHSIkufZz96lJ7OuZ V6iokU+tuUTbz45JjcqJ/nNBdH56Ngw4tu/5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1FvVZ3frR9GjBIZDmXAy81TQcXKXt41EB5p9tbYAC6A=; b=EB9TtPsfK36GobN2NW/Uj6DSqWxwn971o/pYX9dD+2u5MRRoPvznoG6twP0PLWUmnU 5mVLd4wi7HxIGiuo4MT7UT5HF38n4PpOxNtDhcKIxhbRThnAUNh4BKdJw6Oxg8Hh1L/m L2PDcIOYgWH5yFpPMOCWPXrOtFfUFIS8VPxU5gM6ATANab0oAkBYlfKLbrgESM4KLuhy 30DUiYOW/asDLj/f5WX4FtDxEGycBRpXzKYXeGfaKh22zv6zzQtOjEJZcoLxgm+eEBHA zptKAytxefrJlHxiD7G5ONu+JaCEQqyr1vnay+E4exOZweXOa3sxRfMPflxvMeXilf7w RE7Q== X-Gm-Message-State: AJaThX5YahFVlK3K87xmmi34MsygXb307aOX/xqZ7USqFPZU97t3Dnoo kSEDyhPhjUYLttDAQ85IU01sw2C/S9i70sie6dTRUA== X-Google-Smtp-Source: AGs4zMbaKgSaF965+9lFH4DAkb25E2YfP55wdgbgXSDhNSlTnhS5LwHBrG0jGfD5pxRLoGtt+u1xv4bo3Iwi4r66Qqk= X-Received: by 10.107.2.137 with SMTP id 131mr3518746ioc.186.1510935784656; Fri, 17 Nov 2017 08:23:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.3 with HTTP; Fri, 17 Nov 2017 08:23:04 -0800 (PST) In-Reply-To: <20171117162026.45dgzazw2scsdlhw@bivouac.eciton.net> References: <20171117160913.17292-1-ard.biesheuvel@linaro.org> <20171117160913.17292-2-ard.biesheuvel@linaro.org> <20171117162026.45dgzazw2scsdlhw@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 17 Nov 2017 16:23:04 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 16:18:54 -0000 Content-Type: text/plain; charset="UTF-8" On 17 November 2017 at 16:20, Leif Lindholm wrote: > On Fri, Nov 17, 2017 at 04:08:59PM +0000, Ard Biesheuvel wrote: >> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and >> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in >> a [FixedPcd] section makes this module unusable for ArmVirtQemu. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Question: shouldn't specifically ArmVirtQemu work fine with these, > since it defines them as PcdsFixedAtBuild? > Whereas both ArmVirtQemuKernel and ArmVirtXen define them as > patchable. > PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only platform that will include this library after this series. The others have their own PrePi implementation, allowing me to drop any dependencies on ArmPlatformLib altogether.