* [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg
@ 2019-02-01 6:01 Dandan Bi
2019-02-01 6:01 ` [patch 1/2] MdeModulePkg: Fix coding style issues Dandan Bi
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dandan Bi @ 2019-02-01 6:01 UTC (permalink / raw)
To: edk2-devel; +Cc: Ard Biesheuvel, Liming Gao, Jian J Wang, Hao Wu
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Dandan Bi (2):
MdeModulePkg: Fix coding style issues
MdePkg: Fix coding style issues
.../FaultTolerantWriteSmmCommon.h | 4 ++--
.../FaultTolerantWriteStandaloneMm.c | 2 +-
.../FaultTolerantWriteTraditionalMm.c | 2 +-
.../Variable/RuntimeDxe/PrivilegePolymorphic.h | 4 ++--
.../Variable/RuntimeDxe/VariableStandaloneMm.c | 6 +++---
.../Variable/RuntimeDxe/VariableTraditionalMm.c | 4 ++--
.../Library/StandaloneMmDriverEntryPoint.h | 16 ++++++++--------
.../StandaloneMmDriverEntryPoint.c | 4 ++--
.../StandaloneMmServicesTableLib.c | 4 ++--
9 files changed, 23 insertions(+), 23 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch 1/2] MdeModulePkg: Fix coding style issues
2019-02-01 6:01 [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Dandan Bi
@ 2019-02-01 6:01 ` Dandan Bi
2019-02-01 6:22 ` Wu, Hao A
2019-02-01 6:02 ` [patch 2/2] MdePkg: " Dandan Bi
2019-02-01 10:27 ` [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Ard Biesheuvel
2 siblings, 1 reply; 6+ messages in thread
From: Dandan Bi @ 2019-02-01 6:01 UTC (permalink / raw)
To: edk2-devel; +Cc: Ard Biesheuvel, Jian J Wang, Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1479
Fix issues that reported by Edk2 coding style check tool(ECC) that:
Comment description should end with period '.'
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 4 ++--
.../FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c | 2 +-
.../FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c | 2 +-
.../Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h | 4 ++--
.../Universal/Variable/RuntimeDxe/VariableStandaloneMm.c | 6 +++---
.../Universal/Variable/RuntimeDxe/VariableTraditionalMm.c | 4 ++--
6 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h
index 61293ca864..cf1aef7ca4 100644
--- a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h
+++ b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h
@@ -76,11 +76,11 @@ typedef struct {
BOOLEAN Complete;
UINT8 Data[1];
} SMM_FTW_GET_LAST_WRITE_HEADER;
/**
- Shared entry point of the module
+ Shared entry point of the module.
@retval EFI_SUCCESS The initialization finished successfully.
@retval EFI_OUT_OF_RESOURCES Allocate memory error
@retval EFI_INVALID_PARAMETER Workspace or Spare block does not exist
@@ -107,11 +107,11 @@ FtwSmmIsBufferOutsideSmmValid (
IN EFI_PHYSICAL_ADDRESS Buffer,
IN UINT64 Length
);
/**
- Notify the system that the SMM FTW driver is ready
+ Notify the system that the SMM FTW driver is ready.
**/
VOID
FtwNotifySmmReady (
VOID
);
diff --git a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c
index 8a4ea5b476..c2aa501465 100644
--- a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c
+++ b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c
@@ -63,11 +63,11 @@ FtwCalculateCrc32 (
{
return CalculateCrc32 (Buffer, Length);
}
/**
- Notify the system that the SMM FTW driver is ready
+ Notify the system that the SMM FTW driver is ready.
**/
VOID
FtwNotifySmmReady (
VOID
)
diff --git a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c
index 0981c3c2a9..7c76e1f756 100644
--- a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c
+++ b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c
@@ -70,11 +70,11 @@ FtwCalculateCrc32 (
return ReturnValue;
}
/**
- Notify the system that the SMM FTW driver is ready
+ Notify the system that the SMM FTW driver is ready.
**/
VOID
FtwNotifySmmReady (
VOID
)
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h b/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
index 0a886558f4..9b294e6b36 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
@@ -96,19 +96,19 @@ VOID
VariableSpeculationBarrier (
VOID
);
/**
- Notify the system that the SMM variable driver is ready
+ Notify the system that the SMM variable driver is ready.
**/
VOID
VariableNotifySmmReady (
VOID
);
/**
- Notify the system that the SMM variable write driver is ready
+ Notify the system that the SMM variable write driver is ready.
**/
VOID
VariableNotifySmmWriteReady (
VOID
);
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
index 1e87ccfb5d..2eed038054 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
@@ -36,31 +36,31 @@ VariableSmmIsBufferOutsideSmmValid (
{
return TRUE;
}
/**
- Notify the system that the SMM variable driver is ready
+ Notify the system that the SMM variable driver is ready.
**/
VOID
VariableNotifySmmReady (
VOID
)
{
}
/**
- Notify the system that the SMM variable write driver is ready
+ Notify the system that the SMM variable write driver is ready.
**/
VOID
VariableNotifySmmWriteReady (
VOID
)
{
}
/**
- Variable service MM driver entry point
+ Variable service MM driver entry point.
@param[in] ImageHandle A handle for the image that is initializing this
driver
@param[in] MmSystemTable A pointer to the MM system table
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
index 84f2d12b58..42e2c63c3a 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
@@ -38,11 +38,11 @@ VariableSmmIsBufferOutsideSmmValid (
{
return SmmIsBufferOutsideSmmValid (Buffer, Length);
}
/**
- Notify the system that the SMM variable driver is ready
+ Notify the system that the SMM variable driver is ready.
**/
VOID
VariableNotifySmmReady (
VOID
)
@@ -59,11 +59,11 @@ VariableNotifySmmReady (
);
ASSERT_EFI_ERROR (Status);
}
/**
- Notify the system that the SMM variable write driver is ready
+ Notify the system that the SMM variable write driver is ready.
**/
VOID
VariableNotifySmmWriteReady (
VOID
)
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch 2/2] MdePkg: Fix coding style issues
2019-02-01 6:01 [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Dandan Bi
2019-02-01 6:01 ` [patch 1/2] MdeModulePkg: Fix coding style issues Dandan Bi
@ 2019-02-01 6:02 ` Dandan Bi
2019-02-01 10:27 ` [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Ard Biesheuvel
2 siblings, 0 replies; 6+ messages in thread
From: Dandan Bi @ 2019-02-01 6:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Ard Biesheuvel, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1478
Fix issues that reported by Edk2 coding style check tool(ECC) that:
in Comment, <@param SystemTable> does NOT consistent with parameter
name MmSystemTable.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Library/StandaloneMmDriverEntryPoint.h | 16 ++++++++--------
.../StandaloneMmDriverEntryPoint.c | 4 ++--
.../StandaloneMmServicesTableLib.c | 4 ++--
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h b/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
index d618998622..fbc75add73 100644
--- a/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
+++ b/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
@@ -34,12 +34,12 @@ extern CONST UINT32 _gMmRevision;
is an error status, then ProcessLibraryDestructorList() must be called.
The return value from ProcessModuleEntryPointList() is returned.
If _gMmRevision is not zero and MmSystemTable->Hdr.Revision is
less than _gMmRevision, then return EFI_INCOMPATIBLE_VERSION.
- @param ImageHandle The image handle of the Standalone MM Driver.
- @param SystemTable A pointer to the EFI System Table.
+ @param ImageHandle The image handle of the Standalone MM Driver.
+ @param MmSystemTable A pointer to the MM System Table.
@retval EFI_SUCCESS The Standalone MM Driver exited normally.
@retval EFI_INCOMPATIBLE_VERSION _gMmRevision is greater than
MmSystemTable->Hdr.Revision.
@retval Other Return value from
@@ -66,12 +66,12 @@ _ModuleEntryPoint (
tools and those build tools are responsible for collecting the set of library
instances, determine which ones have constructors, and calling the library
constructors in the proper order based upon each of the library instances own
dependencies.
- @param ImageHandle The image handle of the Standalone MM Driver.
- @param SystemTable A pointer to the MM System Table.
+ @param ImageHandle The image handle of the Standalone MM Driver.
+ @param MmSystemTable A pointer to the MM System Table.
**/
VOID
EFIAPI
ProcessLibraryConstructorList (
@@ -92,12 +92,12 @@ ProcessLibraryConstructorList (
This function is auto generated by build tools and those build tools are
responsible for collecting the set of library instances, determine which ones
have destructors, and calling the library destructors in the proper order
based upon each of the library instances own dependencies.
- @param ImageHandle The image handle of the Standalone MM Driver.
- @param SystemTable A pointer to the MM System Table.
+ @param ImageHandle The image handle of the Standalone MM Driver.
+ @param MmSystemTable A pointer to the MM System Table.
**/
VOID
EFIAPI
ProcessLibraryDestructorList (
@@ -113,12 +113,12 @@ ProcessLibraryDestructorList (
This function calls the set of module entry points.
This function is auto generated by build tools and those build tools are
responsible for collecting the module entry points and calling them in a
specified order.
- @param ImageHandle The image handle of the Standalone MM Driver.
- @param SystemTable A pointer to the EFI System Table.
+ @param ImageHandle The image handle of the Standalone MM Driver.
+ @param MmSystemTable A pointer to the MM System Table.
@retval EFI_SUCCESS The Standalone MM Driver executed normally.
@retval !EFI_SUCCESS The Standalone MM Driver failed to execute normally.
**/
EFI_STATUS
diff --git a/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.c b/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.c
index 4fb494d8cb..b665233142 100644
--- a/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.c
+++ b/MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.c
@@ -32,12 +32,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
is an error status, then ProcessLibraryDestructorList() must be called.
The return value from ProcessModuleEntryPointList() is returned.
If _gMmRevision is not zero and SystemTable->Hdr.Revision is
less than _gMmRevision, then return EFI_INCOMPATIBLE_VERSION.
- @param ImageHandle The image handle of the Standalone MM Driver.
- @param SystemTable A pointer to the EFI System Table.
+ @param ImageHandle The image handle of the Standalone MM Driver.
+ @param MmSystemTable A pointer to the MM System Table.
@retval EFI_SUCCESS The Standalone MM Driver exited normally.
@retval EFI_INCOMPATIBLE_VERSION _gMmRevision is greater than
MmSystemTable->Hdr.Revision.
@retval Other Return value from
diff --git a/MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.c b/MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.c
index b870f25fcf..de7c980c7b 100644
--- a/MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.c
+++ b/MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.c
@@ -20,12 +20,12 @@
EFI_MM_SYSTEM_TABLE *gMmst = NULL;
/**
The constructor function caches the pointer of the MM Services Table.
- @param ImageHandle The firmware allocated handle for the EFI image.
- @param SystemTable A pointer to the EFI System Table.
+ @param ImageHandle The firmware allocated handle for the EFI image.
+ @param MmSystemTable A pointer to the MM System Table.
@retval EFI_SUCCESS The constructor always returns EFI_SUCCESS.
**/
EFI_STATUS
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch 1/2] MdeModulePkg: Fix coding style issues
2019-02-01 6:01 ` [patch 1/2] MdeModulePkg: Fix coding style issues Dandan Bi
@ 2019-02-01 6:22 ` Wu, Hao A
0 siblings, 0 replies; 6+ messages in thread
From: Wu, Hao A @ 2019-02-01 6:22 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
> -----Original Message-----
> From: Bi, Dandan
> Sent: Friday, February 01, 2019 2:02 PM
> To: edk2-devel@lists.01.org
> Cc: Ard Biesheuvel; Wang, Jian J; Wu, Hao A
> Subject: [patch 1/2] MdeModulePkg: Fix coding style issues
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1479
>
> Fix issues that reported by Edk2 coding style check tool(ECC) that:
> Comment description should end with period '.'
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 4 ++--
> .../FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c | 2 +-
> .../FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c | 2 +-
> .../Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h | 4 ++--
> .../Universal/Variable/RuntimeDxe/VariableStandaloneMm.c | 6 +++---
> .../Universal/Variable/RuntimeDxe/VariableTraditionalMm.c | 4 ++--
> 6 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo
> mmon.h
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo
> mmon.h
> index 61293ca864..cf1aef7ca4 100644
> ---
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo
> mmon.h
> +++
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo
> mmon.h
> @@ -76,11 +76,11 @@ typedef struct {
> BOOLEAN Complete;
> UINT8 Data[1];
> } SMM_FTW_GET_LAST_WRITE_HEADER;
>
> /**
> - Shared entry point of the module
> + Shared entry point of the module.
>
> @retval EFI_SUCCESS The initialization finished successfully.
> @retval EFI_OUT_OF_RESOURCES Allocate memory error
> @retval EFI_INVALID_PARAMETER Workspace or Spare block does not exist
>
> @@ -107,11 +107,11 @@ FtwSmmIsBufferOutsideSmmValid (
> IN EFI_PHYSICAL_ADDRESS Buffer,
> IN UINT64 Length
> );
>
> /**
> - Notify the system that the SMM FTW driver is ready
> + Notify the system that the SMM FTW driver is ready.
> **/
> VOID
> FtwNotifySmmReady (
> VOID
> );
> diff --git
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal
> oneMm.c
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal
> oneMm.c
> index 8a4ea5b476..c2aa501465 100644
> ---
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal
> oneMm.c
> +++
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal
> oneMm.c
> @@ -63,11 +63,11 @@ FtwCalculateCrc32 (
> {
> return CalculateCrc32 (Buffer, Length);
> }
>
> /**
> - Notify the system that the SMM FTW driver is ready
> + Notify the system that the SMM FTW driver is ready.
> **/
> VOID
> FtwNotifySmmReady (
> VOID
> )
> diff --git
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi
> onalMm.c
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi
> onalMm.c
> index 0981c3c2a9..7c76e1f756 100644
> ---
> a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi
> onalMm.c
> +++
> b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi
> onalMm.c
> @@ -70,11 +70,11 @@ FtwCalculateCrc32 (
>
> return ReturnValue;
> }
>
> /**
> - Notify the system that the SMM FTW driver is ready
> + Notify the system that the SMM FTW driver is ready.
> **/
> VOID
> FtwNotifySmmReady (
> VOID
> )
> diff --git
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
> index 0a886558f4..9b294e6b36 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
> @@ -96,19 +96,19 @@ VOID
> VariableSpeculationBarrier (
> VOID
> );
>
> /**
> - Notify the system that the SMM variable driver is ready
> + Notify the system that the SMM variable driver is ready.
> **/
> VOID
> VariableNotifySmmReady (
> VOID
> );
>
> /**
> - Notify the system that the SMM variable write driver is ready
> + Notify the system that the SMM variable write driver is ready.
> **/
> VOID
> VariableNotifySmmWriteReady (
> VOID
> );
> diff --git
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
> index 1e87ccfb5d..2eed038054 100644
> ---
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
> +++
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c
> @@ -36,31 +36,31 @@ VariableSmmIsBufferOutsideSmmValid (
> {
> return TRUE;
> }
>
> /**
> - Notify the system that the SMM variable driver is ready
> + Notify the system that the SMM variable driver is ready.
> **/
> VOID
> VariableNotifySmmReady (
> VOID
> )
> {
> }
>
> /**
> - Notify the system that the SMM variable write driver is ready
> + Notify the system that the SMM variable write driver is ready.
> **/
> VOID
> VariableNotifySmmWriteReady (
> VOID
> )
> {
> }
>
> /**
> - Variable service MM driver entry point
> + Variable service MM driver entry point.
>
> @param[in] ImageHandle A handle for the image that is initializing this
> driver
> @param[in] MmSystemTable A pointer to the MM system table
>
> diff --git
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
> index 84f2d12b58..42e2c63c3a 100644
> ---
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
> +++
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c
> @@ -38,11 +38,11 @@ VariableSmmIsBufferOutsideSmmValid (
> {
> return SmmIsBufferOutsideSmmValid (Buffer, Length);
> }
>
> /**
> - Notify the system that the SMM variable driver is ready
> + Notify the system that the SMM variable driver is ready.
> **/
> VOID
> VariableNotifySmmReady (
> VOID
> )
> @@ -59,11 +59,11 @@ VariableNotifySmmReady (
> );
> ASSERT_EFI_ERROR (Status);
> }
>
> /**
> - Notify the system that the SMM variable write driver is ready
> + Notify the system that the SMM variable write driver is ready.
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> **/
> VOID
> VariableNotifySmmWriteReady (
> VOID
> )
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg
2019-02-01 6:01 [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Dandan Bi
2019-02-01 6:01 ` [patch 1/2] MdeModulePkg: Fix coding style issues Dandan Bi
2019-02-01 6:02 ` [patch 2/2] MdePkg: " Dandan Bi
@ 2019-02-01 10:27 ` Ard Biesheuvel
2019-02-02 13:38 ` Gao, Liming
2 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2019-02-01 10:27 UTC (permalink / raw)
To: Dandan Bi; +Cc: edk2-devel@lists.01.org, Liming Gao, Jian J Wang, Hao Wu
On Fri, 1 Feb 2019 at 07:02, Dandan Bi <dandan.bi@intel.com> wrote:
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Dandan Bi (2):
> MdeModulePkg: Fix coding style issues
> MdePkg: Fix coding style issues
>
> .../FaultTolerantWriteSmmCommon.h | 4 ++--
> .../FaultTolerantWriteStandaloneMm.c | 2 +-
> .../FaultTolerantWriteTraditionalMm.c | 2 +-
> .../Variable/RuntimeDxe/PrivilegePolymorphic.h | 4 ++--
> .../Variable/RuntimeDxe/VariableStandaloneMm.c | 6 +++---
> .../Variable/RuntimeDxe/VariableTraditionalMm.c | 4 ++--
> .../Library/StandaloneMmDriverEntryPoint.h | 16 ++++++++--------
> .../StandaloneMmDriverEntryPoint.c | 4 ++--
> .../StandaloneMmServicesTableLib.c | 4 ++--
> 9 files changed, 23 insertions(+), 23 deletions(-)
>
> --
> 2.18.0.windows.1
>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg
2019-02-01 10:27 ` [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Ard Biesheuvel
@ 2019-02-02 13:38 ` Gao, Liming
0 siblings, 0 replies; 6+ messages in thread
From: Gao, Liming @ 2019-02-02 13:38 UTC (permalink / raw)
To: Ard Biesheuvel, Bi, Dandan; +Cc: Wu, Hao A, edk2-devel@lists.01.org
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Friday, February 1, 2019 6:28 PM
> To: Bi, Dandan <dandan.bi@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2] [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg
>
> On Fri, 1 Feb 2019 at 07:02, Dandan Bi <dandan.bi@intel.com> wrote:
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Dandan Bi (2):
> > MdeModulePkg: Fix coding style issues
> > MdePkg: Fix coding style issues
> >
> > .../FaultTolerantWriteSmmCommon.h | 4 ++--
> > .../FaultTolerantWriteStandaloneMm.c | 2 +-
> > .../FaultTolerantWriteTraditionalMm.c | 2 +-
> > .../Variable/RuntimeDxe/PrivilegePolymorphic.h | 4 ++--
> > .../Variable/RuntimeDxe/VariableStandaloneMm.c | 6 +++---
> > .../Variable/RuntimeDxe/VariableTraditionalMm.c | 4 ++--
> > .../Library/StandaloneMmDriverEntryPoint.h | 16 ++++++++--------
> > .../StandaloneMmDriverEntryPoint.c | 4 ++--
> > .../StandaloneMmServicesTableLib.c | 4 ++--
> > 9 files changed, 23 insertions(+), 23 deletions(-)
> >
> > --
> > 2.18.0.windows.1
> >
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-02 13:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-01 6:01 [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Dandan Bi
2019-02-01 6:01 ` [patch 1/2] MdeModulePkg: Fix coding style issues Dandan Bi
2019-02-01 6:22 ` Wu, Hao A
2019-02-01 6:02 ` [patch 2/2] MdePkg: " Dandan Bi
2019-02-01 10:27 ` [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg Ard Biesheuvel
2019-02-02 13:38 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox