From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
"Kostya Porotchkin" <kostap@marvell.com>
Subject: Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node
Date: Fri, 7 Jun 2019 12:52:43 +0200 [thread overview]
Message-ID: <CAKv+Gu8zjb=XdqD-ZiqceFOydCkyhLc0SnxnrRPG22xA7QD4bQ@mail.gmail.com> (raw)
In-Reply-To: <1559692364-452-1-git-send-email-mw@semihalf.com>
On Wed, 5 Jun 2019 at 01:52, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Linux FWTS test of the ARM SBSA compliance suite
> fail on using unsupported _CID in UART node. Remove it.
>
It would be better to assign a MRVL _HID here, and use the HISI one as _CID.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 1 -
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 1 -
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> index 90b191b..d0cb52a 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> index 5c060a3..143368b 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index f7cffb9..117419c 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-06-07 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 23:52 [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node Marcin Wojtas
2019-06-05 0:05 ` Marcin Wojtas
2019-06-07 10:52 ` Ard Biesheuvel [this message]
2019-06-07 13:07 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8zjb=XdqD-ZiqceFOydCkyhLc0SnxnrRPG22xA7QD4bQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox