* [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node
@ 2019-06-04 23:52 Marcin Wojtas
2019-06-05 0:05 ` Marcin Wojtas
2019-06-07 10:52 ` Ard Biesheuvel
0 siblings, 2 replies; 4+ messages in thread
From: Marcin Wojtas @ 2019-06-04 23:52 UTC (permalink / raw)
To: devel; +Cc: leif.lindholm, ard.biesheuvel, mw, jsd, jaz, kostap
Linux FWTS test of the ARM SBSA compliance suite
fail on using unsupported _CID in UART node. Remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 1 -
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 1 -
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
3 files changed, 3 deletions(-)
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
index 90b191b..d0cb52a 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
@@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
Device (COM1)
{
Name (_HID, "HISI0031") // _HID: Hardware ID
- Name (_CID, "8250dw") // _CID: Compatible ID
Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
index 5c060a3..143368b 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
@@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
Device (COM1)
{
Name (_HID, "HISI0031") // _HID: Hardware ID
- Name (_CID, "8250dw") // _CID: Compatible ID
Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
index f7cffb9..117419c 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
@@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
Device (COM1)
{
Name (_HID, "HISI0031") // _HID: Hardware ID
- Name (_CID, "8250dw") // _CID: Compatible ID
Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node
2019-06-04 23:52 [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node Marcin Wojtas
@ 2019-06-05 0:05 ` Marcin Wojtas
2019-06-07 10:52 ` Ard Biesheuvel
1 sibling, 0 replies; 4+ messages in thread
From: Marcin Wojtas @ 2019-06-05 0:05 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Leif Lindholm, Ard Biesheuvel, jsd@semihalf.com,
Grzegorz Jaszczyk, Kostya Porotchkin
Hi,
Just to clarify - this is a single patch, wrongly numbered by mistake.
Best regards,
Marcin
śr., 5 cze 2019 o 01:52 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> Linux FWTS test of the ARM SBSA compliance suite
> fail on using unsupported _CID in UART node. Remove it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 1 -
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 1 -
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> index 90b191b..d0cb52a 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> index 5c060a3..143368b 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index f7cffb9..117419c 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node
2019-06-04 23:52 [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node Marcin Wojtas
2019-06-05 0:05 ` Marcin Wojtas
@ 2019-06-07 10:52 ` Ard Biesheuvel
2019-06-07 13:07 ` Marcin Wojtas
1 sibling, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2019-06-07 10:52 UTC (permalink / raw)
To: Marcin Wojtas
Cc: edk2-devel-groups-io, Leif Lindholm, Jan Dąbroś,
Grzegorz Jaszczyk, Kostya Porotchkin
On Wed, 5 Jun 2019 at 01:52, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Linux FWTS test of the ARM SBSA compliance suite
> fail on using unsupported _CID in UART node. Remove it.
>
It would be better to assign a MRVL _HID here, and use the HISI one as _CID.
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 1 -
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 1 -
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> index 90b191b..d0cb52a 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> index 5c060a3..143368b 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index f7cffb9..117419c 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> Device (COM1)
> {
> Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node
2019-06-07 10:52 ` Ard Biesheuvel
@ 2019-06-07 13:07 ` Marcin Wojtas
0 siblings, 0 replies; 4+ messages in thread
From: Marcin Wojtas @ 2019-06-07 13:07 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: edk2-devel-groups-io, Leif Lindholm, Jan Dąbroś,
Grzegorz Jaszczyk, Kostya Porotchkin
Hi Ard,
pt., 7 cze 2019 o 12:52 Ard Biesheuvel <ard.biesheuvel@linaro.org> napisał(a):
>
> On Wed, 5 Jun 2019 at 01:52, Marcin Wojtas <mw@semihalf.com> wrote:
> >
> > Linux FWTS test of the ARM SBSA compliance suite
> > fail on using unsupported _CID in UART node. Remove it.
> >
>
> It would be better to assign a MRVL _HID here, and use the HISI one as _CID.
Thanks for the hint - it works. Submitting v2 now.
Best regards,
Marcin
>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 1 -
> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 1 -
> > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> > index 90b191b..d0cb52a 100644
> > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> > @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
> > Device (COM1)
> > {
> > Name (_HID, "HISI0031") // _HID: Hardware ID
> > - Name (_CID, "8250dw") // _CID: Compatible ID
> > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> > {
> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> > index 5c060a3..143368b 100644
> > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> > @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> > Device (COM1)
> > {
> > Name (_HID, "HISI0031") // _HID: Hardware ID
> > - Name (_CID, "8250dw") // _CID: Compatible ID
> > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> > {
> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> > index f7cffb9..117419c 100644
> > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> > @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> > Device (COM1)
> > {
> > Name (_HID, "HISI0031") // _HID: Hardware ID
> > - Name (_CID, "8250dw") // _CID: Compatible ID
> > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> > {
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-07 13:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04 23:52 [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node Marcin Wojtas
2019-06-05 0:05 ` Marcin Wojtas
2019-06-07 10:52 ` Ard Biesheuvel
2019-06-07 13:07 ` Marcin Wojtas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox