From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=l6SeCU13;
 spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194])
 by groups.io with SMTP; Fri, 07 Jun 2019 03:52:54 -0700
Received: by mail-it1-f194.google.com with SMTP id a186so2032808itg.0
        for <devel@edk2.groups.io>; Fri, 07 Jun 2019 03:52:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=rHq2hXnVTgYWpczcjN3TwxDdBzO19PWD+9s4gkIPKKw=;
        b=l6SeCU13jED54VmqIZ5i6LNz8eB1U1YGehZJq6ireltwPkiBkmkPTsTFxW1NGZP5mT
         RvLWL15jwRFSSP1zBB1UsudjbYmRGLDp1Uu80v6El87FuW6e7d7HOAeJxsPjJmmyRsyF
         EvcRkHLWq6RLmOKVq5H7+qS5rLspAoaB6f0VsEwHzlQO30MuEWaupvtFDbtJMZq14D7C
         BS33cL1OtHspp6QrNypo5hK9lxoJBCa1KS/cydmX0+DQ7Mmeb/NxTXFcxzdKAOxw7efY
         QnY1L6WSaP9yXA2p5kWvBV5Wv62KHNJC73ZLALmNiPFGD43yQ6Fpbg6axpYOhhbqluUg
         ijSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=rHq2hXnVTgYWpczcjN3TwxDdBzO19PWD+9s4gkIPKKw=;
        b=b0ZgbxWseDZ1ec6ebndj5ZqCRRDMRGq5gx0Tqwrm6p+HEFXPhX+WAE5KV879SjfY2b
         fVECjtT2wCxp/puFd3CI+MGLIuyM2rhUNP/IjHseTaurFB00WLeFd3Utt9u5Yk8FsIpH
         jrLBGTfGnRvKsPN+KuNuFYVoDt3iODi9yaCiaayoISM/DWWtE1RDy37S7NaFuVxX+Rkj
         +cCRPzYexiaZxrXFjTdxAMlXyyHP/oF+ru/SCrhNa12d4CUhyNk2d5zIeyLZsfcOnjXd
         +CeAM0twASouegsuxcrkvVw99zcYd6TSq4AgkvxUQSF7koUe9DB/iuGauymcxVyKmxp+
         Fnew==
X-Gm-Message-State: APjAAAWvcS8Z+6/WfIhBQlLcj/6CuKM1YuKVeWyOLOI9vaxYBAI0jhrA
	fKAxCt+LIG7hBfXcVgSrLFjHEeOZFeLZDLRB9b2Rsg==
X-Google-Smtp-Source: APXvYqyrU1eGJv2/aHd3gpldhbEoSqAgQVrH/bMe+fhzm5UZd7NMSSZJ++WvWNNecyGjUF4M501JDfS4U9pPAkmPhY8=
X-Received: by 2002:a24:4f88:: with SMTP id c130mr3423717itb.104.1559904774282;
 Fri, 07 Jun 2019 03:52:54 -0700 (PDT)
MIME-Version: 1.0
References: <1559692364-452-1-git-send-email-mw@semihalf.com>
In-Reply-To: <1559692364-452-1-git-send-email-mw@semihalf.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 7 Jun 2019 12:52:43 +0200
Message-ID: <CAKv+Gu8zjb=XdqD-ZiqceFOydCkyhLc0SnxnrRPG22xA7QD4bQ@mail.gmail.com>
Subject: Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif.lindholm@linaro.org>, 
	=?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>, 
	Grzegorz Jaszczyk <jaz@semihalf.com>, Kostya Porotchkin <kostap@marvell.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 5 Jun 2019 at 01:52, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Linux FWTS test of the ARM SBSA compliance suite
> fail on using unsupported _CID in UART node. Remove it.
>

It would be better to assign a MRVL _HID here, and use the HISI one as _CID.

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl    | 1 -
>  Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl    | 1 -
>  Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
>  3 files changed, 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> index 90b191b..d0cb52a 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
>          Device (COM1)
>          {
>              Name (_HID, "HISI0031")                             // _HID: Hardware ID
> -            Name (_CID, "8250dw")                               // _CID: Compatible ID
>              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: Address
>              Name (_CRS, ResourceTemplate ()                     // _CRS: Current Resource Settings
>              {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> index 5c060a3..143368b 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
>          Device (COM1)
>          {
>              Name (_HID, "HISI0031")                             // _HID: Hardware ID
> -            Name (_CID, "8250dw")                               // _CID: Compatible ID
>              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: Address
>              Name (_CRS, ResourceTemplate ()                     // _CRS: Current Resource Settings
>              {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index f7cffb9..117419c 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
>          Device (COM1)
>          {
>              Name (_HID, "HISI0031")                             // _HID: Hardware ID
> -            Name (_CID, "8250dw")                               // _CID: Compatible ID
>              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: Address
>              Name (_CRS, ResourceTemplate ()                     // _CRS: Current Resource Settings
>              {
> --
> 2.7.4
>