From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 085CF1A1E0F for ; Mon, 26 Sep 2016 19:24:15 -0700 (PDT) Received: by mail-it0-x22a.google.com with SMTP id u134so29472268itb.1 for ; Mon, 26 Sep 2016 19:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vNdrZRBH79W2K/wZ3kaHnMhofoFwkkBkSduGOJYH49Y=; b=bTRhk33x1Pa180llqTy8tf4s9+wldzK8nzHSWcnekCaaIWiam4fG2YS0BQGTLxR4KU eE+RkWwOXKzhAzDhvEpH6g3bUnDD8JKWHb2SuiHS762bxbxWxNhs5msFd4gSaiFH5s6o qYr2UQkyIoOj9FdJF1mZb6c3R/CwzAn1Ms7x4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vNdrZRBH79W2K/wZ3kaHnMhofoFwkkBkSduGOJYH49Y=; b=M/d5ZfAubcE5g7A1xQ/QbfXkyLJjznHYpoN9nef4wxh1oHJfSK2Yo7zQAiqrup9SbB QOJpMRHee2em86jRW9Kdc6qmXXfCiS794f5738XxAuDXeojdAe6J6ufegS+Y/OsgPvFm XVQEzPYeMaAdl3JlqTLroFbRQxmjSdHPKlTYvWAxC3r2n9qcU7KYsBNo3bobzeD3Ip7f jmanL/8ZDq34LR7oj3IKm8va0FjyAdDHStm6gn/+MvK54TVR4GxkDQwyAKEwCwzVFzOT 3uU0Cs2HopmVs3P9bwewqflWhLizIV6J8flTZU7or4RhnlZGhdpYEh5q4xTEeZb9eSou jXVg== X-Gm-Message-State: AA6/9RlfB/qzmEEuDPLVfQb54KD6hNc7CaSUPajI0mgY7WU+0L245AiAf4/6zEKdBphaWBwGWqgT+QVuEUri792e X-Received: by 10.36.129.213 with SMTP id q204mr1288336itd.38.1474943054351; Mon, 26 Sep 2016 19:24:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 26 Sep 2016 19:24:13 -0700 (PDT) In-Reply-To: <20160927011552.20384-1-leif.lindholm@linaro.org> References: <20160927011552.20384-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Mon, 26 Sep 2016 19:24:13 -0700 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Feng Tian , Star Zeng , Andrew Fish , Michael D Kinney Subject: Re: [PATCH] MdeModulePkg: add ARM/AARCH64 requirements to .dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 02:24:15 -0000 Content-Type: text/plain; charset=UTF-8 On 26 September 2016 at 18:15, Leif Lindholm wrote: > Some LibraryClasses entries are missing to enable standalone builds > of MdeModulePkg components for ARM/AARCH64. Add those. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > > Tying back to the conversation in > https://lists.01.org/pipermail/edk2-devel/2016-August/000733.html > > If we are not going to refactor the DxeIpl code, would this be an > acceptable fix to enable standalone HelloWorld builds on ARM/AARCH64? > > BaseStackCheckLib is unrelated to the DxeIpl issue, but needed in > practice on ARM and in theory on AARCH64. > > MdeModulePkg/MdeModulePkg.dsc | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > index 05120c7..3eb55db 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -160,6 +160,9 @@ [LibraryClasses.common.UEFI_APPLICATION] > DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > + ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > + > # > # It is not possible to prevent ARM compiler calls to generic intrinsic functions. > # This library provides the instrinsic functions generated by a given compiler. > @@ -167,6 +170,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > + # > + # Since software stack checking may be heuristically enabled by the compiler > + # include BaseStackCheckLib unconditionally. > + # > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > + > [LibraryClasses.EBC] > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > -- > 2.9.3 >