From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 480A021959CB2 for ; Mon, 21 Jan 2019 05:08:04 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id l14so16307475ioj.5 for ; Mon, 21 Jan 2019 05:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sSj9hFMVHNLVf2uF/ydwQ/4DvXYOiLIkMP93eBSodmI=; b=apc0KDYdWoTRxtgjJyMjOvaIV1mG+zd3D69yr8EiC+cY77VeCqoTWVUf4RmAr68/LM zv3G2k+LMSzAApoR7QQVuXF3sf1fom/db52mYCnW689VoHI7tah5ksxzQqVOWCkHxmNH Gc49RY5vBIdzdAL52TqwZ2XlJ6Ds7WnZO8n1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sSj9hFMVHNLVf2uF/ydwQ/4DvXYOiLIkMP93eBSodmI=; b=VVvFB1w3BGEg314AgowIAJVH0bAdRx5Jz4pT76as6tHl3qrgzbqANLKBN/srTpzdTB HJOBRQ8PnMaRgs0mUdKJq9wCw+SxMZx82qWFq4bKlacSgIyzipb/8MUwEwnC8mTwMgi7 BchjQCwZAFLMCc0IH1qPdCf+64WEKNi9vsHgXr9aCrlMokPx6lrupIVwAnN/qkpbBbfm JhuzZMpzW+EE39/nKGS/LvIToZrvtCLCOWuDpXpAcHZyW70doR9cNSP08T+eXgta9/H2 1U2MXxaPxSc0nq05pAj1iJCyjoEiFjK6UX5aReyJKsHagy8qTdPRFj+fpdVU32P52bfl kTTg== X-Gm-Message-State: AJcUukfp5hOerlemT8jUfqQUOlNu9k3VMoXAvXenwVIWq+icyYAnrQfk zS+9/fDdJY4m+Kh4ytyDrnMxo0ZzgOvNLjjfQFmhEg== X-Google-Smtp-Source: ALg8bN5v5fm7eXWNoZ36hmAj7AcVq7zF4gfR7w4bYLxDT3dK/emXjCgMb1att9rh9ZLxM5qX2zD6tMLxqrMPnL1I+aM= X-Received: by 2002:a5e:c206:: with SMTP id v6mr17367847iop.60.1548076083417; Mon, 21 Jan 2019 05:08:03 -0800 (PST) MIME-Version: 1.0 References: <20190121130717.17636-1-leif.lindholm@linaro.org> In-Reply-To: <20190121130717.17636-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Mon, 21 Jan 2019 14:07:51 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Charles Garcia-Tobin Subject: Re: [PATCH] ArmPkg: delete unused ArmTrustZoneSmc.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 13:08:04 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 21 Jan 2019 at 14:07, Leif Lindholm wrote: > > ArmPkg/Include/IndustryStandard/ArmTrustZoneSmc.h contains definitions > contradicting the SMC Calling Convention (ARM DEN0028B). > > It also has no users in public trees. So delete before it can cause > damage. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > ArmPkg/Include/IndustryStandard/ArmTrustZoneSmc.h | 161 ---------------------- > 1 file changed, 161 deletions(-) > delete mode 100644 ArmPkg/Include/IndustryStandard/ArmTrustZoneSmc.h > > diff --git a/ArmPkg/Include/IndustryStandard/ArmTrustZoneSmc.h b/ArmPkg/Include/IndustryStandard/ArmTrustZoneSmc.h > deleted file mode 100644 > index 71b4327ebf..0000000000 > --- a/ArmPkg/Include/IndustryStandard/ArmTrustZoneSmc.h > +++ /dev/null > @@ -1,161 +0,0 @@ > -/** @file > -* > -* Copyright (c) 2012-2013, ARM Limited. All rights reserved. > -* > -* This program and the accompanying materials > -* are licensed and made available under the terms and conditions of the BSD License > -* which accompanies this distribution. The full text of the license may be found at > -* http://opensource.org/licenses/bsd-license.php > -* > -* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -* > -**/ > - > -#ifndef __ARM_TRUSTZONE_SMC_H__ > -#define __ARM_TRUSTZONE_SMC_H__ > - > -#define ARM_TRUSTZONE_UID_4LETTERID 0x1 > -#define ARM_TRUSTZONE_UID_MD5 0x2 > - > -#define ARM_TRUSTZONE_ARM_UID 0x40524d48 // "ARMH" > - > -#define IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,Region) (((UINTN)(Rx) >= (UINTN)ARM_TRUSTZONE_##Region##_SMC_ID_START) && ((UINTN)(Rx) <= (UINTN)ARM_TRUSTZONE_##Region##_SMC_ID_END)) > - > -#define IS_ARM_TRUSTZONE_DEPRECIATED_SMC(Rx) ((UINTN)(Rx) <= (UINTN)ARM_TRUSTZONE_DEPRECIATED_SMC_ID_END) > -#define IS_ARM_TRUSTZONE_TRUSTED_OS_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,TRUSTED_OS) > -#define IS_ARM_TRUSTZONE_ARM_FAST_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,ARM_FAST) > -#define IS_ARM_TRUSTZONE_SIP_FAST_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,SIP_FAST) > -#define IS_ARM_TRUSTZONE_ODM_FAST_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,ODM_FAST) > -#define IS_ARM_TRUSTZONE_OEM_FAST_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,OEM_FAST) > -#define IS_ARM_TRUSTZONE_TRUSTED_USER_FAST_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,TRUSTED_USER_FAST) > -#define IS_ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC(Rx,TRUSTED_OS_FAST) > - > -#define IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_PRESENCE(Rx,Region) ((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_PRESENCE) > -#define IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID(Rx,Region) (((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_UID) || \ > - ((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_UID+1) || \ > - ((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_UID+2) || \ > - ((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_UID+3) || \ > - ((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_UID+4)) > -#define IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION(Rx,Region) (((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_REVISION) || \ > - ((Rx) == ARM_TRUSTZONE_##Region##_SMC_ID_REVISION+1)) > -#define IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC(Rx,Region) (((Rx) >= ARM_TRUSTZONE_##Region##_SMC_ID_RPC_START) && \ > - ((Rx) <= ARM_TRUSTZONE_##Region##_SMC_ID_RPC_END)) > - > -#define ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID_INDEX(Rx,Region) ((Rx) - ARM_TRUSTZONE_##Region##_SMC_ID_UID) > -#define ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION_INDEX(Rx,Region) ((Rx) - ARM_TRUSTZONE_##Region##_SMC_ID_REVISION) > -#define ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,Region) ((Rx) - ARM_TRUSTZONE_##Region##_SMC_ID_RPC_START) > - > -#define ARM_TRUSTZONE_TRUSTED_OS_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,TRUSTED_OS) > - > -#define IS_ARM_TRUSTZONE_ARM_FAST_SMC_ID_PRESENCE(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_PRESENCE(Rx,ARM_FAST) > -#define IS_ARM_TRUSTZONE_ARM_FAST_SMC_ID_UID(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID(Rx,ARM_FAST) > -#define IS_ARM_TRUSTZONE_ARM_FAST_SMC_ID_REVISION(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION(Rx,ARM_FAST) > -#define IS_ARM_TRUSTZONE_ARM_FAST_SMC_ID_RPC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC(Rx,ARM_FAST) > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_UID_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID_INDEX(Rx,ARM_FAST) > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_REVISION_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION_INDEX(Rx,ARM_FAST) > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,ARM_FAST) > - > -#define IS_ARM_TRUSTZONE_ODM_FAST_SMC_ID_PRESENCE(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_PRESENCE(Rx,ODM_FAST) > -#define IS_ARM_TRUSTZONE_ODM_FAST_SMC_ID_UID(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID(Rx,ODM_FAST) > -#define IS_ARM_TRUSTZONE_ODM_FAST_SMC_ID_REVISION(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION(Rx,ODM_FAST) > -#define IS_ARM_TRUSTZONE_ODM_FAST_SMC_ID_RPC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC(Rx,ODM_FAST) > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_UID_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID_INDEX(Rx,ODM_FAST) > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_REVISION_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION_INDEX(Rx,ODM_FAST) > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,ODM_FAST) > - > -#define IS_ARM_TRUSTZONE_OEM_FAST_SMC_ID_PRESENCE(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_PRESENCE(Rx,OEM_FAST) > -#define IS_ARM_TRUSTZONE_OEM_FAST_SMC_ID_UID(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID(Rx,OEM_FAST) > -#define IS_ARM_TRUSTZONE_OEM_FAST_SMC_ID_REVISION(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION(Rx,OEM_FAST) > -#define IS_ARM_TRUSTZONE_OEM_FAST_SMC_ID_RPC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC(Rx,OEM_FAST) > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_UID_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID_INDEX(Rx,OEM_FAST) > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_REVISION_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION_INDEX(Rx,OEM_FAST) > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,OEM_FAST) > - > -#define IS_ARM_TRUSTZONE_SIP_FAST_SMC_ID_PRESENCE(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_PRESENCE(Rx,SIP_FAST) > -#define IS_ARM_TRUSTZONE_SIP_FAST_SMC_ID_UID(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID(Rx,SIP_FAST) > -#define IS_ARM_TRUSTZONE_SIP_FAST_SMC_ID_REVISION(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION(Rx,SIP_FAST) > -#define IS_ARM_TRUSTZONE_SIP_FAST_SMC_ID_RPC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC(Rx,SIP_FAST) > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_UID_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID_INDEX(Rx,SIP_FAST) > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_REVISION_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION_INDEX(Rx,SIP_FAST) > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,SIP_FAST) > - > -#define ARM_TRUSTZONE_TRUSTED_USER_FAST_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,TRUSTED_USER_FAST) > - > -#define IS_ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_PRESENCE(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_PRESENCE(Rx,TRUSTED_OS_FAST) > -#define IS_ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_UID(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID(Rx,TRUSTED_OS_FAST) > -#define IS_ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_REVISION(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION(Rx,TRUSTED_OS_FAST) > -#define IS_ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_RPC(Rx) IS_ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC(Rx,TRUSTED_OS_FAST) > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_UID_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_UID_INDEX(Rx,TRUSTED_OS_FAST) > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_REVISION_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_REVISION_INDEX(Rx,TRUSTED_OS_FAST) > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_RPC_INDEX(Rx) ARM_TRUSTZONE_SUPPORTED_SMC_ID_RPC_INDEX(Rx,TRUSTED_OS_FAST) > - > - > -#define ARM_TRUSTZONE_DEPRECIATED_SMC_ID_START 0x00000000 > -#define ARM_TRUSTZONE_DEPRECIATED_SMC_ID_END 0x01FFFFFF > - > - > -#define ARM_TRUSTZONE_TRUSTED_OS_SMC_ID_START 0x02000000 > -#define ARM_TRUSTZONE_TRUSTED_OS_SMC_ID_END 0x1FFFFFFF > - > -#define ARM_TRUSTZONE_TRUSTED_OS_SMC_ID_RPC_START 0x02000000 > -#define ARM_TRUSTZONE_TRUSTED_OS_SMC_ID_RPC_END 0x1FFFFFFF > - > - > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_START 0x80000000 > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_END 0x80FFFFFF > - > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_RPC_START 0x80000000 > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_RPC_END 0x80FFFEFF > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_PRESENCE 0x80FFFF00 > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_UID 0x80FFFF10 > -#define ARM_TRUSTZONE_ARM_FAST_SMC_ID_REVISION 0x80FFFF20 > - > - > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_START 0x81000000 > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_END 0x81FFFFFF > - > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_RPC_START 0x81000000 > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_RPC_END 0x81FFFEFF > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_PRESENCE 0x81FFFF00 > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_UID 0x81FFFF10 > -#define ARM_TRUSTZONE_SIP_FAST_SMC_ID_REVISION 0x81FFFF20 > - > - > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_START 0x82000000 > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_END 0x82FFFFFF > - > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_RPC_START 0x82000000 > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_RPC_END 0x82FFFEFF > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_PRESENCE 0x82FFFF00 > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_UID 0x82FFFF10 > -#define ARM_TRUSTZONE_ODM_FAST_SMC_ID_REVISION 0x82FFFF20 > - > - > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_START 0x83000000 > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_END 0x83FFFFFF > - > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_RPC_START 0x83000000 > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_RPC_END 0x83FFFEFF > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_PRESENCE 0x83FFFF00 > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_UID 0x83FFFF10 > -#define ARM_TRUSTZONE_OEM_FAST_SMC_ID_REVISION 0x83FFFF20 > - > - > -#define ARM_TRUSTZONE_TRUSTED_USER_FAST_SMC_ID_START 0xF0000000 > -#define ARM_TRUSTZONE_TRUSTED_USER_FAST_SMC_ID_END 0xF1FFFFFF > - > -#define ARM_TRUSTZONE_TRUSTED_USER_FAST_SMC_ID_RPC_START 0xF0000000 > -#define ARM_TRUSTZONE_TRUSTED_USER_FAST_SMC_ID_RPC_END 0xF1FFFEFF > - > - > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_START 0xF2000000 > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_END 0xFFFFFFFF > - > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_RPC_START 0xF2000000 > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_RPC_END 0xFFFFFEFF > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_PRESENCE 0xF2FFFF00 > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_UID 0xF2FFFF10 > -#define ARM_TRUSTZONE_TRUSTED_OS_FAST_SMC_ID_REVISION 0xF2FFFF20 > - > -#endif > -- > 2.11.0 >