public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Andrei E. Warkentin" <andrey.warkentin@gmail.com>,
	samer.el-haj-mahmoud@arm.com
Subject: Re: [edk2-platforms][PATCH 0/5] Add initial Raspberry Pi 4 platform
Date: Wed, 11 Dec 2019 17:21:19 +0100	[thread overview]
Message-ID: <CAKv+Gu9+8w8kQobGV3Uh_9t7F2YwKc_oxW5jYz1Aye+NGYLsLA@mail.gmail.com> (raw)
In-Reply-To: <20191211112552.15900-1-pete@akeo.ie>

On Wed, 11 Dec 2019 at 12:26, Pete Batard <pete@akeo.ie> wrote:
>
> This series adds basic support to build the Raspberry Pi 4 platform.
>
> It requires the earlier series, that add binary files for the platform,
> to have been applied to edk2-non-osi.
>
> For the introduction of the platform, USB support is not yet enabled
> which means that user I/O has to be carried out through serial.
>
> The first two patches of the series are fixes for the common RPi
> platform that will become relevant when we introduce support for
> PCIe/xHCI.
>
> The second two patch deal with the specific ACPI changes for the
> Pi 4 platform. To make these clearer, an intermediate patch, that
> simply enacts a straight unaltered copy of the Pi 3 ACPI files is
> added, so that the changes we apply can be made obvious. We also
> use this opportunity to switch the source of some tables (GTDT,
> MADT) to proper aslc.
>
> Finally, the last patch in this series adds the platform files
> along with a Readme detailing the installation requirements and
> current state of the platform.
>
> Andrei Warkentin (2):
>   Platform/RPi4: Update ACPI tables for the new platform
>   Platform/RPi4: Add base platform files
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Ard Biesheuvel (2):
>   Platform/RPi: Fix overlap of SoC registers and RAM
>   Platform/RPi: Don't describe MMIO regions as memory
>


> Samer El-Haj-Mahmoud (1):
>   Platform/RPi4: Add initial ACPI tables
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Pushed as c5a2065ee8c2..065a5597f36a

Thanks!



>  Platform/RaspberryPi/Include/Library/RPiMem.h                    |   7 +-
>  Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c |  10 +
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c        |  42 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h                |  92 +++
>  Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf              |  49 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc                   | 327 ++++++++++
>  Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc                   |  28 +
>  Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl                    | 505 ++++++++++++++++
>  Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc                   |  46 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc                   |  56 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc                   |  64 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl                     |  90 +++
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.c                       |  79 +++
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.h                       | 121 ++++
>  Platform/RaspberryPi/RPi4/AcpiTables/Rhpx.asl                    | 195 ++++++
>  Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl                    |  99 +++
>  Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl                    |  48 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl                    | 152 +++++
>  Platform/RaspberryPi/RPi4/RPi4.dsc                               | 637 ++++++++++++++++++++
>  Platform/RaspberryPi/RPi4/RPi4.fdf                               | 432 +++++++++++++
>  Platform/RaspberryPi/RPi4/Readme.md                              | 110 ++++
>  21 files changed, 3170 insertions(+), 19 deletions(-)
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Pep.c
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Pep.h
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Rhpx.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/RPi4.dsc
>  create mode 100644 Platform/RaspberryPi/RPi4/RPi4.fdf
>  create mode 100644 Platform/RaspberryPi/RPi4/Readme.md
>
> --
> 2.21.0.windows.1
>

      parent reply	other threads:[~2019-12-11 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 11:25 [edk2-platforms][PATCH 0/5] Add initial Raspberry Pi 4 platform Pete Batard
2019-12-11 11:25 ` [edk2-platforms][PATCH 1/5] Platform/RPi: Fix overlap of SoC registers and RAM Pete Batard
2019-12-11 12:21   ` Philippe Mathieu-Daudé
2019-12-11 12:39     ` Pete Batard
2019-12-11 11:25 ` [edk2-platforms][PATCH 2/5] Platform/RPi: Don't describe MMIO regions as memory Pete Batard
2019-12-11 12:22   ` Philippe Mathieu-Daudé
2019-12-11 11:25 ` [edk2-platforms][PATCH 3/5] Platform/RPi4: Add initial ACPI tables Pete Batard
2019-12-11 11:25 ` [edk2-platforms][PATCH 4/5] Platform/RPi4: Update ACPI tables for the new platform Pete Batard
2019-12-11 11:25 ` [edk2-platforms][PATCH 5/5] Platform/RPi4: Add base platform files Pete Batard
2019-12-11 16:21 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9+8w8kQobGV3Uh_9t7F2YwKc_oxW5jYz1Aye+NGYLsLA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox