From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.5905.1576081292848213738 for ; Wed, 11 Dec 2019 08:21:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=cgRzLbRr; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id z7so24581777wrl.13 for ; Wed, 11 Dec 2019 08:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H+S9SFCTku6sarljBLGYAFTKaAtV3B8cHEhacUujvHM=; b=cgRzLbRrLU4NLyGsoEnynJ4/+x3K7AzLx/IkCa+Gsi+GRSsy4yZTY0xMeum9BIniyZ YzEFNINk/tAL4DL4eYAo5d1VLWaBhwW1xZWpGqnj0mHYu5Sf+YqVKEnFYrJswnIDdU4U d4kU8wcG5SNHHvrHkv0RukwxF3MmqVJ8s8yyxnGyXNJCedQTJibxTJ3G1uD+cLa1RLFw tZnU12zQwxjC15FY/M3LRu1DJDrJoJ42BSZMCgpChggusswGMHbk9Wf62Z9yoPT2EwzW h4D6Xs0hzyDHlUfnoKjPxps6Io0AbOW69NH4SO5W9D0cqfkProDTrenzm9x7s3VkHh8B cwSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H+S9SFCTku6sarljBLGYAFTKaAtV3B8cHEhacUujvHM=; b=d1c+j0Y8OSqasDUrRuUILguEc+ySZ9HJcQq3iTk+IYfccUUvyEScWzlaGT8WWv1F7z PCFXrB2v+Ehm7/ad1qI9cmO0jPkbZ+Z0BhXr8tDGdImVIegl8jRz1eKP8/1oQsFw69nY uZLeUA4ttxImiwfTfF3FDON7MbgpyunEajfeDFjyJ5ll4+L6DoO9aRFC2T0wXKaFFNZW RWmR/kf3jlmsfKdqhE+EHfDLLS436G6KmSmVWLUbECI4oiJhIUdQ20/y0nozHaqEDilG FJlpgXKR+7syax6JDjMjpJeUMWkok1HKgeUz8UCj5aGWBZpvJTdroL5/TO7C/vD8RCSr Dvog== X-Gm-Message-State: APjAAAVRVNcHz3BEOmi+3As+2FPF7FzYdOScW6GIPSNkkXzjrjcylHqf O6jL48l2n17Pw5vKre3j0b2XvaadDWTDaep0ncvbpg== X-Google-Smtp-Source: APXvYqzeboq0XYEdDkSpKCuw5OWjjmsKpczXgE4fd6rjy8GOfdy63YuakAqr2GZ1WJXEzaELVSSb98Wrj49erBvRDsk= X-Received: by 2002:a5d:5345:: with SMTP id t5mr736512wrv.0.1576081291043; Wed, 11 Dec 2019 08:21:31 -0800 (PST) MIME-Version: 1.0 References: <20191211112552.15900-1-pete@akeo.ie> In-Reply-To: <20191211112552.15900-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Wed, 11 Dec 2019 17:21:19 +0100 Message-ID: Subject: Re: [edk2-platforms][PATCH 0/5] Add initial Raspberry Pi 4 platform To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , "Andrei E. Warkentin" , samer.el-haj-mahmoud@arm.com Content-Type: text/plain; charset="UTF-8" On Wed, 11 Dec 2019 at 12:26, Pete Batard wrote: > > This series adds basic support to build the Raspberry Pi 4 platform. > > It requires the earlier series, that add binary files for the platform, > to have been applied to edk2-non-osi. > > For the introduction of the platform, USB support is not yet enabled > which means that user I/O has to be carried out through serial. > > The first two patches of the series are fixes for the common RPi > platform that will become relevant when we introduce support for > PCIe/xHCI. > > The second two patch deal with the specific ACPI changes for the > Pi 4 platform. To make these clearer, an intermediate patch, that > simply enacts a straight unaltered copy of the Pi 3 ACPI files is > added, so that the changes we apply can be made obvious. We also > use this opportunity to switch the source of some tables (GTDT, > MADT) to proper aslc. > > Finally, the last patch in this series adds the platform files > along with a Readme detailing the installation requirements and > current state of the platform. > > Andrei Warkentin (2): > Platform/RPi4: Update ACPI tables for the new platform > Platform/RPi4: Add base platform files > Reviewed-by: Ard Biesheuvel > Ard Biesheuvel (2): > Platform/RPi: Fix overlap of SoC registers and RAM > Platform/RPi: Don't describe MMIO regions as memory > > Samer El-Haj-Mahmoud (1): > Platform/RPi4: Add initial ACPI tables > Reviewed-by: Ard Biesheuvel Pushed as c5a2065ee8c2..065a5597f36a Thanks! > Platform/RaspberryPi/Include/Library/RPiMem.h | 7 +- > Platform/RaspberryPi/Library/MemoryInitPeiLib/MemoryInitPeiLib.c | 10 + > Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 42 +- > Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 92 +++ > Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 49 ++ > Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 327 ++++++++++ > Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc | 28 + > Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 505 ++++++++++++++++ > Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc | 46 ++ > Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc | 56 ++ > Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc | 64 ++ > Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl | 90 +++ > Platform/RaspberryPi/RPi4/AcpiTables/Pep.c | 79 +++ > Platform/RaspberryPi/RPi4/AcpiTables/Pep.h | 121 ++++ > Platform/RaspberryPi/RPi4/AcpiTables/Rhpx.asl | 195 ++++++ > Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl | 99 +++ > Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl | 48 ++ > Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl | 152 +++++ > Platform/RaspberryPi/RPi4/RPi4.dsc | 637 ++++++++++++++++++++ > Platform/RaspberryPi/RPi4/RPi4.fdf | 432 +++++++++++++ > Platform/RaspberryPi/RPi4/Readme.md | 110 ++++ > 21 files changed, 3170 insertions(+), 19 deletions(-) > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Pep.c > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Pep.h > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Rhpx.asl > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Sdhc.asl > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl > create mode 100644 Platform/RaspberryPi/RPi4/RPi4.dsc > create mode 100644 Platform/RaspberryPi/RPi4/RPi4.fdf > create mode 100644 Platform/RaspberryPi/RPi4/Readme.md > > -- > 2.21.0.windows.1 >