From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 584681A1DF4 for ; Tue, 2 Aug 2016 08:02:58 -0700 (PDT) Received: by mail-io0-x231.google.com with SMTP id m101so214999023ioi.2 for ; Tue, 02 Aug 2016 08:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=17ywUkz++mhfmSlfheUn+whcC1Ru8Dp/D657snan6MU=; b=FmlKNHGr2EQgF3120v11I5+naH325o6fA4QAgdS+50UX9dVrKNRbUpuaEAuaUGt6Jl +YyFytQUWRUzebyPQ5OMhTpFxIAdGDRA+sUMMoolwS6CI19PpQYDzdpUAqWXEkvVU1f5 jcIbKPDt5pM24ybCrXR+pqXPC1Q5pKC8kDAN0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=17ywUkz++mhfmSlfheUn+whcC1Ru8Dp/D657snan6MU=; b=Eue5wjGyD2SVUos9WCFLusv9NVNq0Ypm0jqtvpSwdcbI14ZDa0JpKcllpYUQQ3U4a7 izfNn6lXYRhCrs/saWxk63XrUZh0wsPtJVZfHo5dZNKsbqkuQy5Bb0Gds7nSCcfE6g1B J08gzWlj238HReOFsZs5ItD4y6Crb8HTpZAfDJNKITFus0yHvgDD2ZF35ZeebO28qmxG AI2YhwTvhZVFzWe2eZohwz6yHqaFeEeyUdse9JV97PkxSWHPzeXaNlxFuPFs1GeMNmo/ rlJD2XHEuOAdXil/1hnoHlc9YxpP7mzockWe0pvkTfEXfyhyr82VKa4rVVgXGUGKig7Z xbwQ== X-Gm-Message-State: AEkoouuPYooTsnRnm9OseC0uoF1X6QvwkVFsFyWayXav9/+7VRJ2LLxPfpTb+eetQ2Wb8MrrqdAwg51znGJm+im3 X-Received: by 10.107.135.22 with SMTP id j22mr71061252iod.56.1470150177449; Tue, 02 Aug 2016 08:02:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Tue, 2 Aug 2016 08:02:57 -0700 (PDT) In-Reply-To: <20160802150156.GW31760@bivouac.eciton.net> References: <1470148772-15712-1-git-send-email-ard.biesheuvel@linaro.org> <1470148772-15712-2-git-send-email-ard.biesheuvel@linaro.org> <20160802150156.GW31760@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 2 Aug 2016 17:02:57 +0200 Message-ID: To: Leif Lindholm Cc: "Zhu, Yonghong" , "Gao, Liming" , Jordan Justen , edk2-devel-01 , Michael Zimmermann Subject: Re: [PATCH 1/3] BaseTools GCC: move -c compiler flag to build rules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2016 15:02:58 -0000 Content-Type: text/plain; charset=UTF-8 On 2 August 2016 at 17:01, Leif Lindholm wrote: > On Tue, Aug 02, 2016 at 04:39:30PM +0200, Ard Biesheuvel wrote: >> In order to be able to share the compiler flags with the linker (which >> is required for LTO since it involves the linker doing code generation >> based on the LTO bytecode), move the -c GCC argument to the build rules, >> and drop it from the GCC CC_FLAGS definitions in tools_def. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> BaseTools/Conf/build_rule.template | 16 +++++++++------- >> BaseTools/Conf/tools_def.template | 10 +++++----- >> 2 files changed, 14 insertions(+), 12 deletions(-) >> >> diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template >> index 9adf3918e42e..7d9f8ca075c2 100644 >> --- a/BaseTools/Conf/build_rule.template >> +++ b/BaseTools/Conf/build_rule.template >> @@ -130,7 +130,10 @@ >> >> "$(CC)" /Fo${dst} $(CC_FLAGS) $(INC) ${src} >> >> - >> + >> + "$(CC)" $(CC_FLAGS) -c -o ${dst} $(INC) ${src} >> + >> + > > Apart from the slightly larger patch set, is there any reason not to > split out the RVCT handling here and fix up tools_def.template for it > too? > In what sense do we need to fix up tools_def for RVCT?