From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 99A912118F345 for ; Mon, 26 Nov 2018 09:02:24 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id h193so28836488ita.5 for ; Mon, 26 Nov 2018 09:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=doFgGKkJxZLbjfEH6wwdt8yQQGT4bsII/CqMLz9DTOQ=; b=ZXb336eLkmquXqeSxor3LC/s4rJuvYls/Zoz2r7IhB+y46qvSd0bVOJxS9SIz1pJ/S hGga8Aq543ShV2uGEfH0TbkR+ACHVL1ynrzj+F4Re8gSXPQeNCsCKnIfDCSTsF4dGV/X zNKFLDd7wgS3ssjCuVKozBuWYI5PIcCyd7dJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=doFgGKkJxZLbjfEH6wwdt8yQQGT4bsII/CqMLz9DTOQ=; b=QelJjuZRx6Xi3Mu1Un2jmIVT4UfZ8PqoXLpzsqGveL0FJ+zfpfnOfSNisLk5lZ5oZt 0xhEC+jhREYsXu3kcl841e7j9Iwu+FC9Y+KnDJNusNy0vH4DsvHPlbdrCu3ZPbXl9XBN wlR/I5G/BpAYFHOUeIPdS/AqKPpjoVkehq63OqZLi3rmUGKcsNDFjauVfqU/sNwVyJP2 y9WUovcTZfrncG0aQg7AAEW7S59jJxB17Si2GXcXy23Opq/jZbLwVdZuMmTzNJ9NQJqF 3CbX1qqgvQ9gAT2z0RolvOubDrMu6lLZg1kOZHXzg+tZgKjuDz74B0ZR1lfIW7rjwAMG NFSQ== X-Gm-Message-State: AGRZ1gI1VzsWD8YhAdqMgtL31yruLsXfNaTswGcdR4SNKUDraUMb/1V+ l6rULmkNpZQhzqV5jcGfDC38UBtTjheL0qVtuDrfdD6F X-Google-Smtp-Source: AFSGD/X7oA39hADd5g5eCHktAGi/8ahz7zjUnQvF9Xw8JKj/xb+RJjplFLuZurmwasxNOj6vu9tC/Ndd5Ki1e58vaPc= X-Received: by 2002:a24:edc4:: with SMTP id r187mr26121093ith.158.1543251743515; Mon, 26 Nov 2018 09:02:23 -0800 (PST) MIME-Version: 1.0 References: <20181121115828.3026-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Mon, 26 Nov 2018 18:02:12 +0100 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Hongbo Zhang , Nariman Poushin , Thomas Panakamattam Abraham Subject: Re: [PATCH v2 0/5] ArmPlatformPkg, ArmVirtPkg: discover NOR flash banks from DTB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 17:02:24 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 26 Nov 2018 at 18:00, Ard Biesheuvel wrote: > > On Wed, 21 Nov 2018 at 12:58, Ard Biesheuvel wrote: > > > > This series fixes an issue reported by Hongbo and Philippe, where > > ArmVirtQemuKernel will crash on an attempt to access flash bank #0, > > which is secure-only when running QEMU with support for EL3. > > > > So let's switch to discovering the NOR flash banks from the device tree > > instead. This requires some preparatory changes in the NOR flash driver > > to avoid having to invent GUIDs on the fly. > > > > Changes since v1: > > - split ArmPlatformPkg for clarity > > - move DT node status check into FdtClientDxe where it belongs > > - use correct UINT32* type for DT property values, and be pedantic about > > their potential misalignment when casting to UINT64* > > - add patch to remove the 'Guid' member from NOR_FLASH_DESCRIPTION > > - add some acks > > > > Ard Biesheuvel (5): > > ArmPlatformPkg/NorFlashDxe: prepare for devicepath format change > > ArmPlatformPkg/NorFlashDxe: use one GUID plus index to identify flash > > banks > > ArmVirtPkg/FdtClientDxe: take DT node 'status' properties into account > > ArmVirtPkg/NorFlashQemuLib: discover NOR flash banks dynamically > > ArmPlatformPkg/NorFlashPlatformLib: remove unused Guid member from > > struct > > > > .../Drivers/NorFlashDxe/NorFlashDxe.c | 15 ++-- > > .../Drivers/NorFlashDxe/NorFlashDxe.h | 3 + > > .../Include/Library/NorFlashPlatformLib.h | 1 - > > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 38 +++++++-- > > .../Library/NorFlashQemuLib/NorFlashQemuLib.c | 78 ++++++++++++++----- > > .../NorFlashQemuLib/NorFlashQemuLib.inf | 12 +++ > > 6 files changed, 114 insertions(+), 33 deletions(-) > > > > Pushed as 1ec194b21c0e..72e514c90730 > > Thanks all Forgot to add: minus the 5th patch, which I will push once the dependent changes in edk2-platforms have been pushed.