From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D35D211D9175 for ; Fri, 15 Mar 2019 04:10:08 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id v4so6833654ioj.5 for ; Fri, 15 Mar 2019 04:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YFauz9WNypgvCY6poQqfpasK9LBqIm/JQu4xl0cgvPw=; b=SfWXq+V54/6jbEn5ji/Kq6+2XdTZ1QrO1LVonN2w9jGug3ppQSX/iYXAw7Th6FbO4B /FH0g0U9MNLodgBvLiai9SGeEQSn0AtEzewmkU+8SxDVp5/on+jcAANNpuBjCyi2/gti wZfxY9LDbjSAf9KrMfsi8V8D86XCPI4l/5OPpqWvhu1NhculYj0bbU0djybydpZ8gD5K ZLycF0Rxsng63s8o8g2sVw0Zesj3JIV13ErFCGTFxGnEDGDGrXUW7B7ozlgEHZvGNhIy FLcqz/PuHUMPHL7gMwWrf/1t7AaimDNpuq3mHVHfnPkxZ9y42lD/fkxdkG85LVhahl5w pxfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YFauz9WNypgvCY6poQqfpasK9LBqIm/JQu4xl0cgvPw=; b=e7hLItvHcvY4Eq1CHQHsm3ZPQN2n3zqPzzlWYdRNWVTKLbD/8JT5oh7+G0USSTHr5d ZVxeZNKXa1ArNC+IpjBLnruLDlj0EKkL8jmfzz6S8WFbM/TST6OozzWNLrx1Id7ab7Cs BwDxgEW29YvdIyhbj0Z+0BrXJbFvF6dCDLWuVaCtf1bQZ1h54t9J/kmkLb4si/OG7cxy veUuHg/r2ow41aNug0BfodZ2uFJkNLd4tLgz/m0G9H59zSVZFmXI2aI/PoRJ3TtwJS8t v1N2RTKInNsAOOCVDcRmjMCESC1wW7bT1pdHuF1oFZWk2U6sNgvLLakVhFca05nEVQQi F0GA== X-Gm-Message-State: APjAAAUfArGNAOibgOvglGMgnYchoa+BbEym5q/XIWezduFxe1j7EBKx ruViPa/Y/FGWqb+PNuxKi34TnXJxS8zUhL0jVs5R2A== X-Google-Smtp-Source: APXvYqwH95u2F/G3M0uCMnmWJ21xUZaoTfAM5Sx4SX9yU+rDJl41EHMpdRFuvUWRUfwGXIQqySYrBlgvtjEUWIdOZ1U= X-Received: by 2002:a5e:8418:: with SMTP id h24mr1756933ioj.170.1552648207403; Fri, 15 Mar 2019 04:10:07 -0700 (PDT) MIME-Version: 1.0 References: <20190315071603.16936-1-hao.a.wu@intel.com> In-Reply-To: <20190315071603.16936-1-hao.a.wu@intel.com> From: Ard Biesheuvel Date: Fri, 15 Mar 2019 12:09:56 +0100 Message-ID: To: Hao Wu Cc: "edk2-devel@lists.01.org" , Jordan Justen , Laszlo Ersek , Ray Ni Subject: Re: [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 11:10:08 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 15 Mar 2019 at 08:16, Hao Wu wrote: > > This series will update the OVMF to stop using the ISA drivers within > IntelFrameworkModulePkg. > > As the replacement, a new OVMF Super I/O bus driver has been add which > will install the Super I/O protocol for ISA serial and PS2 keyboard > devices. By doing so, these devices can be managed by: > > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > respectively. > Just a couple of notes from my side - I'm sure Laszlo will have a much longer list :-) - Dropping the floppy driver is fine with me. - What is OVMF specific about this driver? Is it only the hardcoded list of COM1/COM2/PS2 keyboard? If so, should we split this into a driver and a library class, where the driver lives in MdeModulePkg, and the library is implemented in the context of OVMF? - Regardless of the previous, adding the new driver should be a patch of its own. - I spotted an incorrect reference to PCI_IO_DEV in a comment (patch #2) > > Tests done: > A. GCC5 & VS2015x86 tool chains build pass > B. Launch QEMU (2.4.50, Windows) with command: > > qemu-system-x86_64.exe -pflash \OVMF.fd -serial file:1.txt -serial file:2.txt > > Able to see the ISA COM1/COM2 UART and PS2Keyboard devices under Shell > using command 'devtree'; > > Both the serials and PS2 keyboard are working fine; > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Ray Ni > > Hao Wu (2): > OvmfPkg: Drop the ISA Floppy device support > OvmfPkg: Add an Super IO bus driver to replace the current ISA support > > OvmfPkg/OvmfPkgIa32.dsc | 10 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 10 +- > OvmfPkg/OvmfPkgX64.dsc | 10 +- > OvmfPkg/OvmfPkgIa32.fdf | 10 +- > OvmfPkg/OvmfPkgIa32X64.fdf | 10 +- > OvmfPkg/OvmfPkgX64.fdf | 10 +- > OvmfPkg/SioBusDxe/SioBusDxe.inf | 54 ++ > OvmfPkg/SioBusDxe/SioBusDxe.h | 332 +++++++++++ > OvmfPkg/SioBusDxe/SioService.h | 221 +++++++ > OvmfPkg/SioBusDxe/ComponentName.c | 167 ++++++ > OvmfPkg/SioBusDxe/SioBusDxe.c | 622 ++++++++++++++++++++ > OvmfPkg/SioBusDxe/SioService.c | 405 +++++++++++++ > OvmfPkg/SioBusDxe/SioBusDxe.uni | 21 + > 13 files changed, 1846 insertions(+), 36 deletions(-) > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.inf > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.h > create mode 100644 OvmfPkg/SioBusDxe/SioService.h > create mode 100644 OvmfPkg/SioBusDxe/ComponentName.c > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.c > create mode 100644 OvmfPkg/SioBusDxe/SioService.c > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.uni > > -- > 2.12.0.windows.1 >